Message ID | 20230509015915.77182-2-marex@denx.de |
---|---|
State | New |
Headers | show |
Series | [meta-oe,1/3] lvgl: Upgrade dialog-lvgl to next/main version | expand |
Are these patches on top of previous ones ? Or replacement ? On Mon, May 8, 2023 at 6:59 PM Marek Vasut <marex@denx.de> wrote: > The lvgl-demo-fb depends on specific configuration of LVGL which > includes demo widgets, which as far as I can tell are not needed > for regular LVGL application development. Reinstate the gitsm in > this recipe temporarily, so it can again build its own version of > LVGL and stops failing to build, at least until better fix exists. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > NOTE: I am almost tempted to drop this recipe, it basically builds > two files against LVGL configured in specific way. And it seems the > LVGL has no modularity support, so we cannot deal with packaging > the extra widgets easily. > --- > Cc: Fabio Estevam <festevam@denx.de> > Cc: Khem Raj <raj.khem@gmail.com> > Cc: Martin Jansa <martin.jansa@gmail.com> > Cc: Philippe Coval <philippe.coval.ext@huawei.com> > Cc: Philippe Coval <philippe.coval@huawei.com> > --- > meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb > b/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb > index 6d9ff89f5..d86d6ff9c 100644 > --- a/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb > +++ b/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb > @@ -5,9 +5,7 @@ LIC_FILES_CHKSUM = > "file://LICENSE;md5=802d3d83ae80ef5f343050bf96cce3a4 \ > > file://lv_drivers/LICENSE;md5=d6fc0df890c5270ef045981b516bb8f2 \ > > file://lvgl/LICENCE.txt;md5=bf1198c89ae87f043108cea62460b03a" > > -DEPENDS = "lvgl lv-drivers" > - > -SRC_URI = "git:// > github.com/lvgl/lv_port_linux_frame_buffer.git;branch=master;protocol=https > " > +SRC_URI = "gitsm:// > github.com/lvgl/lv_port_linux_frame_buffer.git;branch=master;protocol=https > " > SRCREV = "adf2c4490e17a1b9ec1902cc412a24b3b8235c8e" > > S = "${WORKDIR}/git" > -- > 2.39.2 > >
On 5/9/23 04:13, Khem Raj wrote: > Are these patches on top of previous ones ? > Or replacement ? On top of previous ones. Do you want a squashed V2 instead ?
Yes, please! On Mon, May 8, 2023 at 7:14 PM Marek Vasut <marex@denx.de> wrote: > On 5/9/23 04:13, Khem Raj wrote: > > Are these patches on top of previous ones ? > > Or replacement ? > > On top of previous ones. > > Do you want a squashed V2 instead ? >
diff --git a/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb b/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb index 6d9ff89f5..d86d6ff9c 100644 --- a/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb +++ b/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb @@ -5,9 +5,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=802d3d83ae80ef5f343050bf96cce3a4 \ file://lv_drivers/LICENSE;md5=d6fc0df890c5270ef045981b516bb8f2 \ file://lvgl/LICENCE.txt;md5=bf1198c89ae87f043108cea62460b03a" -DEPENDS = "lvgl lv-drivers" - -SRC_URI = "git://github.com/lvgl/lv_port_linux_frame_buffer.git;branch=master;protocol=https" +SRC_URI = "gitsm://github.com/lvgl/lv_port_linux_frame_buffer.git;branch=master;protocol=https" SRCREV = "adf2c4490e17a1b9ec1902cc412a24b3b8235c8e" S = "${WORKDIR}/git"
The lvgl-demo-fb depends on specific configuration of LVGL which includes demo widgets, which as far as I can tell are not needed for regular LVGL application development. Reinstate the gitsm in this recipe temporarily, so it can again build its own version of LVGL and stops failing to build, at least until better fix exists. Signed-off-by: Marek Vasut <marex@denx.de> --- NOTE: I am almost tempted to drop this recipe, it basically builds two files against LVGL configured in specific way. And it seems the LVGL has no modularity support, so we cannot deal with packaging the extra widgets easily. --- Cc: Fabio Estevam <festevam@denx.de> Cc: Khem Raj <raj.khem@gmail.com> Cc: Martin Jansa <martin.jansa@gmail.com> Cc: Philippe Coval <philippe.coval.ext@huawei.com> Cc: Philippe Coval <philippe.coval@huawei.com> --- meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)