diff mbox series

[meta-oe] khronos-cts: Replace wayland feature dependancy with vulkan

Message ID 20230414063533.11913-1-linusja@axis.com
State Under Review
Headers show
Series [meta-oe] khronos-cts: Replace wayland feature dependancy with vulkan | expand

Commit Message

Linus Jacobson April 14, 2023, 6:35 a.m. UTC
Khronos-cts.inc is used for building vulkan-cts or opengl-es-cts. Even
though vulkan-cts depends on vulkan-loader, which automatically
requires vulkan distro feature, it is more explicitly stated if written
here next to opengl.

Some systems do not support a windowing service (like wayland) but still
might use standard khronos GPU libraries. For these cases, wayland
dependancy is invalid.

Patch replaces the invalid wayland distro feature dependancy with
vulkan for clarity.
---
 meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Kjellerstedt April 18, 2023, 7:22 p.m. UTC | #1
Can this be backported to Mickledore?

//Peter

> -----Original Message-----
> From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Linus Jacobson
> Sent: den 14 april 2023 08:36
> To: openembedded-devel@lists.openembedded.org
> Cc: Linus Jacobson <Linus.Jacobson@axis.com>
> Subject: [oe] [meta-oe][PATCH] khronos-cts: Replace wayland feature dependancy with vulkan
> 
> Khronos-cts.inc is used for building vulkan-cts or opengl-es-cts. Even
> though vulkan-cts depends on vulkan-loader, which automatically
> requires vulkan distro feature, it is more explicitly stated if written
> here next to opengl.
> 
> Some systems do not support a windowing service (like wayland) but still
> might use standard khronos GPU libraries. For these cases, wayland
> dependancy is invalid.
> 
> Patch replaces the invalid wayland distro feature dependancy with
> vulkan for clarity.
> ---
>  meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
> index f9074556f..1fda43521 100644
> --- a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
> +++ b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
> @@ -20,7 +20,7 @@ S = "${WORKDIR}/git"
> 
>  inherit pkgconfig cmake features_check python3native qemu
> 
> -ANY_OF_DISTRO_FEATURES += "opengl wayland"
> +ANY_OF_DISTRO_FEATURES += "opengl vulkan"
> 
>  DEPENDS += "python3-lxml-native libpng zlib virtual/libgles2 qemu-native"
> 
> --
> 2.20.1
diff mbox series

Patch

diff --git a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
index f9074556f..1fda43521 100644
--- a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
+++ b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
@@ -20,7 +20,7 @@  S = "${WORKDIR}/git"
 
 inherit pkgconfig cmake features_check python3native qemu
 
-ANY_OF_DISTRO_FEATURES += "opengl wayland"
+ANY_OF_DISTRO_FEATURES += "opengl vulkan"
 
 DEPENDS += "python3-lxml-native libpng zlib virtual/libgles2 qemu-native"