| Message ID | 20230208131157.2564692-1-archana.polampalli@windriver.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [meta-oe,1/1] Nodejs: fix buildpaths warning | expand |
This breaks the do_install when "shared" PACKAGECONFIG is enabled, see: http://errors.yoctoproject.org/Errors/Details/689959/ On Wed, Feb 8, 2023 at 2:12 PM Polampalli, Archana < archana.polampalli@windriver.com> wrote: > Correct libdir used at configure time to avoid packaging warnings > WARNING: nodejs-18.12.1-r0 do_package_qa: QA Issue: > File /usr/bin/node in package nodejs contains reference to TMPDIR > [buildpaths] > File /usr/bin/.debug/node in package nodejs-dbg contains reference to > TMPDIR > File /usr/lib64/nodejs/ptest/.debug/cctest in package nodejs-dbg contains > reference to TMPDIR [buildpaths] > File /usr/lib64/nodejs/ptest/cctest in package nodejs-ptest contains > reference to TMPDIR [buildpaths] > File /usr/include/node/config.gypi in package nodejs-dev contains > reference to TMPDIR [buildpaths] > > Signed-off-by: Archana Polampalli <archana.polampalli@windriver.com> > --- > meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb > b/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb > index e96913e56..04a80a6b8 100644 > --- a/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb > +++ b/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb > @@ -145,7 +145,7 @@ do_configure () { > --without-etw \ > --dest-cpu="${@map_nodejs_arch(d.getVar('TARGET_ARCH'), > d)}" \ > --dest-os=linux \ > - --libdir=${D}${libdir} \ > + --libdir=${libdir} \ > ${ARCHFLAGS} \ > ${PACKAGECONFIG_CONFARGS} > } > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#100995): > https://lists.openembedded.org/g/openembedded-devel/message/100995 > Mute This Topic: https://lists.openembedded.org/mt/96829436/3617156 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > Martin.Jansa@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Wed, Feb 15, 2023 at 9:27 PM Martin Jansa via lists.openembedded.org <Martin.Jansa=gmail.com@lists.openembedded.org> wrote: > This breaks the do_install when "shared" PACKAGECONFIG is enabled, see: > > http://errors.yoctoproject.org/Errors/Details/689959/ > Using baselib (just "lib") works and install respects prefix as well, so it ends in image/usr/lib/libnode.so.108 as before and there are no TMPDIR warnings as well. On Wed, Feb 8, 2023 at 2:12 PM Polampalli, Archana < > archana.polampalli@windriver.com> wrote: > >> Correct libdir used at configure time to avoid packaging warnings >> WARNING: nodejs-18.12.1-r0 do_package_qa: QA Issue: >> File /usr/bin/node in package nodejs contains reference to TMPDIR >> [buildpaths] >> File /usr/bin/.debug/node in package nodejs-dbg contains reference to >> TMPDIR >> File /usr/lib64/nodejs/ptest/.debug/cctest in package nodejs-dbg contains >> reference to TMPDIR [buildpaths] >> File /usr/lib64/nodejs/ptest/cctest in package nodejs-ptest contains >> reference to TMPDIR [buildpaths] >> File /usr/include/node/config.gypi in package nodejs-dev contains >> reference to TMPDIR [buildpaths] >> >> Signed-off-by: Archana Polampalli <archana.polampalli@windriver.com> >> --- >> meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb >> b/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb >> index e96913e56..04a80a6b8 100644 >> --- a/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb >> +++ b/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb >> @@ -145,7 +145,7 @@ do_configure () { >> --without-etw \ >> --dest-cpu="${@map_nodejs_arch(d.getVar('TARGET_ARCH'), >> d)}" \ >> --dest-os=linux \ >> - --libdir=${D}${libdir} \ >> + --libdir=${libdir} \ >> ${ARCHFLAGS} \ >> ${PACKAGECONFIG_CONFARGS} >> } >> -- >> 2.34.1 >> >> >> >> >> > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#101084): > https://lists.openembedded.org/g/openembedded-devel/message/101084 > Mute This Topic: https://lists.openembedded.org/mt/96829436/3617156 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > Martin.Jansa@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Wed, Feb 15, 2023 at 12:27 PM Martin Jansa <Martin.Jansa@gmail.com> wrote: > > This breaks the do_install when "shared" PACKAGECONFIG is enabled, see: > > http://errors.yoctoproject.org/Errors/Details/689959/ > I wonder if --libdir assumption is right about having absolute paths. We might want to fix that and add a staging install prefix if set > > On Wed, Feb 8, 2023 at 2:12 PM Polampalli, Archana <archana.polampalli@windriver.com> wrote: >> >> Correct libdir used at configure time to avoid packaging warnings >> WARNING: nodejs-18.12.1-r0 do_package_qa: QA Issue: >> File /usr/bin/node in package nodejs contains reference to TMPDIR [buildpaths] >> File /usr/bin/.debug/node in package nodejs-dbg contains reference to TMPDIR >> File /usr/lib64/nodejs/ptest/.debug/cctest in package nodejs-dbg contains reference to TMPDIR [buildpaths] >> File /usr/lib64/nodejs/ptest/cctest in package nodejs-ptest contains reference to TMPDIR [buildpaths] >> File /usr/include/node/config.gypi in package nodejs-dev contains reference to TMPDIR [buildpaths] >> >> Signed-off-by: Archana Polampalli <archana.polampalli@windriver.com> >> --- >> meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb b/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb >> index e96913e56..04a80a6b8 100644 >> --- a/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb >> +++ b/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb >> @@ -145,7 +145,7 @@ do_configure () { >> --without-etw \ >> --dest-cpu="${@map_nodejs_arch(d.getVar('TARGET_ARCH'), d)}" \ >> --dest-os=linux \ >> - --libdir=${D}${libdir} \ >> + --libdir=${libdir} \ >> ${ARCHFLAGS} \ >> ${PACKAGECONFIG_CONFARGS} >> } >> -- >> 2.34.1 >> >> >> >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#101084): https://lists.openembedded.org/g/openembedded-devel/message/101084 > Mute This Topic: https://lists.openembedded.org/mt/96829436/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Wed, Feb 15, 2023 at 1:00 PM Martin Jansa <Martin.Jansa@gmail.com> wrote: > > On Wed, Feb 15, 2023 at 9:27 PM Martin Jansa via lists.openembedded.org <Martin.Jansa=gmail.com@lists.openembedded.org> wrote: >> >> This breaks the do_install when "shared" PACKAGECONFIG is enabled, see: >> >> http://errors.yoctoproject.org/Errors/Details/689959/ > > > Using baselib (just "lib") works and install respects prefix as well, so it ends in image/usr/lib/libnode.so.108 as before and there are no TMPDIR warnings as well. interesting. Is it installing everything in right places ? > >> On Wed, Feb 8, 2023 at 2:12 PM Polampalli, Archana <archana.polampalli@windriver.com> wrote: >>> >>> Correct libdir used at configure time to avoid packaging warnings >>> WARNING: nodejs-18.12.1-r0 do_package_qa: QA Issue: >>> File /usr/bin/node in package nodejs contains reference to TMPDIR [buildpaths] >>> File /usr/bin/.debug/node in package nodejs-dbg contains reference to TMPDIR >>> File /usr/lib64/nodejs/ptest/.debug/cctest in package nodejs-dbg contains reference to TMPDIR [buildpaths] >>> File /usr/lib64/nodejs/ptest/cctest in package nodejs-ptest contains reference to TMPDIR [buildpaths] >>> File /usr/include/node/config.gypi in package nodejs-dev contains reference to TMPDIR [buildpaths] >>> >>> Signed-off-by: Archana Polampalli <archana.polampalli@windriver.com> >>> --- >>> meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb b/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb >>> index e96913e56..04a80a6b8 100644 >>> --- a/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb >>> +++ b/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb >>> @@ -145,7 +145,7 @@ do_configure () { >>> --without-etw \ >>> --dest-cpu="${@map_nodejs_arch(d.getVar('TARGET_ARCH'), d)}" \ >>> --dest-os=linux \ >>> - --libdir=${D}${libdir} \ >>> + --libdir=${libdir} \ >>> ${ARCHFLAGS} \ >>> ${PACKAGECONFIG_CONFARGS} >>> } >>> -- >>> 2.34.1 >>> >>> >>> >>> >> >> >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#101085): https://lists.openembedded.org/g/openembedded-devel/message/101085 > Mute This Topic: https://lists.openembedded.org/mt/96829436/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb b/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb index e96913e56..04a80a6b8 100644 --- a/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb +++ b/meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb @@ -145,7 +145,7 @@ do_configure () { --without-etw \ --dest-cpu="${@map_nodejs_arch(d.getVar('TARGET_ARCH'), d)}" \ --dest-os=linux \ - --libdir=${D}${libdir} \ + --libdir=${libdir} \ ${ARCHFLAGS} \ ${PACKAGECONFIG_CONFARGS} }
Correct libdir used at configure time to avoid packaging warnings WARNING: nodejs-18.12.1-r0 do_package_qa: QA Issue: File /usr/bin/node in package nodejs contains reference to TMPDIR [buildpaths] File /usr/bin/.debug/node in package nodejs-dbg contains reference to TMPDIR File /usr/lib64/nodejs/ptest/.debug/cctest in package nodejs-dbg contains reference to TMPDIR [buildpaths] File /usr/lib64/nodejs/ptest/cctest in package nodejs-ptest contains reference to TMPDIR [buildpaths] File /usr/include/node/config.gypi in package nodejs-dev contains reference to TMPDIR [buildpaths] Signed-off-by: Archana Polampalli <archana.polampalli@windriver.com> --- meta-oe/recipes-devtools/nodejs/nodejs_18.12.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)