diff mbox series

[meta-gnome] gnome:terminal add missing inherit meson

Message ID 20230105153531.932402-1-f_l_k@t-online.de
State Under Review
Headers show
Series [meta-gnome] gnome:terminal add missing inherit meson | expand

Commit Message

Markus Volk Jan. 5, 2023, 3:35 p.m. UTC
When testing Gnome recipes at runtime, I noticed that inherit meson was missing
and gnome-terminal was not compiled. Fix this

Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 .../recipes-gnome/gnome-terminal/gnome-terminal_3.46.7.bb   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Alexander Kanavin Jan. 5, 2023, 3:43 p.m. UTC | #1
Presence of '  GNOMEBASEBUILDCLASS = "meson"' indicates that the
recipe should be inheriting gnomebase class rather. Did it get
erroneously dropped at some point?

Alex

On Thu, 5 Jan 2023 at 16:36, Markus Volk <f_l_k@t-online.de> wrote:
>
> When testing Gnome recipes at runtime, I noticed that inherit meson was missing
> and gnome-terminal was not compiled. Fix this
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  .../recipes-gnome/gnome-terminal/gnome-terminal_3.46.7.bb   | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta-gnome/recipes-gnome/gnome-terminal/gnome-terminal_3.46.7.bb b/meta-gnome/recipes-gnome/gnome-terminal/gnome-terminal_3.46.7.bb
> index 69af11c91..d9afeec46 100644
> --- a/meta-gnome/recipes-gnome/gnome-terminal/gnome-terminal_3.46.7.bb
> +++ b/meta-gnome/recipes-gnome/gnome-terminal/gnome-terminal_3.46.7.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = " \
>
>  GNOMEBASEBUILDCLASS = "meson"
>
> -inherit gsettings gnome-help gettext itstool upstream-version-is-even
> +inherit pkgconfig meson gsettings gnome-help gettext itstool upstream-version-is-even
>
>  DEPENDS = " \
>      glib-2.0 \
> @@ -30,8 +30,8 @@ PACKAGECONFIG[nautilus] = "-Dnautilus_extension=true,-Dnautilus_extension=false,
>  PACKAGECONFIG[search_provider] = "-Dsearch_provider=true,-Dsearch_provider=false,,gnome-shell"
>
>  FILES:${PN} += " \
> -    ${datadir}/metainfo \
> -    ${datadir}/dbus-1 \
> +    ${datadir} \
> +    ${libdir}/nautilus/extensions-4 \
>      ${systemd_user_unitdir} \
>  "
>
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#100416): https://lists.openembedded.org/g/openembedded-devel/message/100416
> Mute This Topic: https://lists.openembedded.org/mt/96074078/1686489
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-gnome/recipes-gnome/gnome-terminal/gnome-terminal_3.46.7.bb b/meta-gnome/recipes-gnome/gnome-terminal/gnome-terminal_3.46.7.bb
index 69af11c91..d9afeec46 100644
--- a/meta-gnome/recipes-gnome/gnome-terminal/gnome-terminal_3.46.7.bb
+++ b/meta-gnome/recipes-gnome/gnome-terminal/gnome-terminal_3.46.7.bb
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = " \
 
 GNOMEBASEBUILDCLASS = "meson"
 
-inherit gsettings gnome-help gettext itstool upstream-version-is-even
+inherit pkgconfig meson gsettings gnome-help gettext itstool upstream-version-is-even
 
 DEPENDS = " \
     glib-2.0 \
@@ -30,8 +30,8 @@  PACKAGECONFIG[nautilus] = "-Dnautilus_extension=true,-Dnautilus_extension=false,
 PACKAGECONFIG[search_provider] = "-Dsearch_provider=true,-Dsearch_provider=false,,gnome-shell"
 
 FILES:${PN} += " \
-    ${datadir}/metainfo \
-    ${datadir}/dbus-1 \
+    ${datadir} \
+    ${libdir}/nautilus/extensions-4 \
     ${systemd_user_unitdir} \
 "