Message ID | 20221201082430.1569827-2-tomasz.zyjewski@3mdeb.com |
---|---|
State | New |
Headers | show |
Series | ['meta-python,V2',1/2] python3-binwalk: add recipe for version 2.3.3 | expand |
Hi Tomasz Thanks for the patches! On 12/1/22 09:24, tomzy wrote: > Install uefi-firmware-parser tool > > The UEFI firmware parseer is a simple module and set of scripts for > parsing, extracting, and recreating UEFI firmware volumes. > > Signed-off-by: Tomasz Żyjewski <tomasz.zyjewski@3mdeb.com> > --- > .../python/python3-uefi-firmware_1.9.bb | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 meta-python/recipes-devtools/python/python3-uefi-firmware_1.9.bb However, if I apply your patch through "git am", the author of the commit will be: tomzy <tomasz.zyjewski@3mdeb.com> instead of Tomasz Żyjewski <tomasz.zyjewski@3mdeb.com> Because of this issue, the maintainer has to manually fix this field when accepting your patch. Worse, if he doesn't catch this, that's harder to fix afterwards. You should be able to fix this by running: git config --global sendemail.from "tomasz.zyjewski@3mdeb.com" This should add a "From" field to the sent patch which "git am" should be able to match with your name. See https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email Could you try to send an update (don't hesitate to send a private one to me first)? Thanks in advance Michael.
On Fri, Dec 2, 2022 at 10:56 AM, Michael Opdenacker wrote: > > Hi Tomasz Hi > > Thanks for the patches! > > On 12/1/22 09:24, tomzy wrote: > >> Install uefi-firmware-parser tool >> >> The UEFI firmware parseer is a simple module and set of scripts for >> parsing, extracting, and recreating UEFI firmware volumes. >> >> Signed-off-by: Tomasz Żyjewski <tomasz.zyjewski@3mdeb.com> >> --- >> .../python/python3-uefi-firmware_1.9.bb | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 >> meta-python/recipes-devtools/python/python3-uefi-firmware_1.9.bb > > However, if I apply your patch through "git am", the author of the > commit will be: > tomzy <tomasz.zyjewski@3mdeb.com> > instead of > Tomasz Żyjewski <tomasz.zyjewski@3mdeb.com> > > Because of this issue, the maintainer has to manually fix this field > when accepting your patch. Worse, if he doesn't catch this, that's > harder to fix afterwards. I was not aware of this issue. I must have missed it in guidelines. Sorry for that! > > > You should be able to fix this by running: > git config --global sendemail.from "tomasz.zyjewski@3mdeb.com" > > This should add a "From" field to the sent patch which "git am" should > be able to match with your name. > See > https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email > > > Could you try to send an update (don't hesitate to send a private one to > me first)? Thank you, I will try that. Should I use `michael.opdenacker@bootlin.com` ? > > > Thanks in advance > Michael. > > -- > Michael Opdenacker, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
diff --git a/meta-python/recipes-devtools/python/python3-uefi-firmware_1.9.bb b/meta-python/recipes-devtools/python/python3-uefi-firmware_1.9.bb new file mode 100644 index 000000000000..3837a17437b1 --- /dev/null +++ b/meta-python/recipes-devtools/python/python3-uefi-firmware_1.9.bb @@ -0,0 +1,17 @@ +SUMMARY = "Various data structures and parsing tools for UEFI firmware." +DESCRIPTION = "This package contains Python UEFI firmware parser tool. The \ +UEFI firmware parser is a simple module and set of scripts for parsing, \ +extracting, and recreating UEFI firmware volumes. This includes parsing \ +modules for BIOS, OptionROM, Intel ME and other formats too." +HOMEPAGE = "https://github.com/theopolis/uefi-firmware-parser" +AUTHOR = "Teddy Reed <teddy@prosauce.org>" +LICENSE = "BSD-2-Clause & BSD-3-Clause" +LIC_FILES_CHKSUM = "file://setup.py;md5=90fa5bae1547550f1c1993f651eda955" + +SRC_URI = "git://github.com/theopolis/uefi-firmware-parser;protocol=https;branch=master" + +SRCREV = "502f1bada1ed11fdd1792646fda0bfafb8fa57fb" + +S = "${WORKDIR}/git" + +inherit setuptools3
Install uefi-firmware-parser tool The UEFI firmware parseer is a simple module and set of scripts for parsing, extracting, and recreating UEFI firmware volumes. Signed-off-by: Tomasz Żyjewski <tomasz.zyjewski@3mdeb.com> --- .../python/python3-uefi-firmware_1.9.bb | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 meta-python/recipes-devtools/python/python3-uefi-firmware_1.9.bb