diff mbox series

[meta-oe,kirkstone] audit: Install audit.h from audit package.

Message ID 20220923021317.1987661-1-jpuhlman@mvista.com
State New
Headers show
Series [meta-oe,kirkstone] audit: Install audit.h from audit package. | expand

Commit Message

Jeremy Puhlman Sept. 23, 2022, 2:13 a.m. UTC
Source: MontaVista Software, LLC
MR: 121884
Type: Defect Fix
Disposition: Submitted to meta-oe
ChangeID: 2708329947da5ec2f96a8478771f56cfce95f616
Description:

The last upgrade to audit, changed libaudit.h to use "audit.h", which
makes the build work for this package, but breaks any other package
trying to use libaudit.h, like libsemanage.

build/tmp/work/aarch64-montavista-linux/libsemanage/3.3-r0/recipe-sysroot/usr/include/libaudit.h:30:10: fatal error: audit.h: No such file or directory
   30 | #include "audit.h"
      |          ^~~~~~~~~
compilation terminated.

Install audit.h so other applications can use it.

Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
---
 meta-oe/recipes-security/audit/audit_3.0.8.bb | 1 +
 1 file changed, 1 insertion(+)

Comments

Khem Raj Sept. 23, 2022, 3:25 a.m. UTC | #1
does this backport fix it for you

https://patchwork.yoctoproject.org/project/oe/patch/20220921081916.17313-1-mikko.rapeli@linaro.org/

On Thu, Sep 22, 2022 at 10:13 PM Jeremy Puhlman <jpuhlman@mvista.com> wrote:
>
> Source: MontaVista Software, LLC
> MR: 121884
> Type: Defect Fix
> Disposition: Submitted to meta-oe
> ChangeID: 2708329947da5ec2f96a8478771f56cfce95f616
> Description:
>
> The last upgrade to audit, changed libaudit.h to use "audit.h", which
> makes the build work for this package, but breaks any other package
> trying to use libaudit.h, like libsemanage.
>
> build/tmp/work/aarch64-montavista-linux/libsemanage/3.3-r0/recipe-sysroot/usr/include/libaudit.h:30:10: fatal error: audit.h: No such file or directory
>    30 | #include "audit.h"
>       |          ^~~~~~~~~
> compilation terminated.
>
> Install audit.h so other applications can use it.
>
> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
> ---
>  meta-oe/recipes-security/audit/audit_3.0.8.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-security/audit/audit_3.0.8.bb b/meta-oe/recipes-security/audit/audit_3.0.8.bb
> index 3dbfc9e60..6195b6749 100644
> --- a/meta-oe/recipes-security/audit/audit_3.0.8.bb
> +++ b/meta-oe/recipes-security/audit/audit_3.0.8.bb
> @@ -110,4 +110,5 @@ do_install:append() {
>
>         # Create /var/spool/audit directory for audisp-remote
>         install -m 0700 -d ${D}${localstatedir}/spool/audit
> +       install -m 644 ${S}/lib/audit.h ${D}${includedir}/audit.h
>  }
> --
> 2.35.4
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#98934): https://lists.openembedded.org/g/openembedded-devel/message/98934
> Mute This Topic: https://lists.openembedded.org/mt/93862901/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Jeremy Puhlman Sept. 23, 2022, 3:38 a.m. UTC | #2
Yup.

On 9/22/2022 8:25 PM, Khem Raj wrote:
> does this backport fix it for you
>
> https://patchwork.yoctoproject.org/project/oe/patch/20220921081916.17313-1-mikko.rapeli@linaro.org/
>
> On Thu, Sep 22, 2022 at 10:13 PM Jeremy Puhlman <jpuhlman@mvista.com> wrote:
>> Source: MontaVista Software, LLC
>> MR: 121884
>> Type: Defect Fix
>> Disposition: Submitted to meta-oe
>> ChangeID: 2708329947da5ec2f96a8478771f56cfce95f616
>> Description:
>>
>> The last upgrade to audit, changed libaudit.h to use "audit.h", which
>> makes the build work for this package, but breaks any other package
>> trying to use libaudit.h, like libsemanage.
>>
>> build/tmp/work/aarch64-montavista-linux/libsemanage/3.3-r0/recipe-sysroot/usr/include/libaudit.h:30:10: fatal error: audit.h: No such file or directory
>>     30 | #include "audit.h"
>>        |          ^~~~~~~~~
>> compilation terminated.
>>
>> Install audit.h so other applications can use it.
>>
>> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
>> ---
>>   meta-oe/recipes-security/audit/audit_3.0.8.bb | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta-oe/recipes-security/audit/audit_3.0.8.bb b/meta-oe/recipes-security/audit/audit_3.0.8.bb
>> index 3dbfc9e60..6195b6749 100644
>> --- a/meta-oe/recipes-security/audit/audit_3.0.8.bb
>> +++ b/meta-oe/recipes-security/audit/audit_3.0.8.bb
>> @@ -110,4 +110,5 @@ do_install:append() {
>>
>>          # Create /var/spool/audit directory for audisp-remote
>>          install -m 0700 -d ${D}${localstatedir}/spool/audit
>> +       install -m 644 ${S}/lib/audit.h ${D}${includedir}/audit.h
>>   }
>> --
>> 2.35.4
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#98934): https://lists.openembedded.org/g/openembedded-devel/message/98934
>> Mute This Topic: https://lists.openembedded.org/mt/93862901/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
Denys Dmytriyenko Oct. 12, 2022, 7:28 p.m. UTC | #3
On Sun, Sep 25, 2022 at 10:59:57AM -0400, Armin Kuster wrote:
> 
> 
> On 9/22/22 23:38, Jeremy Puhlman wrote:
> >Yup.
> >
> thanks for the feedback.
> 
> commit has been backported.

I see this in kirkstone-next - any ETA when it will merge to kirkstone branch? 
Thanks!


> -armin
> >On 9/22/2022 8:25 PM, Khem Raj wrote:
> >>does this backport fix it for you
> >>
> >>https://patchwork.yoctoproject.org/project/oe/patch/20220921081916.17313-1-mikko.rapeli@linaro.org/
> >>
> >>
> >>On Thu, Sep 22, 2022 at 10:13 PM Jeremy Puhlman
> >><jpuhlman@mvista.com> wrote:
> >>>Source: MontaVista Software, LLC
> >>>MR: 121884
> >>>Type: Defect Fix
> >>>Disposition: Submitted to meta-oe
> >>>ChangeID: 2708329947da5ec2f96a8478771f56cfce95f616
> >>>Description:
> >>>
> >>>The last upgrade to audit, changed libaudit.h to use "audit.h", which
> >>>makes the build work for this package, but breaks any other package
> >>>trying to use libaudit.h, like libsemanage.
> >>>
> >>>build/tmp/work/aarch64-montavista-linux/libsemanage/3.3-r0/recipe-sysroot/usr/include/libaudit.h:30:10:
> >>>fatal error: audit.h: No such file or directory
> >>>    30 | #include "audit.h"
> >>>       |          ^~~~~~~~~
> >>>compilation terminated.
> >>>
> >>>Install audit.h so other applications can use it.
> >>>
> >>>Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
> >>>---
> >>>  meta-oe/recipes-security/audit/audit_3.0.8.bb | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>>diff --git a/meta-oe/recipes-security/audit/audit_3.0.8.bb
> >>>b/meta-oe/recipes-security/audit/audit_3.0.8.bb
> >>>index 3dbfc9e60..6195b6749 100644
> >>>--- a/meta-oe/recipes-security/audit/audit_3.0.8.bb
> >>>+++ b/meta-oe/recipes-security/audit/audit_3.0.8.bb
> >>>@@ -110,4 +110,5 @@ do_install:append() {
> >>>
> >>>         # Create /var/spool/audit directory for audisp-remote
> >>>         install -m 0700 -d ${D}${localstatedir}/spool/audit
> >>>+       install -m 644 ${S}/lib/audit.h ${D}${includedir}/audit.h
> >>>  }
> >>>-- 
> >>>2.35.4
diff mbox series

Patch

diff --git a/meta-oe/recipes-security/audit/audit_3.0.8.bb b/meta-oe/recipes-security/audit/audit_3.0.8.bb
index 3dbfc9e60..6195b6749 100644
--- a/meta-oe/recipes-security/audit/audit_3.0.8.bb
+++ b/meta-oe/recipes-security/audit/audit_3.0.8.bb
@@ -110,4 +110,5 @@  do_install:append() {
 
 	# Create /var/spool/audit directory for audisp-remote
 	install -m 0700 -d ${D}${localstatedir}/spool/audit
+	install -m 644 ${S}/lib/audit.h ${D}${includedir}/audit.h
 }