diff mbox series

[meta-oe] lvm2: use bfd even with ld-is-gold in DISTRO_FEATURES

Message ID 20220911191217.2596456-1-Martin.Jansa@gmail.com
State New
Headers show
Series [meta-oe] lvm2: use bfd even with ld-is-gold in DISTRO_FEATURES | expand

Commit Message

Martin Jansa Sept. 11, 2022, 7:12 p.m. UTC
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-oe/recipes-support/lvm2/lvm2.inc | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Khem Raj Sept. 11, 2022, 11:22 p.m. UTC | #1
Hi Martin

On Sun, Sep 11, 2022 at 12:12 PM Martin Jansa <Martin.Jansa@gmail.com> wrote:
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta-oe/recipes-support/lvm2/lvm2.inc | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
> index 34e57ec7a5..dfabf11e2f 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2.inc
> +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
> @@ -57,3 +57,7 @@ EXTRA_OECONF = "--with-user= \
>                  --with-thin-repair=${sbindir}/thin_repair \
>                  --with-thin-restore=${sbindir}/thin_restore \
>  "
> +
> +# gold doesn't like multiple dm_bitset_parse_list definitions in libdm/.exported_symbols.DM_1_02_138 and libdm/.exported_symbols.DM_1_02_129
> +# after it was uncommented in the later in 2.03.12 with https://github.com/lvmteam/lvm2/commit/60eb608d66c2056a78e81f27db3da14139d9faab
> +LDFLAGS += "-fuse-ld=bfd"

We do have third player in the game, lld and this would mean
that even lld is disabled. so perhaps its better apply this only when
ld-is-gold distro feature is on.

> --
> 2.37.3
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#98737): https://lists.openembedded.org/g/openembedded-devel/message/98737
> Mute This Topic: https://lists.openembedded.org/mt/93618041/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
index 34e57ec7a5..dfabf11e2f 100644
--- a/meta-oe/recipes-support/lvm2/lvm2.inc
+++ b/meta-oe/recipes-support/lvm2/lvm2.inc
@@ -57,3 +57,7 @@  EXTRA_OECONF = "--with-user= \
                 --with-thin-repair=${sbindir}/thin_repair \
                 --with-thin-restore=${sbindir}/thin_restore \
 "
+
+# gold doesn't like multiple dm_bitset_parse_list definitions in libdm/.exported_symbols.DM_1_02_138 and libdm/.exported_symbols.DM_1_02_129
+# after it was uncommented in the later in 2.03.12 with https://github.com/lvmteam/lvm2/commit/60eb608d66c2056a78e81f27db3da14139d9faab
+LDFLAGS += "-fuse-ld=bfd"