| Message ID | 20220716031434.4021879-3-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-python,1/3] python3-antlr4-runtime: Inherit setuptools3 instead of python_setuptools_build_meta | expand |
> On 16 Jul 2022, at 04:14, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote: > > Adds missing dependency on python3-picobuild-native Erm, no. python_setuptools_build_meta inherits python_pep517 which does DEPENDS:append = " python3-picobuild-native python3-installer-native” The right fix may be using the setuptools3 class as the build isn’t pep compliant, but the comment isn’t accurate, and the picobuild 0.2 upgrade queued for oe-core improves “legacy” setuptools builds too. Ross
> the picobuild 0.2 upgrade queued for oe-core improves “legacy” setuptools builds too.
I’ve just looked at the logs and this is the correct fix. Don’t merge these, just wait for picobuild 0.2 to land.
Ross
On Mon, Jul 18, 2022 at 8:09 AM Ross Burton <Ross.Burton@arm.com> wrote: > *> *the picobuild 0.2 upgrade queued for oe-core improves “legacy” > setuptools builds too. > > I’ve just looked at the logs and this is the correct fix. Don’t merge > these, just wait for picobuild 0.2 to land. > > Ah a bit late but we can apply the new fixes once it lands on core > > Ross >
It’s already in core, can you just revert these please. Ross From: Khem Raj <raj.khem@gmail.com> Date: Monday, 18 July 2022 at 15:46 To: Ross Burton <Ross.Burton@arm.com> Cc: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> Subject: Re: [oe] [meta-oe][PATCH 3/3] python3-pycups: Inherit setuptools3 instead of python_setuptools_build_meta On Mon, Jul 18, 2022 at 8:09 AM Ross Burton <Ross.Burton@arm.com<mailto:Ross.Burton@arm.com>> wrote: > the picobuild 0.2 upgrade queued for oe-core improves “legacy” setuptools builds too. I’ve just looked at the logs and this is the correct fix. Don’t merge these, just wait for picobuild 0.2 to land. Ah a bit late but we can apply the new fixes once it lands on core Ross
diff --git a/meta-oe/recipes-devtools/python/python3-pycups_2.0.1.bb b/meta-oe/recipes-devtools/python/python3-pycups_2.0.1.bb index 1508273009..67cd1a2277 100644 --- a/meta-oe/recipes-devtools/python/python3-pycups_2.0.1.bb +++ b/meta-oe/recipes-devtools/python/python3-pycups_2.0.1.bb @@ -16,4 +16,4 @@ DEPENDS += "cups" # See https://pypi.org/project/pycups/ for data SRC_URI[sha256sum] = "57434ce5f62548eb12949ca8217f066f4eeb21a5d6ab8b13471dce350e380c90" -inherit pypi python_setuptools_build_meta +inherit pypi setuptools3
Adds missing dependency on python3-picobuild-native Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta-oe/recipes-devtools/python/python3-pycups_2.0.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)