[meta-oe] gpsd: split python utils from gps-utils

Message ID 20220420094227.2826875-1-dmitry.baryshkov@linaro.org
State New
Headers show
Series [meta-oe] gpsd: split python utils from gps-utils | expand

Commit Message

Dmitry Baryshkov April 20, 2022, 9:42 a.m. UTC
Neither gpsd nor significant part of gps-utils depend on python. However
installing gps-utils package would require installing python, which adds
about 17 MB to the image size. Split away gps-utils-python to allow
using gpsd/gps-utils in the systems with limited resources (or in the
initramfs).

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../recipes-navigation/gpsd/gpsd_3.23.1.bb    | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)

Comments

Khem Raj April 20, 2022, 2:53 p.m. UTC | #1
It does not apply on top of master-next, can you rebase
and resend please.

On 4/20/22 02:42, Dmitry Baryshkov wrote:
> Neither gpsd nor significant part of gps-utils depend on python. However
> installing gps-utils package would require installing python, which adds
> about 17 MB to the image size. Split away gps-utils-python to allow
> using gpsd/gps-utils in the systems with limited resources (or in the
> initramfs).
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   .../recipes-navigation/gpsd/gpsd_3.23.1.bb    | 23 +++++++++++--------
>   1 file changed, 14 insertions(+), 9 deletions(-)
> 
> diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.23.1.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.23.1.bb
> index c11d4c76d64e..9ed94f7487e0 100644
> --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.23.1.bb
> +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.23.1.bb
> @@ -77,7 +77,7 @@ do_install:append() {
>       install -m 755 ${D}${libdir}/gps/*.py ${D}${PYTHON_SITEPACKAGES_DIR}/gps
>   }
>   
> -PACKAGES =+ "libgps python3-pygps gpsd-udev gpsd-conf gpsd-gpsctl gps-utils"
> +PACKAGES =+ "libgps python3-pygps gpsd-udev gpsd-conf gpsd-gpsctl gps-utils gps-utils-python"
>   
>   RPROVIDES:${PN}-dbg += "python-pygps-dbg"
>   
> @@ -106,31 +106,36 @@ SUMMARY:gps-utils = "Utils used for simulating, monitoring,... a GPS"
>   # Python files are required for gps/fake, required for gpsfake.
>   FILES:gps-utils = "\
>       ${bindir}/cgps         \
> -    ${bindir}/gegps        \
>       ${bindir}/gps2udp      \
> -    ${bindir}/gpscat       \
> -    ${bindir}/gpscsv       \
>       ${bindir}/gpsctl       \
>       ${bindir}/gpsdebuginfo \
>       ${bindir}/gpsdecode    \
> -    ${bindir}/gpsfake      \
>       ${bindir}/gpsmon       \
>       ${bindir}/gpspipe      \
> -    ${bindir}/gpsplot      \
> -    ${bindir}/gpsprof      \
>       ${bindir}/gpsrinex     \
>       ${bindir}/gpssnmp      \
> -    ${bindir}/gpssubframe  \
>       ${bindir}/gpxlogger    \
>       ${bindir}/lcdgps       \
>       ${bindir}/ntpshmmon    \
>       ${bindir}/ppscheck     \
>       ${bindir}/ubxtool      \
> +"
> +RRECOMMENDS:gps-utils = "gps-utils-python"
> +
> +SUMMARY:gps-utils-python = "Python utils used for simulating, monitoring,... a GPS"
> +FILES:gps-utils-python = "\
> +    ${bindir}/gegps        \
> +    ${bindir}/gpscat       \
> +    ${bindir}/gpscsv       \
> +    ${bindir}/gpsfake      \
> +    ${bindir}/gpsplot      \
> +    ${bindir}/gpsprof      \
> +    ${bindir}/gpssubframe  \
>       ${bindir}/xgps         \
>       ${bindir}/xgpsspeed    \
>       ${bindir}/zerk         \
>   "
> -RDEPENDS:gps-utils = "python3-pygps"
> +RDEPENDS:gps-utils-python = "python3-pygps"
>   
>   SUMMARY:python3-pygps = "Python bindings to gpsd"
>   FILES:python3-pygps = "${PYTHON_SITEPACKAGES_DIR}/* ${libdir}/gps/*.py ${libdir}/*.egg-info"
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#96713): https://lists.openembedded.org/g/openembedded-devel/message/96713
> Mute This Topic: https://lists.openembedded.org/mt/90580511/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Dmitry Baryshkov April 20, 2022, 5:42 p.m. UTC | #2
Hi,

ср, 20 апр. 2022 г. в 17:53, Khem Raj <raj.khem@gmail.com>:
>
> It does not apply on top of master-next, can you rebase
> and resend please.

I have rechecked, it applies on top of master-next w/o any issues. Did
you push your master-next branch?

>
> On 4/20/22 02:42, Dmitry Baryshkov wrote:
> > Neither gpsd nor significant part of gps-utils depend on python. However
> > installing gps-utils package would require installing python, which adds
> > about 17 MB to the image size. Split away gps-utils-python to allow
> > using gpsd/gps-utils in the systems with limited resources (or in the
> > initramfs).
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >   .../recipes-navigation/gpsd/gpsd_3.23.1.bb    | 23 +++++++++++--------
> >   1 file changed, 14 insertions(+), 9 deletions(-)

[skipped]
Khem Raj April 20, 2022, 10:08 p.m. UTC | #3
On Wed, Apr 20, 2022 at 10:43 AM Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
>
> Hi,
>
> ср, 20 апр. 2022 г. в 17:53, Khem Raj <raj.khem@gmail.com>:
> >
> > It does not apply on top of master-next, can you rebase
> > and resend please.
>
> I have rechecked, it applies on top of master-next w/o any issues. Did
> you push your master-next branch?
>

yes master-next is up2date but groking this patch from mailing list
via an email client
and then git am'ing it is failing, too mant hoops to jump for catching
patches so there could be something
wrong on the way. Regardless I have done the conflicts manually and pushed
to master-next, hope I did not miss anything

> >
> > On 4/20/22 02:42, Dmitry Baryshkov wrote:
> > > Neither gpsd nor significant part of gps-utils depend on python. However
> > > installing gps-utils package would require installing python, which adds
> > > about 17 MB to the image size. Split away gps-utils-python to allow
> > > using gpsd/gps-utils in the systems with limited resources (or in the
> > > initramfs).
> > >
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > > ---
> > >   .../recipes-navigation/gpsd/gpsd_3.23.1.bb    | 23 +++++++++++--------
> > >   1 file changed, 14 insertions(+), 9 deletions(-)
>
> [skipped]
>
> --
> With best wishes
> Dmitry
Dmitry Baryshkov April 20, 2022, 10:13 p.m. UTC | #4
чт, 21 апр. 2022 г. в 01:08, Khem Raj <raj.khem@gmail.com>:
>
> On Wed, Apr 20, 2022 at 10:43 AM Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
> >
> > Hi,
> >
> > ср, 20 апр. 2022 г. в 17:53, Khem Raj <raj.khem@gmail.com>:
> > >
> > > It does not apply on top of master-next, can you rebase
> > > and resend please.
> >
> > I have rechecked, it applies on top of master-next w/o any issues. Did
> > you push your master-next branch?
> >
>
> yes master-next is up2date but groking this patch from mailing list
> via an email client
> and then git am'ing it is failing, too mant hoops to jump for catching
> patches so there could be something
> wrong on the way. Regardless I have done the conflicts manually and pushed
> to master-next, hope I did not miss anything

Strange. I just used the 'git send-email' on top of the master branch.
The patch in github/master-next looks correct, so all chunks were
applied correctly.
Thank you!

>
> > >
> > > On 4/20/22 02:42, Dmitry Baryshkov wrote:
> > > > Neither gpsd nor significant part of gps-utils depend on python. However
> > > > installing gps-utils package would require installing python, which adds
> > > > about 17 MB to the image size. Split away gps-utils-python to allow
> > > > using gpsd/gps-utils in the systems with limited resources (or in the
> > > > initramfs).
> > > >
> > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > > > ---
> > > >   .../recipes-navigation/gpsd/gpsd_3.23.1.bb    | 23 +++++++++++--------
> > > >   1 file changed, 14 insertions(+), 9 deletions(-)
> >
> > [skipped]
> >
> > --
> > With best wishes
> > Dmitry

Patch

diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.23.1.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.23.1.bb
index c11d4c76d64e..9ed94f7487e0 100644
--- a/meta-oe/recipes-navigation/gpsd/gpsd_3.23.1.bb
+++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.23.1.bb
@@ -77,7 +77,7 @@  do_install:append() {
     install -m 755 ${D}${libdir}/gps/*.py ${D}${PYTHON_SITEPACKAGES_DIR}/gps
 }
 
-PACKAGES =+ "libgps python3-pygps gpsd-udev gpsd-conf gpsd-gpsctl gps-utils"
+PACKAGES =+ "libgps python3-pygps gpsd-udev gpsd-conf gpsd-gpsctl gps-utils gps-utils-python"
 
 RPROVIDES:${PN}-dbg += "python-pygps-dbg"
 
@@ -106,31 +106,36 @@  SUMMARY:gps-utils = "Utils used for simulating, monitoring,... a GPS"
 # Python files are required for gps/fake, required for gpsfake.
 FILES:gps-utils = "\
     ${bindir}/cgps         \
-    ${bindir}/gegps        \
     ${bindir}/gps2udp      \
-    ${bindir}/gpscat       \
-    ${bindir}/gpscsv       \
     ${bindir}/gpsctl       \
     ${bindir}/gpsdebuginfo \
     ${bindir}/gpsdecode    \
-    ${bindir}/gpsfake      \
     ${bindir}/gpsmon       \
     ${bindir}/gpspipe      \
-    ${bindir}/gpsplot      \
-    ${bindir}/gpsprof      \
     ${bindir}/gpsrinex     \
     ${bindir}/gpssnmp      \
-    ${bindir}/gpssubframe  \
     ${bindir}/gpxlogger    \
     ${bindir}/lcdgps       \
     ${bindir}/ntpshmmon    \
     ${bindir}/ppscheck     \
     ${bindir}/ubxtool      \
+"
+RRECOMMENDS:gps-utils = "gps-utils-python"
+
+SUMMARY:gps-utils-python = "Python utils used for simulating, monitoring,... a GPS"
+FILES:gps-utils-python = "\
+    ${bindir}/gegps        \
+    ${bindir}/gpscat       \
+    ${bindir}/gpscsv       \
+    ${bindir}/gpsfake      \
+    ${bindir}/gpsplot      \
+    ${bindir}/gpsprof      \
+    ${bindir}/gpssubframe  \
     ${bindir}/xgps         \
     ${bindir}/xgpsspeed    \
     ${bindir}/zerk         \
 "
-RDEPENDS:gps-utils = "python3-pygps"
+RDEPENDS:gps-utils-python = "python3-pygps"
 
 SUMMARY:python3-pygps = "Python bindings to gpsd"
 FILES:python3-pygps = "${PYTHON_SITEPACKAGES_DIR}/* ${libdir}/gps/*.py ${libdir}/*.egg-info"