[meta-gnome] gparted: update to v1.4.0

Message ID 20220404141948.3373-1-f_l_k@t-online.de
State New
Headers show
Series [meta-gnome] gparted: update to v1.4.0 | expand

Commit Message

Markus Volk April 4, 2022, 2:19 p.m. UTC
- remove x11 features-check because there aren't dependencies that would
  explicilty require x11 as a DISTRO_FEATURE

============================
GParted 1.4.0   (2022-03-28)
============================

Release Notes
-------------
  This release of GParted includes enhancements, bug fixes and
  language translation updates.

  * Add labelling of mounted btrfs, ext2/3/4 and xfs file systems
  * Fix detection of mount points for encrypted file systems
  * Fix crash scrolling quickly in the drive selection combobox
  * Add bcache detection
  * Add JBD external EXT3/4 journal detection

Bug Fixes
---------
  * Add labelling of mounted btrfs, ext2/3/4 and xfs file systems (#163, !87)
  * Fix detection of mount points for encrypted file systems (#162, !88)
  * Fix unmount error when unmounting below a bind mount point (!89)
  * Fix crash scrolling quickly in the drive selection combobox (#165, !91)
  * Add initial Indonesian translation of help (!90)
  * Add accessibility relations for screen readers like Orca (!92)
  * Fix partition creation at sector 2048 if partition before it (#172, !93)
  * Make more getter methods use return-by-constant-reference (!94)
  * Check copy destination instead of source (!95)
  * Add bcache detection (#183, !96)
  * Add JBD external EXT3/4 journal detection (#89, !97)
  * Fix translation of DocBook markup tag of the GParted Manual (!98)

Code Credits
------------
  Code enhancements are courtesy of Movie Ma, Pascal Engélibert, and
  Mike Fleetwood.

Translations (new/updated)
--------------------------
  cs(Marek Černocký), da(Alan Mortensen), eu(Asier Sarasua Garmendia),
  fur(Fabio Tomat), he(Yaron Shahrabani), hr(Goran Vidović),
  hu(Balázs Úr), id(Andika Triwidada), it(Milo Casagrande),
  ko(Seong-ho Cho), lt(Aurimas Černius), lv(Rūdolfs Mazurs),
  nb(Kjell Cato Heskjestad), nl(Nathan Follens), pa(A S Alam),
  pt(Hugo Carvalho), ru(Aleksandr Melman, Sergej A), sk(Dušan Kazik),
  sl(Matej Urbančič), sr(Мирослав Николић), zh_CN(Luming Zh)

Dependencies (new/updated)
--------------------------
  * n/a

Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 .../gparted/{gparted_1.3.1.bb => gparted_1.4.0.bb}           | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
 rename meta-gnome/recipes-extended/gparted/{gparted_1.3.1.bb => gparted_1.4.0.bb} (83%)

Comments

Khem Raj April 7, 2022, 12:17 a.m. UTC | #1
fails on musl

https://errors.yoctoproject.org/Errors/Details/654013/

On Mon, Apr 4, 2022 at 10:20 AM Markus Volk <f_l_k@t-online.de> wrote:
>
> - remove x11 features-check because there aren't dependencies that would
>   explicilty require x11 as a DISTRO_FEATURE
>
> ============================
> GParted 1.4.0   (2022-03-28)
> ============================
>
> Release Notes
> -------------
>   This release of GParted includes enhancements, bug fixes and
>   language translation updates.
>
>   * Add labelling of mounted btrfs, ext2/3/4 and xfs file systems
>   * Fix detection of mount points for encrypted file systems
>   * Fix crash scrolling quickly in the drive selection combobox
>   * Add bcache detection
>   * Add JBD external EXT3/4 journal detection
>
> Bug Fixes
> ---------
>   * Add labelling of mounted btrfs, ext2/3/4 and xfs file systems (#163, !87)
>   * Fix detection of mount points for encrypted file systems (#162, !88)
>   * Fix unmount error when unmounting below a bind mount point (!89)
>   * Fix crash scrolling quickly in the drive selection combobox (#165, !91)
>   * Add initial Indonesian translation of help (!90)
>   * Add accessibility relations for screen readers like Orca (!92)
>   * Fix partition creation at sector 2048 if partition before it (#172, !93)
>   * Make more getter methods use return-by-constant-reference (!94)
>   * Check copy destination instead of source (!95)
>   * Add bcache detection (#183, !96)
>   * Add JBD external EXT3/4 journal detection (#89, !97)
>   * Fix translation of DocBook markup tag of the GParted Manual (!98)
>
> Code Credits
> ------------
>   Code enhancements are courtesy of Movie Ma, Pascal Engélibert, and
>   Mike Fleetwood.
>
> Translations (new/updated)
> --------------------------
>   cs(Marek Černocký), da(Alan Mortensen), eu(Asier Sarasua Garmendia),
>   fur(Fabio Tomat), he(Yaron Shahrabani), hr(Goran Vidović),
>   hu(Balázs Úr), id(Andika Triwidada), it(Milo Casagrande),
>   ko(Seong-ho Cho), lt(Aurimas Černius), lv(Rūdolfs Mazurs),
>   nb(Kjell Cato Heskjestad), nl(Nathan Follens), pa(A S Alam),
>   pt(Hugo Carvalho), ru(Aleksandr Melman, Sergej A), sk(Dušan Kazik),
>   sl(Matej Urbančič), sr(Мирослав Николић), zh_CN(Luming Zh)
>
> Dependencies (new/updated)
> --------------------------
>   * n/a
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  .../gparted/{gparted_1.3.1.bb => gparted_1.4.0.bb}           | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>  rename meta-gnome/recipes-extended/gparted/{gparted_1.3.1.bb => gparted_1.4.0.bb} (83%)
>
> diff --git a/meta-gnome/recipes-extended/gparted/gparted_1.3.1.bb b/meta-gnome/recipes-extended/gparted/gparted_1.4.0.bb
> similarity index 83%
> rename from meta-gnome/recipes-extended/gparted/gparted_1.3.1.bb
> rename to meta-gnome/recipes-extended/gparted/gparted_1.4.0.bb
> index d1a975930..d1297b5a2 100644
> --- a/meta-gnome/recipes-extended/gparted/gparted_1.3.1.bb
> +++ b/meta-gnome/recipes-extended/gparted/gparted_1.4.0.bb
> @@ -3,16 +3,15 @@ HOMEPAGE = "http://gparted.org/index.php"
>  LICENSE = "GPL-2.0-only"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>
> -inherit features_check autotools pkgconfig python3native gnome-help gtk-icon-cache
> +inherit autotools pkgconfig python3native gnome-help gtk-icon-cache
>
> -REQUIRED_DISTRO_FEATURES = "x11"
>
>  SRC_URI = " \
>      ${SOURCEFORGE_MIRROR}/project/${BPN}/${BPN}/${BPN}-${PV}/${BPN}-${PV}.tar.gz \
>      file://0001-Install-polkit-action-unconditionally-executable-pke.patch \
>      file://0001-Do-not-use-NULL-where-boolean-is-expected.patch \
>  "
> -SRC_URI[sha256sum] = "5eee2e6d74b15ef96b13b3a2310c868ed2298e03341021e7d12a5a98a1d1e109"
> +SRC_URI[sha256sum] = "e5293a792e53fdbeba29c4a834113cd9603d0d639330da931a468bf3687887be"
>
>  UPSTREAM_CHECK_URI = "https://sourceforge.net/projects/gparted/files/gparted/"
>  UPSTREAM_CHECK_REGEX = "gparted-(?P<pver>\d+\.(\d+)+(\.\d+)+)"
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#96382): https://lists.openembedded.org/g/openembedded-devel/message/96382
> Mute This Topic: https://lists.openembedded.org/mt/90242693/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Markus Volk April 7, 2022, 8:56 a.m. UTC | #2
I have had a look at this. To me it looks like musl string.h does not 
define basename() for cplusplus. I'm not really an expert on musl or 
c/c++ and don't know the difference between these two functions in 
detail, but I was able to fix the problem for musl by replacing gnu 
basename with glib's variant.

I'll send a v2, but since this is security related stuff, I have to 
admit that I'm not the one to say "this is a proper solution".


Am 07.04.22 um 02:17 schrieb Khem Raj:
> fails on musl
>
> https://errors.yoctoproject.org/Errors/Details/654013/
>
> On Mon, Apr 4, 2022 at 10:20 AM Markus Volk <f_l_k@t-online.de> wrote:
>> - remove x11 features-check because there aren't dependencies that would
>>    explicilty require x11 as a DISTRO_FEATURE
>>
>> ============================
>> GParted 1.4.0   (2022-03-28)
>> ============================
>>
>> Release Notes
>> -------------
>>    This release of GParted includes enhancements, bug fixes and
>>    language translation updates.
>>
>>    * Add labelling of mounted btrfs, ext2/3/4 and xfs file systems
>>    * Fix detection of mount points for encrypted file systems
>>    * Fix crash scrolling quickly in the drive selection combobox
>>    * Add bcache detection
>>    * Add JBD external EXT3/4 journal detection
>>
>> Bug Fixes
>> ---------
>>    * Add labelling of mounted btrfs, ext2/3/4 and xfs file systems (#163, !87)
>>    * Fix detection of mount points for encrypted file systems (#162, !88)
>>    * Fix unmount error when unmounting below a bind mount point (!89)
>>    * Fix crash scrolling quickly in the drive selection combobox (#165, !91)
>>    * Add initial Indonesian translation of help (!90)
>>    * Add accessibility relations for screen readers like Orca (!92)
>>    * Fix partition creation at sector 2048 if partition before it (#172, !93)
>>    * Make more getter methods use return-by-constant-reference (!94)
>>    * Check copy destination instead of source (!95)
>>    * Add bcache detection (#183, !96)
>>    * Add JBD external EXT3/4 journal detection (#89, !97)
>>    * Fix translation of DocBook markup tag of the GParted Manual (!98)
>>
>> Code Credits
>> ------------
>>    Code enhancements are courtesy of Movie Ma, Pascal Engélibert, and
>>    Mike Fleetwood.
>>
>> Translations (new/updated)
>> --------------------------
>>    cs(Marek Černocký), da(Alan Mortensen), eu(Asier Sarasua Garmendia),
>>    fur(Fabio Tomat), he(Yaron Shahrabani), hr(Goran Vidović),
>>    hu(Balázs Úr), id(Andika Triwidada), it(Milo Casagrande),
>>    ko(Seong-ho Cho), lt(Aurimas Černius), lv(Rūdolfs Mazurs),
>>    nb(Kjell Cato Heskjestad), nl(Nathan Follens), pa(A S Alam),
>>    pt(Hugo Carvalho), ru(Aleksandr Melman, Sergej A), sk(Dušan Kazik),
>>    sl(Matej Urbančič), sr(Мирослав Николић), zh_CN(Luming Zh)
>>
>> Dependencies (new/updated)
>> --------------------------
>>    * n/a
>>
>> Signed-off-by: Markus Volk <f_l_k@t-online.de>
>> ---
>>   .../gparted/{gparted_1.3.1.bb => gparted_1.4.0.bb}           | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>   rename meta-gnome/recipes-extended/gparted/{gparted_1.3.1.bb => gparted_1.4.0.bb} (83%)
>>
>> diff --git a/meta-gnome/recipes-extended/gparted/gparted_1.3.1.bb b/meta-gnome/recipes-extended/gparted/gparted_1.4.0.bb
>> similarity index 83%
>> rename from meta-gnome/recipes-extended/gparted/gparted_1.3.1.bb
>> rename to meta-gnome/recipes-extended/gparted/gparted_1.4.0.bb
>> index d1a975930..d1297b5a2 100644
>> --- a/meta-gnome/recipes-extended/gparted/gparted_1.3.1.bb
>> +++ b/meta-gnome/recipes-extended/gparted/gparted_1.4.0.bb
>> @@ -3,16 +3,15 @@ HOMEPAGE = "http://gparted.org/index.php"
>>   LICENSE = "GPL-2.0-only"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>
>> -inherit features_check autotools pkgconfig python3native gnome-help gtk-icon-cache
>> +inherit autotools pkgconfig python3native gnome-help gtk-icon-cache
>>
>> -REQUIRED_DISTRO_FEATURES = "x11"
>>
>>   SRC_URI = " \
>>       ${SOURCEFORGE_MIRROR}/project/${BPN}/${BPN}/${BPN}-${PV}/${BPN}-${PV}.tar.gz \
>>       file://0001-Install-polkit-action-unconditionally-executable-pke.patch \
>>       file://0001-Do-not-use-NULL-where-boolean-is-expected.patch \
>>   "
>> -SRC_URI[sha256sum] = "5eee2e6d74b15ef96b13b3a2310c868ed2298e03341021e7d12a5a98a1d1e109"
>> +SRC_URI[sha256sum] = "e5293a792e53fdbeba29c4a834113cd9603d0d639330da931a468bf3687887be"
>>
>>   UPSTREAM_CHECK_URI = "https://sourceforge.net/projects/gparted/files/gparted/"
>>   UPSTREAM_CHECK_REGEX = "gparted-(?P<pver>\d+\.(\d+)+(\.\d+)+)"
>> --
>> 2.25.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#96382): https://lists.openembedded.org/g/openembedded-devel/message/96382
>> Mute This Topic: https://lists.openembedded.org/mt/90242693/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>

Patch

diff --git a/meta-gnome/recipes-extended/gparted/gparted_1.3.1.bb b/meta-gnome/recipes-extended/gparted/gparted_1.4.0.bb
similarity index 83%
rename from meta-gnome/recipes-extended/gparted/gparted_1.3.1.bb
rename to meta-gnome/recipes-extended/gparted/gparted_1.4.0.bb
index d1a975930..d1297b5a2 100644
--- a/meta-gnome/recipes-extended/gparted/gparted_1.3.1.bb
+++ b/meta-gnome/recipes-extended/gparted/gparted_1.4.0.bb
@@ -3,16 +3,15 @@  HOMEPAGE = "http://gparted.org/index.php"
 LICENSE = "GPL-2.0-only"
 LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
 
-inherit features_check autotools pkgconfig python3native gnome-help gtk-icon-cache
+inherit autotools pkgconfig python3native gnome-help gtk-icon-cache
 
-REQUIRED_DISTRO_FEATURES = "x11"
 
 SRC_URI = " \
     ${SOURCEFORGE_MIRROR}/project/${BPN}/${BPN}/${BPN}-${PV}/${BPN}-${PV}.tar.gz \
     file://0001-Install-polkit-action-unconditionally-executable-pke.patch \
     file://0001-Do-not-use-NULL-where-boolean-is-expected.patch \
 "
-SRC_URI[sha256sum] = "5eee2e6d74b15ef96b13b3a2310c868ed2298e03341021e7d12a5a98a1d1e109"
+SRC_URI[sha256sum] = "e5293a792e53fdbeba29c4a834113cd9603d0d639330da931a468bf3687887be"
 
 UPSTREAM_CHECK_URI = "https://sourceforge.net/projects/gparted/files/gparted/"
 UPSTREAM_CHECK_REGEX = "gparted-(?P<pver>\d+\.(\d+)+(\.\d+)+)"