[v2,1/2] python3-lz4: use system lz4 library

Message ID 20220321114353.1731727-1-ross.burton@arm.com
State New
Headers show
Series [v2,1/2] python3-lz4: use system lz4 library | expand

Commit Message

Ross Burton March 21, 2022, 11:43 a.m. UTC
Instead of using the copy of lz4 that is embedded in the python3-lz4
source code, use the system lz4 library.

python3-lz4: PKGSIZE changed from 718282 to 165043 (-77%)
python3-lz4: RDEPENDS: added "lz4 (['>= 1.9.3'])"

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Khem Raj March 21, 2022, 3:44 p.m. UTC | #1
v1 was merged. Can you rebase and send the changes on top of 
master/master-next as v3

On 3/21/22 4:43 AM, Ross Burton wrote:
> Instead of using the copy of lz4 that is embedded in the python3-lz4
> source code, use the system lz4 library.
> 
> python3-lz4: PKGSIZE changed from 718282 to 165043 (-77%)
> python3-lz4: RDEPENDS: added "lz4 (['>= 1.9.3'])"
> 
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb b/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb
> index 42f0743bea..75472d327e 100644
> --- a/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb
> +++ b/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb
> @@ -4,12 +4,13 @@ LICENSE = "BSD-3-Clause"
>   LIC_FILES_CHKSUM = "file://LICENSE;md5=6231efa4dd4811e62407314d90a57573"
>   
>   DEPENDS += " \
> +    lz4 \
>       ${PYTHON_PN}-setuptools-scm-native \
>       ${PYTHON_PN}-pkgconfig-native \
>   "
>   
>   SRC_URI[sha256sum] = "57c5dfd3b7dae833b0d2b2c1aafd7f9d0dfcab40683d183d010c67c9fd1beca3"
>   
> -inherit pypi python_setuptools_build_meta
> +inherit pkgconfig pypi python_setuptools_build_meta
>   
>   BBCLASSEXTEND = "native nativesdk"
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#96107): https://lists.openembedded.org/g/openembedded-devel/message/96107
> Mute This Topic: https://lists.openembedded.org/mt/89925656/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Ross Burton March 21, 2022, 4:45 p.m. UTC | #2
This was just a rebase on top of the python rename, so it's all in now.

Thanks
Ross

On Mon, 21 Mar 2022 at 15:45, Khem Raj <raj.khem@gmail.com> wrote:
>
> v1 was merged. Can you rebase and send the changes on top of
> master/master-next as v3
>
> On 3/21/22 4:43 AM, Ross Burton wrote:
> > Instead of using the copy of lz4 that is embedded in the python3-lz4
> > source code, use the system lz4 library.
> >
> > python3-lz4: PKGSIZE changed from 718282 to 165043 (-77%)
> > python3-lz4: RDEPENDS: added "lz4 (['>= 1.9.3'])"
> >
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >   meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb b/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb
> > index 42f0743bea..75472d327e 100644
> > --- a/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb
> > +++ b/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb
> > @@ -4,12 +4,13 @@ LICENSE = "BSD-3-Clause"
> >   LIC_FILES_CHKSUM = "file://LICENSE;md5=6231efa4dd4811e62407314d90a57573"
> >
> >   DEPENDS += " \
> > +    lz4 \
> >       ${PYTHON_PN}-setuptools-scm-native \
> >       ${PYTHON_PN}-pkgconfig-native \
> >   "
> >
> >   SRC_URI[sha256sum] = "57c5dfd3b7dae833b0d2b2c1aafd7f9d0dfcab40683d183d010c67c9fd1beca3"
> >
> > -inherit pypi python_setuptools_build_meta
> > +inherit pkgconfig pypi python_setuptools_build_meta
> >
> >   BBCLASSEXTEND = "native nativesdk"
> >
> >
> >
> >
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#96112): https://lists.openembedded.org/g/openembedded-devel/message/96112
> Mute This Topic: https://lists.openembedded.org/mt/89925656/1676615
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ross@burtonini.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Patch

diff --git a/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb b/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb
index 42f0743bea..75472d327e 100644
--- a/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb
+++ b/meta-python/recipes-devtools/python/python3-lz4_4.0.0.bb
@@ -4,12 +4,13 @@  LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=6231efa4dd4811e62407314d90a57573"
 
 DEPENDS += " \
+    lz4 \
     ${PYTHON_PN}-setuptools-scm-native \
     ${PYTHON_PN}-pkgconfig-native \
 "
 
 SRC_URI[sha256sum] = "57c5dfd3b7dae833b0d2b2c1aafd7f9d0dfcab40683d183d010c67c9fd1beca3"
 
-inherit pypi python_setuptools_build_meta
+inherit pkgconfig pypi python_setuptools_build_meta
 
 BBCLASSEXTEND = "native nativesdk"