[meta-python] python3-smbus: fix wheel build Recipe does not inherit pypi nor would PN be a good guess for the wheel name so set PIP_INSTALL_PACKAGE appropriately. PYPA_WHEEL doesn't respect SETUPTOOLS_SETUP_PATH so set PYPA_WHEEL appropriately.

Message ID 20220228152958.1419-1-matthias@extraklein.de
State New
Headers show
Series [meta-python] python3-smbus: fix wheel build Recipe does not inherit pypi nor would PN be a good guess for the wheel name so set PIP_INSTALL_PACKAGE appropriately. PYPA_WHEEL doesn't respect SETUPTOOLS_SETUP_PATH so set PYPA_WHEEL appropriately. | expand

Commit Message

Matthias Klein Feb. 28, 2022, 3:29 p.m. UTC
Signed-off-by: Matthias Klein <matthias@extraklein.de>
---
 meta-python/recipes-devtools/python/python3-smbus_4.3.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Tim Orling Feb. 28, 2022, 3:42 p.m. UTC | #1
Please shorten the "short log" (the subject line)

On Mon, Feb 28, 2022 at 7:30 AM Matthias Klein <matthias@extraklein.de>
wrote:

> Signed-off-by: Matthias Klein <matthias@extraklein.de>
> ---
>  meta-python/recipes-devtools/python/python3-smbus_4.3.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-python/recipes-devtools/python/python3-smbus_4.3.bb
> b/meta-python/recipes-devtools/python/python3-smbus_4.3.bb
> index ecdff3ada..1a6c99cfc 100644
> --- a/meta-python/recipes-devtools/python/python3-smbus_4.3.bb
> +++ b/meta-python/recipes-devtools/python/python3-smbus_4.3.bb
> @@ -13,4 +13,6 @@ S = "${WORKDIR}/i2c-tools-${PV}"
>
>  inherit setuptools3
>
> +PIP_INSTALL_PACKAGE = "smbus"
> +PYPA_WHEEL = "${S}/py-smbus/dist/smbus-*-*.whl"
>
You could use:
PYPA_WHEEL = "${SETUPTOOOLS_SETUP_PATH}/dist/smbus-*-*.whl"

We could have used
PIP_INSTALL_DIST_PATH = "${SETUPTOOLS_SETUP_PATH}/dist" but there is a
problem with the version here.
The PV of the recipe is for the version of the i2c-tools tarball, but the
actual version of py-smbus as picked up by the uptream wheel tooling is 1.1.

So no matter what, this recipe is a special corner case. As rburton has
said "bitbake is not psychic".

Also, you might consider using python3-smbus2 (
https://layers.openembedded.org/layerindex/recipe/120644/ ) which is not 10
years old without any updates.

 SETUPTOOLS_SETUP_PATH = "${S}/py-smbus"
> --
> 2.30.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#95580):
> https://lists.openembedded.org/g/openembedded-devel/message/95580
> Mute This Topic: https://lists.openembedded.org/mt/89452706/924729
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

Patch

diff --git a/meta-python/recipes-devtools/python/python3-smbus_4.3.bb b/meta-python/recipes-devtools/python/python3-smbus_4.3.bb
index ecdff3ada..1a6c99cfc 100644
--- a/meta-python/recipes-devtools/python/python3-smbus_4.3.bb
+++ b/meta-python/recipes-devtools/python/python3-smbus_4.3.bb
@@ -13,4 +13,6 @@  S = "${WORKDIR}/i2c-tools-${PV}"
 
 inherit setuptools3
 
+PIP_INSTALL_PACKAGE = "smbus"
+PYPA_WHEEL = "${S}/py-smbus/dist/smbus-*-*.whl"
 SETUPTOOLS_SETUP_PATH = "${S}/py-smbus"