diff mbox series

[meta-python] python3-twofish: drop recipe

Message ID 20220226041103.1398748-1-tim.orling@konsulko.com
State New
Headers show
Series [meta-python] python3-twofish: drop recipe | expand

Commit Message

Tim Orling Feb. 26, 2022, 4:11 a.m. UTC 
The code has not been touched since 2013 and does not build with
bdist_wheel. If you depend upon this recipe, please work with upstream
to update the package to PEP-517 packaging.

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
---
 ...ng-return-statements-in-module-stubs.patch | 38 -------------------
 .../python/python3-twofish_0.3.0.bb           | 15 --------
 2 files changed, 53 deletions(-)
 delete mode 100644 meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch
 delete mode 100644 meta-python/recipes-devtools/python/python3-twofish_0.3.0.bb

Comments

Khem Raj Feb. 26, 2022, 8:20 a.m. UTC | #1 
it appears in dependencies of one another recipe in meta-python

ERROR: Nothing RPROVIDES 'python3-twofish' (but
/mnt/b/yoe/master/sources/meta-openembedded/meta-python/recipes-devtools/python/python3-pyjks_20.0.0.bb
RDEPENDS on or otherwise requires it
)

On Fri, Feb 25, 2022 at 8:11 PM Tim Orling <ticotimo@gmail.com> wrote:
>
> The code has not been touched since 2013 and does not build with
> bdist_wheel. If you depend upon this recipe, please work with upstream
> to update the package to PEP-517 packaging.
>
> Signed-off-by: Tim Orling <tim.orling@konsulko.com>
> ---
>  ...ng-return-statements-in-module-stubs.patch | 38 -------------------
>  .../python/python3-twofish_0.3.0.bb           | 15 --------
>  2 files changed, 53 deletions(-)
>  delete mode 100644 meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch
>  delete mode 100644 meta-python/recipes-devtools/python/python3-twofish_0.3.0.bb
>
> diff --git a/meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch b/meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch
> deleted file mode 100644
> index c25b2457e2..0000000000
> --- a/meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch
> +++ /dev/null
> @@ -1,38 +0,0 @@
> -From 5704610f4b3aed5210e9c5b7c05ff8b5b2364c9c Mon Sep 17 00:00:00 2001
> -From: Martin Jansa <Martin.Jansa@gmail.com>
> -Date: Mon, 12 Aug 2019 08:18:21 +0000
> -Subject: [PATCH] Fix missing return statements in module stubs
> -
> -* fixes build with -Werror=return-type
> -  twofish.c: In function 'init_twofish':
> -  twofish.c:45:1: error: control reaches end of non-void function [-Werror=return-type]
> -     45 | PyMODINIT_FUNC init_twofish(void) { }
> -        | ^~~~~~~~~~~~~~
> -  twofish.c: In function 'PyInit__twofish':
> -  twofish.c:46:1: error: control reaches end of non-void function [-Werror=return-type]
> -     46 | PyMODINIT_FUNC PyInit__twofish(void) { }
> -        | ^~~~~~~~~~~~~~
> -  cc1: some warnings being treated as errors
> -
> -Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> -
> -Upstream-Status: Submitted [https://github.com/keybase/python-twofish/pull/6]
> ----
> - twofish.c | 4 ++--
> - 1 file changed, 2 insertions(+), 2 deletions(-)
> -
> -diff --git a/twofish.c b/twofish.c
> -index e324c34..d4487d8 100644
> ---- a/twofish.c
> -+++ b/twofish.c
> -@@ -42,5 +42,5 @@ DL_EXPORT(void) exp_Twofish_decrypt(Twofish_key * xkey, uint8_t c[16], uint8_t p
> - We need a stub init_twofish function so the module will link as a proper module.
> - Do not import _twofish from python; it will not work since _twofish is not a *real* module
> - */
> --PyMODINIT_FUNC init_twofish(void) { }
> --PyMODINIT_FUNC PyInit__twofish(void) { }
> -+PyMODINIT_FUNC init_twofish(void) { return NULL; }
> -+PyMODINIT_FUNC PyInit__twofish(void) { return NULL; }
> ---
> -2.17.1
> -
> diff --git a/meta-python/recipes-devtools/python/python3-twofish_0.3.0.bb b/meta-python/recipes-devtools/python/python3-twofish_0.3.0.bb
> deleted file mode 100644
> index 94fb71090e..0000000000
> --- a/meta-python/recipes-devtools/python/python3-twofish_0.3.0.bb
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -SUMMARY = "Bindings for the Twofish implementation by Niels Ferguson"
> -DESCRIPTION = "Bindings for the Twofish implementation by Niels Ferguson\
> - libtwofish-dev."
> -HOMEPAGE = "http://github.com/keybase/python-twofish"
> -LICENSE = "BSD-3-Clause"
> -LIC_FILES_CHKSUM = "file://LICENSE;md5=33a63abf6d7567b1689d8ce69f00e43b"
> -
> -SRC_URI += "file://0001-Fix-missing-return-statements-in-module-stubs.patch"
> -
> -SRC_URI[md5sum] = "d7d22f16dc4ffa0e3ae2200654033abe"
> -SRC_URI[sha256sum] = "b09d8bb50d33b23ff34cafb1f9209f858f752935c6a5c901efb92a41acb830fa"
> -
> -inherit pypi setuptools3
> -
> -BBCLASSEXTEND = "native nativesdk"
> --
> 2.30.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#95537): https://lists.openembedded.org/g/openembedded-devel/message/95537
> Mute This Topic: https://lists.openembedded.org/mt/89404719/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Tim Orling Feb. 26, 2022, 6:35 p.m. UTC | #2 
On Sat, Feb 26, 2022 at 12:20 AM Khem Raj <raj.khem@gmail.com> wrote:

> it appears in dependencies of one another recipe in meta-python
>
> ERROR: Nothing RPROVIDES 'python3-twofish' (but
>
> /mnt/b/yoe/master/sources/meta-openembedded/meta-python/recipes-devtools/python/
> python3-pyjks_20.0.0.bb
> RDEPENDS on or otherwise requires it


ok. Perhaps we can find a way to modify upstream to be able to build a
wheel.
My first guess is to change
"from distutils.core import setup, Extension"
To either use setuptools or the vendored setuptoools._distutils

This will probably turn into the next super pattern to build these old code
bases.


>
On Fri, Feb 25, 2022 at 8:11 PM Tim Orling <ticotimo@gmail.com> wrote:
> >
> > The code has not been touched since 2013 and does not build with
> > bdist_wheel. If you depend upon this recipe, please work with upstream
> > to update the package to PEP-517 packaging.
> >
> > Signed-off-by: Tim Orling <tim.orling@konsulko.com>
> > ---
> >  ...ng-return-statements-in-module-stubs.patch | 38 -------------------
> >  .../python/python3-twofish_0.3.0.bb           | 15 --------
> >  2 files changed, 53 deletions(-)
> >  delete mode 100644
> meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch
> >  delete mode 100644 meta-python/recipes-devtools/python/
> python3-twofish_0.3.0.bb
> >
> > diff --git
> a/meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch
> b/meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch
> > deleted file mode 100644
> > index c25b2457e2..0000000000
> > ---
> a/meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch
> > +++ /dev/null
> > @@ -1,38 +0,0 @@
> > -From 5704610f4b3aed5210e9c5b7c05ff8b5b2364c9c Mon Sep 17 00:00:00 2001
> > -From: Martin Jansa <Martin.Jansa@gmail.com>
> > -Date: Mon, 12 Aug 2019 08:18:21 +0000
> > -Subject: [PATCH] Fix missing return statements in module stubs
> > -
> > -* fixes build with -Werror=return-type
> > -  twofish.c: In function 'init_twofish':
> > -  twofish.c:45:1: error: control reaches end of non-void function
> [-Werror=return-type]
> > -     45 | PyMODINIT_FUNC init_twofish(void) { }
> > -        | ^~~~~~~~~~~~~~
> > -  twofish.c: In function 'PyInit__twofish':
> > -  twofish.c:46:1: error: control reaches end of non-void function
> [-Werror=return-type]
> > -     46 | PyMODINIT_FUNC PyInit__twofish(void) { }
> > -        | ^~~~~~~~~~~~~~
> > -  cc1: some warnings being treated as errors
> > -
> > -Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > -
> > -Upstream-Status: Submitted [
> https://github.com/keybase/python-twofish/pull/6]
> > ----
> > - twofish.c | 4 ++--
> > - 1 file changed, 2 insertions(+), 2 deletions(-)
> > -
> > -diff --git a/twofish.c b/twofish.c
> > -index e324c34..d4487d8 100644
> > ---- a/twofish.c
> > -+++ b/twofish.c
> > -@@ -42,5 +42,5 @@ DL_EXPORT(void) exp_Twofish_decrypt(Twofish_key *
> xkey, uint8_t c[16], uint8_t p
> > - We need a stub init_twofish function so the module will link as a
> proper module.
> > - Do not import _twofish from python; it will not work since _twofish is
> not a *real* module
> > - */
> > --PyMODINIT_FUNC init_twofish(void) { }
> > --PyMODINIT_FUNC PyInit__twofish(void) { }
> > -+PyMODINIT_FUNC init_twofish(void) { return NULL; }
> > -+PyMODINIT_FUNC PyInit__twofish(void) { return NULL; }
> > ---
> > -2.17.1
> > -
> > diff --git a/meta-python/recipes-devtools/python/
> python3-twofish_0.3.0.bb b/meta-python/recipes-devtools/python/
> python3-twofish_0.3.0.bb
> > deleted file mode 100644
> > index 94fb71090e..0000000000
> > --- a/meta-python/recipes-devtools/python/python3-twofish_0.3.0.bb
> > +++ /dev/null
> > @@ -1,15 +0,0 @@
> > -SUMMARY = "Bindings for the Twofish implementation by Niels Ferguson"
> > -DESCRIPTION = "Bindings for the Twofish implementation by Niels
> Ferguson\
> > - libtwofish-dev."
> > -HOMEPAGE = "http://github.com/keybase/python-twofish"
> > -LICENSE = "BSD-3-Clause"
> > -LIC_FILES_CHKSUM = "file://LICENSE;md5=33a63abf6d7567b1689d8ce69f00e43b"
> > -
> > -SRC_URI +=
> "file://0001-Fix-missing-return-statements-in-module-stubs.patch"
> > -
> > -SRC_URI[md5sum] = "d7d22f16dc4ffa0e3ae2200654033abe"
> > -SRC_URI[sha256sum] =
> "b09d8bb50d33b23ff34cafb1f9209f858f752935c6a5c901efb92a41acb830fa"
> > -
> > -inherit pypi setuptools3
> > -
> > -BBCLASSEXTEND = "native nativesdk"
> > --
> > 2.30.2
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#95537):
> https://lists.openembedded.org/g/openembedded-devel/message/95537
> > Mute This Topic: https://lists.openembedded.org/mt/89404719/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
diff mbox series

Patch

diff --git a/meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch b/meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch
deleted file mode 100644
index c25b2457e2..0000000000
--- a/meta-python/recipes-devtools/python/python3-twofish/0001-Fix-missing-return-statements-in-module-stubs.patch
+++ /dev/null
@@ -1,38 +0,0 @@ 
-From 5704610f4b3aed5210e9c5b7c05ff8b5b2364c9c Mon Sep 17 00:00:00 2001
-From: Martin Jansa <Martin.Jansa@gmail.com>
-Date: Mon, 12 Aug 2019 08:18:21 +0000
-Subject: [PATCH] Fix missing return statements in module stubs
-
-* fixes build with -Werror=return-type
-  twofish.c: In function 'init_twofish':
-  twofish.c:45:1: error: control reaches end of non-void function [-Werror=return-type]
-     45 | PyMODINIT_FUNC init_twofish(void) { }
-        | ^~~~~~~~~~~~~~
-  twofish.c: In function 'PyInit__twofish':
-  twofish.c:46:1: error: control reaches end of non-void function [-Werror=return-type]
-     46 | PyMODINIT_FUNC PyInit__twofish(void) { }
-        | ^~~~~~~~~~~~~~
-  cc1: some warnings being treated as errors
-
-Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
-
-Upstream-Status: Submitted [https://github.com/keybase/python-twofish/pull/6]
----
- twofish.c | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/twofish.c b/twofish.c
-index e324c34..d4487d8 100644
---- a/twofish.c
-+++ b/twofish.c
-@@ -42,5 +42,5 @@ DL_EXPORT(void) exp_Twofish_decrypt(Twofish_key * xkey, uint8_t c[16], uint8_t p
- We need a stub init_twofish function so the module will link as a proper module.
- Do not import _twofish from python; it will not work since _twofish is not a *real* module
- */
--PyMODINIT_FUNC init_twofish(void) { }
--PyMODINIT_FUNC PyInit__twofish(void) { }
-+PyMODINIT_FUNC init_twofish(void) { return NULL; }
-+PyMODINIT_FUNC PyInit__twofish(void) { return NULL; }
--- 
-2.17.1
-
diff --git a/meta-python/recipes-devtools/python/python3-twofish_0.3.0.bb b/meta-python/recipes-devtools/python/python3-twofish_0.3.0.bb
deleted file mode 100644
index 94fb71090e..0000000000
--- a/meta-python/recipes-devtools/python/python3-twofish_0.3.0.bb
+++ /dev/null
@@ -1,15 +0,0 @@ 
-SUMMARY = "Bindings for the Twofish implementation by Niels Ferguson"
-DESCRIPTION = "Bindings for the Twofish implementation by Niels Ferguson\
- libtwofish-dev."
-HOMEPAGE = "http://github.com/keybase/python-twofish"
-LICENSE = "BSD-3-Clause"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=33a63abf6d7567b1689d8ce69f00e43b"
-
-SRC_URI += "file://0001-Fix-missing-return-statements-in-module-stubs.patch"
-
-SRC_URI[md5sum] = "d7d22f16dc4ffa0e3ae2200654033abe"
-SRC_URI[sha256sum] = "b09d8bb50d33b23ff34cafb1f9209f858f752935c6a5c901efb92a41acb830fa"
-
-inherit pypi setuptools3
-
-BBCLASSEXTEND = "native nativesdk"