[meta-xfce] libxfce4util: inherit vala

Message ID 20220221182012.2513597-1-f_l_k@t-online.de
State New
Headers show
Series [meta-xfce] libxfce4util: inherit vala | expand

Commit Message

Markus Volk Feb. 21, 2022, 6:20 p.m. UTC
This fixes do_configure error:

| libxfce4util/Makefile.am:159: error: ENABLE_VAPIGEN does not appear in AM_CONDITIONAL

Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khem Raj Feb. 22, 2022, 2:10 a.m. UTC | #1
I am seeing libxfce4ui is failing in install task I wonder if it is
related these changes

see
https://errors.yoctoproject.org/Errors/Details/633079/

On Mon, Feb 21, 2022 at 10:20 AM Markus Volk <f_l_k@t-online.de> wrote:
>
> This fixes do_configure error:
>
> | libxfce4util/Makefile.am:159: error: ENABLE_VAPIGEN does not appear in AM_CONDITIONAL
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb b/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
> index 1a0b7183e..9462b28ac 100644
> --- a/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
> +++ b/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
> @@ -4,6 +4,6 @@ LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=252890d9eee26aab7b432e8b8a616475"
>  DEPENDS = "intltool-native xfce4-dev-tools-native glib-2.0"
>
> -inherit xfce gtk-doc gobject-introspection
> +inherit xfce gtk-doc gobject-introspection vala
>
>  SRC_URI[sha256sum] = "60598d745d1fc81ff5ad3cecc3a8d1b85990dd22023e7743f55abd87d8b55b83"
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#95423): https://lists.openembedded.org/g/openembedded-devel/message/95423
> Mute This Topic: https://lists.openembedded.org/mt/89300196/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Markus Volk Feb. 22, 2022, 5:57 a.m. UTC | #2
I dont think this is related. Its more like after updating poky to 
current master some of the xfce4 recipes try to build vapi, not caring 
that its not explicitly enabled. That was in fact the reason for adding 
vala to xfconf and libxfce4util. Both recipes started to fail after poky 
update.

libxfce4ui and xfce4-panel are failing too, but it doesnt help to 
inherit vala here. Both of them will then fail with different error 
messages. What helps for me is to to disable vala like this

EXTRA_OECONF += "--disable-vala"

I guess it would be ok to just dont build vapi for libxfceui and 
xfce4-panel because even upstream builds it like this:

https://gitlab.xfce.org/xfce/libxfce4ui/-/blob/master/Makefile.am#L46

I'll send patches if you agree on this

Am 22.02.22 um 03:10 schrieb Khem Raj:
> I am seeing libxfce4ui is failing in install task I wonder if it is
> related these changes
>
> see
> https://errors.yoctoproject.org/Errors/Details/633079/
>
> On Mon, Feb 21, 2022 at 10:20 AM Markus Volk <f_l_k@t-online.de> wrote:
>> This fixes do_configure error:
>>
>> | libxfce4util/Makefile.am:159: error: ENABLE_VAPIGEN does not appear in AM_CONDITIONAL
>>
>> Signed-off-by: Markus Volk <f_l_k@t-online.de>
>> ---
>>   meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb b/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
>> index 1a0b7183e..9462b28ac 100644
>> --- a/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
>> +++ b/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
>> @@ -4,6 +4,6 @@ LICENSE = "GPLv2"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=252890d9eee26aab7b432e8b8a616475"
>>   DEPENDS = "intltool-native xfce4-dev-tools-native glib-2.0"
>>
>> -inherit xfce gtk-doc gobject-introspection
>> +inherit xfce gtk-doc gobject-introspection vala
>>
>>   SRC_URI[sha256sum] = "60598d745d1fc81ff5ad3cecc3a8d1b85990dd22023e7743f55abd87d8b55b83"
>> --
>> 2.25.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#95423): https://lists.openembedded.org/g/openembedded-devel/message/95423
>> Mute This Topic: https://lists.openembedded.org/mt/89300196/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
Khem Raj Feb. 22, 2022, 6:24 a.m. UTC | #3
On Mon, Feb 21, 2022 at 9:57 PM Markus Volk <f_l_k@t-online.de> wrote:
>
> I dont think this is related. Its more like after updating poky to
> current master some of the xfce4 recipes try to build vapi, not caring
> that its not explicitly enabled. That was in fact the reason for adding
> vala to xfconf and libxfce4util. Both recipes started to fail after poky
> update.
>
> libxfce4ui and xfce4-panel are failing too, but it doesnt help to
> inherit vala here. Both of them will then fail with different error
> messages. What helps for me is to to disable vala like this
>
> EXTRA_OECONF += "--disable-vala"

Yeah I briefly looked at it and seems that gir and vapi are being mixed somehow

>
> I guess it would be ok to just dont build vapi for libxfceui and
> xfce4-panel because even upstream builds it like this:
>
> https://gitlab.xfce.org/xfce/libxfce4ui/-/blob/master/Makefile.am#L46
>
> I'll send patches if you agree on this

yeah sounds good

>
> Am 22.02.22 um 03:10 schrieb Khem Raj:
> > I am seeing libxfce4ui is failing in install task I wonder if it is
> > related these changes
> >
> > see
> > https://errors.yoctoproject.org/Errors/Details/633079/
> >
> > On Mon, Feb 21, 2022 at 10:20 AM Markus Volk <f_l_k@t-online.de> wrote:
> >> This fixes do_configure error:
> >>
> >> | libxfce4util/Makefile.am:159: error: ENABLE_VAPIGEN does not appear in AM_CONDITIONAL
> >>
> >> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> >> ---
> >>   meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb b/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
> >> index 1a0b7183e..9462b28ac 100644
> >> --- a/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
> >> +++ b/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
> >> @@ -4,6 +4,6 @@ LICENSE = "GPLv2"
> >>   LIC_FILES_CHKSUM = "file://COPYING;md5=252890d9eee26aab7b432e8b8a616475"
> >>   DEPENDS = "intltool-native xfce4-dev-tools-native glib-2.0"
> >>
> >> -inherit xfce gtk-doc gobject-introspection
> >> +inherit xfce gtk-doc gobject-introspection vala
> >>
> >>   SRC_URI[sha256sum] = "60598d745d1fc81ff5ad3cecc3a8d1b85990dd22023e7743f55abd87d8b55b83"
> >> --
> >> 2.25.1
> >>
> >>
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >> Links: You receive all messages sent to this group.
> >> View/Reply Online (#95423): https://lists.openembedded.org/g/openembedded-devel/message/95423
> >> Mute This Topic: https://lists.openembedded.org/mt/89300196/1997914
> >> Group Owner: openembedded-devel+owner@lists.openembedded.org
> >> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >>

Patch

diff --git a/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb b/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
index 1a0b7183e..9462b28ac 100644
--- a/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
+++ b/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb
@@ -4,6 +4,6 @@  LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=252890d9eee26aab7b432e8b8a616475"
 DEPENDS = "intltool-native xfce4-dev-tools-native glib-2.0"
 
-inherit xfce gtk-doc gobject-introspection
+inherit xfce gtk-doc gobject-introspection vala
 
 SRC_URI[sha256sum] = "60598d745d1fc81ff5ad3cecc3a8d1b85990dd22023e7743f55abd87d8b55b83"