diff mbox series

[meta-oe,09/40] libdevmapper: upgrade 2.03.22 -> 2.03.24

Message ID 1716860901-863-9-git-send-email-wangmy@fujitsu.com
State Accepted
Headers show
Series [meta-networking,01/40] arno-iptables-firewall: upgrade 2.1.1 -> 2.1.2 | expand

Commit Message

Mingyu Wang (Fujitsu) May 28, 2024, 1:47 a.m. UTC
From: Wang Mingyu <wangmy@fujitsu.com>

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
---
 .../lvm2/{libdevmapper_2.03.22.bb => libdevmapper_2.03.24.bb}   | 0
 meta-oe/recipes-support/lvm2/lvm2.inc                           | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta-oe/recipes-support/lvm2/{libdevmapper_2.03.22.bb => libdevmapper_2.03.24.bb} (100%)

Comments

Peter Kjellerstedt May 28, 2024, 2:53 a.m. UTC | #1
> -----Original Message-----
> From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of wangmy via
> lists.openembedded.org
> Sent: den 28 maj 2024 03:48
> To: openembedded-devel@lists.openembedded.org
> Cc: Wang Mingyu <wangmy@fujitsu.com>
> Subject: [oe] [meta-oe] [PATCH 09/40] libdevmapper: upgrade 2.03.22 -> 2.03.24
> 
> From: Wang Mingyu <wangmy@fujitsu.com>
> 
> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> ---
>  .../lvm2/{libdevmapper_2.03.22.bb => libdevmapper_2.03.24.bb}   | 0
>  meta-oe/recipes-support/lvm2/lvm2.inc                           | 2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename meta-oe/recipes-support/lvm2/{libdevmapper_2.03.22.bb => libdevmapper_2.03.24.bb} (100%)
> 
> diff --git a/meta-oe/recipes-support/lvm2/libdevmapper_2.03.22.bb b/meta-oe/recipes-support/lvm2/libdevmapper_2.03.24.bb
> similarity index 100%
> rename from meta-oe/recipes-support/lvm2/libdevmapper_2.03.22.bb
> rename to meta-oe/recipes-support/lvm2/libdevmapper_2.03.24.bb
> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
> index d95366f97..0351eb6b3 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2.inc
> +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
> @@ -19,7 +19,7 @@ SRC_URI = "git://sourceware.org/git/lvm2.git;branch=main \
>             file://0001-include-libgen.h-for-basename.patch \
>             "
> 
> -SRCREV = "016e469caf856f1eb8dde39df0d1aa2e74225aed"
> +SRCREV = "90ec2cd92f6367c431dd8dae55d0cbe7e196734f"
>  S = "${WORKDIR}/git"
> 
>  UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\_\d+)+)"
> --
> 2.34.1

lvm2.inc is used by both lvm2 and libdevmapper so both recipes must be updated 
at the same time.

//Peter
Khem Raj May 29, 2024, 3:50 p.m. UTC | #2
On Mon, May 27, 2024 at 7:53 PM Peter Kjellerstedt via
lists.openembedded.org
<peter.kjellerstedt=axis.com@lists.openembedded.org> wrote:
>
> > -----Original Message-----
> > From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of wangmy via
> > lists.openembedded.org
> > Sent: den 28 maj 2024 03:48
> > To: openembedded-devel@lists.openembedded.org
> > Cc: Wang Mingyu <wangmy@fujitsu.com>
> > Subject: [oe] [meta-oe] [PATCH 09/40] libdevmapper: upgrade 2.03.22 -> 2.03.24
> >
> > From: Wang Mingyu <wangmy@fujitsu.com>
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> >  .../lvm2/{libdevmapper_2.03.22.bb => libdevmapper_2.03.24.bb}   | 0
> >  meta-oe/recipes-support/lvm2/lvm2.inc                           | 2 +-
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >  rename meta-oe/recipes-support/lvm2/{libdevmapper_2.03.22.bb => libdevmapper_2.03.24.bb} (100%)
> >
> > diff --git a/meta-oe/recipes-support/lvm2/libdevmapper_2.03.22.bb b/meta-oe/recipes-support/lvm2/libdevmapper_2.03.24.bb
> > similarity index 100%
> > rename from meta-oe/recipes-support/lvm2/libdevmapper_2.03.22.bb
> > rename to meta-oe/recipes-support/lvm2/libdevmapper_2.03.24.bb
> > diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
> > index d95366f97..0351eb6b3 100644
> > --- a/meta-oe/recipes-support/lvm2/lvm2.inc
> > +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
> > @@ -19,7 +19,7 @@ SRC_URI = "git://sourceware.org/git/lvm2.git;branch=main \
> >             file://0001-include-libgen.h-for-basename.patch \
> >             "
> >
> > -SRCREV = "016e469caf856f1eb8dde39df0d1aa2e74225aed"
> > +SRCREV = "90ec2cd92f6367c431dd8dae55d0cbe7e196734f"
> >  S = "${WORKDIR}/git"
> >
> >  UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\_\d+)+)"
> > --
> > 2.34.1
>
> lvm2.inc is used by both lvm2 and libdevmapper so both recipes must be updated
> at the same time.

Markus has provided a followup. Although it renames the recipes to
drop PV which is less than ideal
but perhaps its better than what we have today
>
> //Peter
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#110576): https://lists.openembedded.org/g/openembedded-devel/message/110576
> Mute This Topic: https://lists.openembedded.org/mt/106342039/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Peter Kjellerstedt May 29, 2024, 5:55 p.m. UTC | #3
> -----Original Message-----
> From: Khem Raj <raj.khem@gmail.com>
> Sent: den 29 maj 2024 17:50
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: wangmy@fujitsu.com; openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe] [PATCH 09/40] libdevmapper: upgrade 2.03.22 -> 2.03.24
> 
> On Mon, May 27, 2024 at 7:53 PM Peter Kjellerstedt via lists.openembedded.org <peter.kjellerstedt=axis.com@lists.openembedded.org> wrote:
> >
> > > -----Original Message-----
> > > From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of wangmy via
> > > lists.openembedded.org
> > > Sent: den 28 maj 2024 03:48
> > > To: openembedded-devel@lists.openembedded.org
> > > Cc: Wang Mingyu <wangmy@fujitsu.com>
> > > Subject: [oe] [meta-oe] [PATCH 09/40] libdevmapper: upgrade 2.03.22 -> 2.03.24
> > >
> > > From: Wang Mingyu <wangmy@fujitsu.com>
> > >
> > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > > ---
> > >  .../lvm2/{libdevmapper_2.03.22.bb => libdevmapper_2.03.24.bb}   | 0
> > >  meta-oe/recipes-support/lvm2/lvm2.inc                           | 2 +-
> > >  2 files changed, 1 insertion(+), 1 deletion(-)
> > >  rename meta-oe/recipes-support/lvm2/{libdevmapper_2.03.22.bb => libdevmapper_2.03.24.bb} (100%)
> > >
> > > diff --git a/meta-oe/recipes-support/lvm2/libdevmapper_2.03.22.bb b/meta-oe/recipes-support/lvm2/libdevmapper_2.03.24.bb
> > > similarity index 100%
> > > rename from meta-oe/recipes-support/lvm2/libdevmapper_2.03.22.bb
> > > rename to meta-oe/recipes-support/lvm2/libdevmapper_2.03.24.bb
> > > diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
> > > index d95366f97..0351eb6b3 100644
> > > --- a/meta-oe/recipes-support/lvm2/lvm2.inc
> > > +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
> > > @@ -19,7 +19,7 @@ SRC_URI = "git://sourceware.org/git/lvm2.git;branch=main \
> > >             file://0001-include-libgen.h-for-basename.patch \
> > >             "
> > >
> > > -SRCREV = "016e469caf856f1eb8dde39df0d1aa2e74225aed"
> > > +SRCREV = "90ec2cd92f6367c431dd8dae55d0cbe7e196734f"
> > >  S = "${WORKDIR}/git"
> > >
> > >  UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\_\d+)+)"
> > > --
> > > 2.34.1
> >
> > lvm2.inc is used by both lvm2 and libdevmapper so both recipes must be 
> > updated at the same time.
> 
> Markus has provided a followup. Although it renames the recipes to
> drop PV which is less than ideal
> but perhaps its better than what we have today
> >
> > //Peter

While I use versioned bbappends a lot myself (which is not possible with 
recipes without a version in the file name), I do see the maintenance 
benefit of having both PV and SRCREV specified in the .inc file.

//Peter
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/lvm2/libdevmapper_2.03.22.bb b/meta-oe/recipes-support/lvm2/libdevmapper_2.03.24.bb
similarity index 100%
rename from meta-oe/recipes-support/lvm2/libdevmapper_2.03.22.bb
rename to meta-oe/recipes-support/lvm2/libdevmapper_2.03.24.bb
diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
index d95366f97..0351eb6b3 100644
--- a/meta-oe/recipes-support/lvm2/lvm2.inc
+++ b/meta-oe/recipes-support/lvm2/lvm2.inc
@@ -19,7 +19,7 @@  SRC_URI = "git://sourceware.org/git/lvm2.git;branch=main \
            file://0001-include-libgen.h-for-basename.patch \
            "
 
-SRCREV = "016e469caf856f1eb8dde39df0d1aa2e74225aed"
+SRCREV = "90ec2cd92f6367c431dd8dae55d0cbe7e196734f"
 S = "${WORKDIR}/git"
 
 UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\_\d+)+)"