diff mbox series

[meta-oe] flatbuffers: upgrade 22.12.06 -> 23.1.4

Message ID 1673329158-5189-2-git-send-email-wangmy@fujitsu.com
State Under Review
Headers show
Series [meta-oe] flatbuffers: upgrade 22.12.06 -> 23.1.4 | expand

Commit Message

Mingyu Wang (Fujitsu) Jan. 10, 2023, 5:39 a.m. UTC
From: Wang Mingyu <wangmy@fujitsu.com>

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
---
 meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Khem Raj Jan. 10, 2023, 6:24 a.m. UTC | #1
On Mon, Jan 9, 2023 at 9:39 PM wangmy <wangmy@fujitsu.com> wrote:
>
> From: Wang Mingyu <wangmy@fujitsu.com>
>
> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> ---
>  meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc b/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> index c87a449f0..a85c74c12 100644
> --- a/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> +++ b/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> @@ -1,3 +1,3 @@
> -PV = "22.12.06"
> -SRCREV = "acf39ff056df8c9e5bfa32cf6f7b5e6b87a90544"
> +PV = "23.1.4"

here also its good to rename the recipes to reflect PV.

> +SRCREV = "af9ceabeef1a10c1004e2741f8c0c090ca59e5af"
>  SRC_URI = "git://github.com/google/flatbuffers.git;branch=master;protocol=https"
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#100500): https://lists.openembedded.org/g/openembedded-devel/message/100500
> Mute This Topic: https://lists.openembedded.org/mt/96171758/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Mingyu Wang (Fujitsu) Jan. 10, 2023, 8:07 a.m. UTC | #2
In September 2022, the suffix of bb file was removed from the following patch:

[oe] [oe-core][PATCH] flatbuffers: upgrade 2.0.6 -> 2.0.8

The purpose of the patch is to update flatbuffers and python3-flatbuffers together. 

Please confirm whether it is necessary to change back.
  --
Best Regards
---------------------------------------------------
Wang Mingyu
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wangmy@fujitsu.com
http://www.fujitsu.com/cn/fnst/

> -----Original Message-----
> From: openembedded-devel@lists.openembedded.org
> <openembedded-devel@lists.openembedded.org> On Behalf Of Khem Raj
> Sent: Tuesday, January 10, 2023 2:24 PM
> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe] [PATCH] flatbuffers: upgrade 22.12.06 -> 23.1.4
> 
> On Mon, Jan 9, 2023 at 9:39 PM wangmy <wangmy@fujitsu.com> wrote:
> >
> > From: Wang Mingyu <wangmy@fujitsu.com>
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> >  meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> b/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> > index c87a449f0..a85c74c12 100644
> > --- a/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> > +++ b/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> > @@ -1,3 +1,3 @@
> > -PV = "22.12.06"
> > -SRCREV = "acf39ff056df8c9e5bfa32cf6f7b5e6b87a90544"
> > +PV = "23.1.4"
> 
> here also its good to rename the recipes to reflect PV.
> 
> > +SRCREV = "af9ceabeef1a10c1004e2741f8c0c090ca59e5af"
> >  SRC_URI =
> "git://github.com/google/flatbuffers.git;branch=master;protocol=https"
> > --
> > 2.25.1
> >
> >
> >
> >
Khem Raj Jan. 10, 2023, 4:50 p.m. UTC | #3
On Tue, Jan 10, 2023 at 12:07 AM wangmy@fujitsu.com <wangmy@fujitsu.com> wrote:
>
> In September 2022, the suffix of bb file was removed from the following patch:
>
> [oe] [oe-core][PATCH] flatbuffers: upgrade 2.0.6 -> 2.0.8
>
> The purpose of the patch is to update flatbuffers and python3-flatbuffers together.
>
> Please confirm whether it is necessary to change back.

I think version recipes are easy to bbappend. For now lets keep it as it is.

>   --
> Best Regards
> ---------------------------------------------------
> Wang Mingyu
> Development Dept.I
> Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
> TEL: +86+25-86630566-8568
> COINS: 79988548
> FAX: +86+25-83317685
> MAIL: wangmy@fujitsu.com
> http://www.fujitsu.com/cn/fnst/
>
> > -----Original Message-----
> > From: openembedded-devel@lists.openembedded.org
> > <openembedded-devel@lists.openembedded.org> On Behalf Of Khem Raj
> > Sent: Tuesday, January 10, 2023 2:24 PM
> > To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>
> > Cc: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [meta-oe] [PATCH] flatbuffers: upgrade 22.12.06 -> 23.1.4
> >
> > On Mon, Jan 9, 2023 at 9:39 PM wangmy <wangmy@fujitsu.com> wrote:
> > >
> > > From: Wang Mingyu <wangmy@fujitsu.com>
> > >
> > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > > ---
> > >  meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> > b/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> > > index c87a449f0..a85c74c12 100644
> > > --- a/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> > > +++ b/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
> > > @@ -1,3 +1,3 @@
> > > -PV = "22.12.06"
> > > -SRCREV = "acf39ff056df8c9e5bfa32cf6f7b5e6b87a90544"
> > > +PV = "23.1.4"
> >
> > here also its good to rename the recipes to reflect PV.
> >
> > > +SRCREV = "af9ceabeef1a10c1004e2741f8c0c090ca59e5af"
> > >  SRC_URI =
> > "git://github.com/google/flatbuffers.git;branch=master;protocol=https"
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >
diff mbox series

Patch

diff --git a/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc b/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
index c87a449f0..a85c74c12 100644
--- a/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
+++ b/meta-oe/recipes-devtools/flatbuffers/flatbuffers.inc
@@ -1,3 +1,3 @@ 
-PV = "22.12.06"
-SRCREV = "acf39ff056df8c9e5bfa32cf6f7b5e6b87a90544"
+PV = "23.1.4"
+SRCREV = "af9ceabeef1a10c1004e2741f8c0c090ca59e5af"
 SRC_URI = "git://github.com/google/flatbuffers.git;branch=master;protocol=https"