[meta-networking] lldpd: upgrade 1.0.15 -> 1.0.16

From: Wang Mingyu <wangmy@fujitsu.com>

Fix:
======
    Do not use 00:00:00:00:00:00 as chassis ID.
    Do not busy loop when an interface with a neighbor disappears.

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
---
 .../recipes-daemons/lldpd/{lldpd_1.0.15.bb => lldpd_1.0.16.bb}  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta-networking/recipes-daemons/lldpd/{lldpd_1.0.15.bb => lldpd_1.0.16.bb} (96%)

> -----Original Message-----
> From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of wangmy
> Sent: den 28 november 2022 07:10
> To: openembedded-devel@lists.openembedded.org
> Cc: Wang Mingyu <wangmy@fujitsu.com>
> Subject: [oe] [meta-networking] [PATCH] lldpd: upgrade 1.0.15 -> 1.0.16
> 
> From: Wang Mingyu <wangmy@fujitsu.com>
> 
> Fix:
> ======
>     Do not use 00:00:00:00:00:00 as chassis ID.
>     Do not busy loop when an interface with a neighbor disappears.
> 
> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> ---
>  .../recipes-daemons/lldpd/{lldpd_1.0.15.bb => lldpd_1.0.16.bb}  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename meta-networking/recipes-daemons/lldpd/{lldpd_1.0.15.bb => lldpd_1.0.16.bb} (96%)
> 
> diff --git a/meta-networking/recipes-daemons/lldpd/lldpd_1.0.15.bb b/meta-networking/recipes-daemons/lldpd/lldpd_1.0.16.bb
> similarity index 96%
> rename from meta-networking/recipes-daemons/lldpd/lldpd_1.0.15.bb
> rename to meta-networking/recipes-daemons/lldpd/lldpd_1.0.16.bb
> index c7237d74b..45425561f 100644
> --- a/meta-networking/recipes-daemons/lldpd/lldpd_1.0.15.bb
> +++ b/meta-networking/recipes-daemons/lldpd/lldpd_1.0.16.bb
> @@ -12,7 +12,7 @@ SRC_URI = "\
>      file://run-ptest \
>      "
> 
> -SRC_URI[sha256sum] = "f7fe3a130be98a19c491479ef60f36b8ee41a9e6bc4d7f2c41033f63956a3126"
> +SRC_URI[sha256sum] = "e3b391650c7ba67cea2fe84d67fdb4d7fc8aa1ec5cf86eb8bb984711df8465a9"

This was for some reason integrated without the checksum update. 
However, a subsequent commit changed the SRC_URI (from media.luffy.cx 
to github.com), which caused a change to the checksum as I now get:

ERROR: lldpd-1.0.16-r0 do_fetch: Fetcher failure for URL: 
'https://github.com/lldpd/lldpd/releases/download/1.0.16/lldpd-1.0.16.tar.gz'. 
Checksum mismatch! File: '.../downloads/lldpd-1.0.16.tar.gz.tmp' has sha256 
checksum '7753c6e31e938923185f4e10c4ab328929729e22ee4a9687d08881fb82c092ee' 
when 'f7fe3a130be98a19c491479ef60f36b8ee41a9e6bc4d7f2c41033f63956a3126' was 
expected

I.e., the checksums for the 1.0.16 tarball on media.luffy.cx does not match 
the checksum of the same tar ball on github.com. And comparing the contents 
of the two identically named tarballs reveals that the one from 
media.luffy.cx has been generated with newer version of autoconf and 
automake.

I also wonder if the change of SRC_URI, which was triggered by the AB not 
being able to fetch the tarball, was really due to the checksum not having 
been updated when the recipe version was stepped.

Based on the above, my recommendation is to revert commit e154914718 (i.e., 
the SRC_URI update), and then update the checksum as per the originally 
supplied patch from Wang Mingyu:

SRC_URI[sha256sum] = "e3b391650c7ba67cea2fe84d67fdb4d7fc8aa1ec5cf86eb8bb984711df8465a9"

I will send two patches to do this.

> 
>  inherit autotools update-rc.d useradd systemd pkgconfig bash-completion github-releases ptest
> 
> --
> 2.25.1

//Peter

On Mon, Nov 28, 2022 at 8:01 PM Peter Kjellerstedt
<peter.kjellerstedt@axis.com> wrote:
>
> > -----Original Message-----
> > From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of wangmy
> > Sent: den 28 november 2022 07:10
> > To: openembedded-devel@lists.openembedded.org
> > Cc: Wang Mingyu <wangmy@fujitsu.com>
> > Subject: [oe] [meta-networking] [PATCH] lldpd: upgrade 1.0.15 -> 1.0.16
> >
> > From: Wang Mingyu <wangmy@fujitsu.com>
> >
> > Fix:
> > ======
> >     Do not use 00:00:00:00:00:00 as chassis ID.
> >     Do not busy loop when an interface with a neighbor disappears.
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> >  .../recipes-daemons/lldpd/{lldpd_1.0.15.bb => lldpd_1.0.16.bb}  | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >  rename meta-networking/recipes-daemons/lldpd/{lldpd_1.0.15.bb => lldpd_1.0.16.bb} (96%)
> >
> > diff --git a/meta-networking/recipes-daemons/lldpd/lldpd_1.0.15.bb b/meta-networking/recipes-daemons/lldpd/lldpd_1.0.16.bb
> > similarity index 96%
> > rename from meta-networking/recipes-daemons/lldpd/lldpd_1.0.15.bb
> > rename to meta-networking/recipes-daemons/lldpd/lldpd_1.0.16.bb
> > index c7237d74b..45425561f 100644
> > --- a/meta-networking/recipes-daemons/lldpd/lldpd_1.0.15.bb
> > +++ b/meta-networking/recipes-daemons/lldpd/lldpd_1.0.16.bb
> > @@ -12,7 +12,7 @@ SRC_URI = "\
> >      file://run-ptest \
> >      "
> >
> > -SRC_URI[sha256sum] = "f7fe3a130be98a19c491479ef60f36b8ee41a9e6bc4d7f2c41033f63956a3126"
> > +SRC_URI[sha256sum] = "e3b391650c7ba67cea2fe84d67fdb4d7fc8aa1ec5cf86eb8bb984711df8465a9"
>
> This was for some reason integrated without the checksum update.
> However, a subsequent commit changed the SRC_URI (from media.luffy.cx
> to github.com), which caused a change to the checksum as I now get:
>
> ERROR: lldpd-1.0.16-r0 do_fetch: Fetcher failure for URL:
> 'https://github.com/lldpd/lldpd/releases/download/1.0.16/lldpd-1.0.16.tar.gz'.
> Checksum mismatch! File: '.../downloads/lldpd-1.0.16.tar.gz.tmp' has sha256
> checksum '7753c6e31e938923185f4e10c4ab328929729e22ee4a9687d08881fb82c092ee'
> when 'f7fe3a130be98a19c491479ef60f36b8ee41a9e6bc4d7f2c41033f63956a3126' was
> expected
>
> I.e., the checksums for the 1.0.16 tarball on media.luffy.cx does not match
> the checksum of the same tar ball on github.com. And comparing the contents
> of the two identically named tarballs reveals that the one from
> media.luffy.cx has been generated with newer version of autoconf and
> automake.
>
> I also wonder if the change of SRC_URI, which was triggered by the AB not
> being able to fetch the tarball, was really due to the checksum not having
> been updated when the recipe version was stepped.

The site was not accessible. I would rather use github release
artifacts if the projects
make that. I think I forgot to run bitbake -ccleanall before testing
this change. Thanks for reporting it.
and fixing it.

>
> Based on the above, my recommendation is to revert commit e154914718 (i.e.,
> the SRC_URI update), and then update the checksum as per the originally
> supplied patch from Wang Mingyu:
>
> SRC_URI[sha256sum] = "e3b391650c7ba67cea2fe84d67fdb4d7fc8aa1ec5cf86eb8bb984711df8465a9"
>
> I will send two patches to do this.
>
> >
> >  inherit autotools update-rc.d useradd systemd pkgconfig bash-completion github-releases ptest
> >
> > --
> > 2.25.1
>
> //Peter
>