diff mbox series

[meta-oe] mariadb: Fix buildpaths warning.

Message ID 1663310379-31652-1-git-send-email-leimaohui@fujitsu.com
State Under Review
Headers show
Series [meta-oe] mariadb: Fix buildpaths warning. | expand

Commit Message

Maohui Lei (Fujitsu) Sept. 16, 2022, 6:39 a.m. UTC
WARNING: mariadb-10.8.3-r0 do_package_qa: QA Issue: File /usr/src/debug/mariadb/10.8.3-r0/sql/yy_oracle.hh in package mariadb-src contains reference to TMPDIR
File /usr/src/debug/mariadb/10.8.3-r0/sql/yy_mariadb.cc in package mariadb-src contains reference to TMPDIR
File /usr/src/debug/mariadb/10.8.3-r0/sql/yy_mariadb.hh in package mariadb-src contains reference to TMPDIR
File /usr/src/debug/mariadb/10.8.3-r0/sql/yy_oracle.cc in package mariadb-src contains reference to TMPDIR [buildpaths]

Signed-off-by: Lei Maohui <leimaohui@fujitsu.com>
---
 meta-oe/recipes-dbs/mysql/mariadb.inc | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Khem Raj Sept. 16, 2022, 6:55 a.m. UTC | #1
On Thu, Sep 15, 2022 at 11:39 PM leimaohui <leimaohui@fujitsu.com> wrote:
>
> WARNING: mariadb-10.8.3-r0 do_package_qa: QA Issue: File /usr/src/debug/mariadb/10.8.3-r0/sql/yy_oracle.hh in package mariadb-src contains reference to TMPDIR
> File /usr/src/debug/mariadb/10.8.3-r0/sql/yy_mariadb.cc in package mariadb-src contains reference to TMPDIR
> File /usr/src/debug/mariadb/10.8.3-r0/sql/yy_mariadb.hh in package mariadb-src contains reference to TMPDIR
> File /usr/src/debug/mariadb/10.8.3-r0/sql/yy_oracle.cc in package mariadb-src contains reference to TMPDIR [buildpaths]
>
> Signed-off-by: Lei Maohui <leimaohui@fujitsu.com>
> ---
>  meta-oe/recipes-dbs/mysql/mariadb.inc | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/meta-oe/recipes-dbs/mysql/mariadb.inc b/meta-oe/recipes-dbs/mysql/mariadb.inc
> index c63d511..7bd4ac0 100644
> --- a/meta-oe/recipes-dbs/mysql/mariadb.inc
> +++ b/meta-oe/recipes-dbs/mysql/mariadb.inc
> @@ -224,6 +224,17 @@ RDEPENDS:${PN}-setupdb = "coreutils"
>  # Allow old code to link to the backward compatible library
>  RDEPENDS:libmysqlclient-dev = "libmysqlclient-r-dev"
>
> +PACKAGE_PREPROCESS_FUNCS += "src_package_preprocess"
> +src_package_preprocess () {
> +        # Trim build paths from comments in generated sources to ensure reproducibility

how are these sources generated ?
some generation tools like lex/yacc we can control the paths by
running those tools in specific source directories and provided
relative
paths to sources as inputs during generation.

> +        sed -i -e "s,${S}/sql/,,g" \
> +               -e "s,${B}/sql/,,g" \
> +            ${B}/sql/yy_oracle.hh \
> +            ${B}/sql/yy_mariadb.cc \
> +            ${B}/sql/yy_mariadb.hh \
> +            ${B}/sql/yy_oracle.cc
> +}
> +
>  FILES:libmysqlclient = "\
>      ${libdir}/libmysqlclient.so.* \
>      ${libdir}/libmariadb.so.* \
> --
> 1.8.3.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#98829): https://lists.openembedded.org/g/openembedded-devel/message/98829
> Mute This Topic: https://lists.openembedded.org/mt/93717522/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-dbs/mysql/mariadb.inc b/meta-oe/recipes-dbs/mysql/mariadb.inc
index c63d511..7bd4ac0 100644
--- a/meta-oe/recipes-dbs/mysql/mariadb.inc
+++ b/meta-oe/recipes-dbs/mysql/mariadb.inc
@@ -224,6 +224,17 @@  RDEPENDS:${PN}-setupdb = "coreutils"
 # Allow old code to link to the backward compatible library
 RDEPENDS:libmysqlclient-dev = "libmysqlclient-r-dev"
 
+PACKAGE_PREPROCESS_FUNCS += "src_package_preprocess"
+src_package_preprocess () {
+        # Trim build paths from comments in generated sources to ensure reproducibility
+        sed -i -e "s,${S}/sql/,,g" \
+               -e "s,${B}/sql/,,g" \
+            ${B}/sql/yy_oracle.hh \
+            ${B}/sql/yy_mariadb.cc \
+            ${B}/sql/yy_mariadb.hh \
+            ${B}/sql/yy_oracle.cc
+}
+
 FILES:libmysqlclient = "\
     ${libdir}/libmysqlclient.so.* \
     ${libdir}/libmariadb.so.* \