mbox series

[0/1] RFC: some issues with go?

Message ID 20240915175305.3390769-1-jan.vermaete@gmail.com
Headers show
Series RFC: some issues with go? | expand

Message

Jan Vermaete Sept. 15, 2024, 5:53 p.m. UTC
Could someone review this patch that enables the Go-based plugins of Netdata?

I tested it in QEMU with the Go example package enable locally.

I have this error when building the image (with Kas)
----------------------------------------------------

 NOTE: Executing Tasks
 NOTE: Tasks Summary: Attempted 5371 tasks of which 5341 didn't need to be rerun and all succeeded.
 NOTE: Writing buildhistory
 NOTE: Writing buildhistory took: 2 seconds
 Exception ignored in: <function SetupHome.__del__ at 0x7fe2f82682c0>
 Traceback (most recent call last):
   File "/usr/local/lib/python3.11/dist-packages/kas/libcmds.py", line 166, in __del__
     shutil.rmtree(self.tmpdirname)
   File "/usr/lib/python3.11/shutil.py", line 732, in rmtree
     _rmtree_safe_fd(fd, path, onerror)
   File "/usr/lib/python3.11/shutil.py", line 660, in _rmtree_safe_fd
     _rmtree_safe_fd(dirfd, fullname, onerror)
   File "/usr/lib/python3.11/shutil.py", line 660, in _rmtree_safe_fd
     _rmtree_safe_fd(dirfd, fullname, onerror)
   File "/usr/lib/python3.11/shutil.py", line 660, in _rmtree_safe_fd
     _rmtree_safe_fd(dirfd, fullname, onerror)
   [Previous line repeated 2 more times]
   File "/usr/lib/python3.11/shutil.py", line 683, in _rmtree_safe_fd
     onerror(os.unlink, fullname, sys.exc_info())
   File "/usr/lib/python3.11/shutil.py", line 681, in _rmtree_safe_fd
     os.unlink(entry.name, dir_fd=topfd)
 PermissionError: [Errno 13] Permission denied: 'rounder_example_test.go'

Workaround for network access
-----------------------------

I there a way to avoid the 'do_compile[network] = "1"'.  It seems to be
needed to fetch the Go packages specified in the go.mod file.


INSAGE_SKIP
-----------

How to avoid the QA error/warning `already-stripped`?

  ERROR: netdata-1.47.1-r0 do_package: QA Issue: File '/usr/libexec/netdata/plugins.d/go.d.plugin' from netdata was already stripped, this will prevent future debugging! [already-stripped]
  ERROR: netdata-1.47.1-r0 do_package: Fatal QA errors were found, failing task.



Jan Vermaete (1):
  netdata: enable Go-based plugins

 .../recipes-webadmin/netdata/netdata_1.47.1.bb  | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

Comments

Peter Kjellerstedt Sept. 23, 2024, 7:22 p.m. UTC | #1
> -----Original Message-----
> From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Jan Vermaete
> Sent: den 15 september 2024 19:53
> To: openembedded-devel@lists.openembedded.org
> Cc: Jan Vermaete <jan.vermaete@gmail.com>
> Subject: [oe] [PATCH 0/1] RFC: some issues with go?
> 
> Could someone review this patch that enables the Go-based plugins of
> Netdata?
> 
> I tested it in QEMU with the Go example package enable locally.

[cut]

> Workaround for network access
> -----------------------------
> 
> I there a way to avoid the 'do_compile[network] = "1"'.  It seems to be
> needed to fetch the Go packages specified in the go.mod file.

A fetcher for Go modules was just added to bitbake and will be 
present in Styhead. Unfortunately the necessary changes to 
go-mod.bbclass to make it usable did not make it in time and are 
only available on master. :(

I intend to send patches to update the Go recipes in meta-oe to 
use the new fetcher, but unfortunately I am a bit backlogged 
after having attended OSS + LPC + Yocto Dev Day in Vienna last 
week.

//Peter