[1/1] gawk: Append AGPL-3.0-or-later to LICENSE when pma is enabled

From: Robert Yang <liezhi.yang@windriver.com>

The support/pma.c and support/pma.h's license is AGPL-3.0-or-later, this patch
disables pma by default, and append AGPL-3.0-or-later to LICENSE when pma is
enabled, and print a warning for that.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-extended/gawk/gawk_5.3.2.bb | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

On Fri, 19 Sept 2025 at 08:48, Robert Yang via lists.openembedded.org
<liezhi.yang=windriver.com@lists.openembedded.org> wrote:
>  PACKAGECONFIG ??= "readline mpfr"
>  PACKAGECONFIG[readline] = "--with-readline,--without-readline,readline"
>  PACKAGECONFIG[mpfr] = "--with-mpfr,--without-mpfr, mpfr"
> +PACKAGECONFIG[pma] = ",--disable-pma"

This needs --enable-pma too, to avoid a floating feature enablement/disablement.

> +python() {
> +    packageconfig = (d.getVar('PACKAGECONFIG') or '').split()
> +    # The support/pma.c and support/pma.h's license is AGPL-3.0-or-later
> +    if 'pma' in packageconfig:
> +        bb.warn("Appending AGPL-3.0-or-later to LICENSE since pma is enabled")
> +        d.appendVar('LICENSE', ' & AGPL-3.0-or-later')
> +        d.appendVar('LIC_FILES_CHKSUM', ' file://support/pma.h;endline=21;md5=32bd750ee5aa5cbcf7978c1be6462b8a \
> +                    file://support/pma.c;endline=28;md5=a3f33ec236ab96537cdfd1dcda270c75')

This should be set unconditionally, as it is specifying source code
licenses that apply regardless of build time choices. Then you can set
licenses for a particular package(s) to include AGPL or not depending
on packageconfig, but I believe that too can be done without resorting
to anonymous python.

Alex

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Alexander Kanavin via lists.openembedded.org
> Sent: den 19 september 2025 12:25
> To: liezhi.yang@windriver.com
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/1] gawk: Append AGPL-3.0-or-later to LICENSE when pma is enabled
> 
> On Fri, 19 Sept 2025 at 08:48, Robert Yang via lists.openembedded.org <liezhi.yang=windriver.com@lists.openembedded.org> wrote:
> >  PACKAGECONFIG ??= "readline mpfr"
> >  PACKAGECONFIG[readline] = "--with-readline,--without-readline,readline"
> >  PACKAGECONFIG[mpfr] = "--with-mpfr,--without-mpfr, mpfr"
> > +PACKAGECONFIG[pma] = ",--disable-pma"
> 
> This needs --enable-pma too, to avoid a floating feature
> enablement/disablement.
> 
> > +python() {
> > +    packageconfig = (d.getVar('PACKAGECONFIG') or '').split()
> > +    # The support/pma.c and support/pma.h's license is AGPL-3.0-or-later
> > +    if 'pma' in packageconfig:
> > +        bb.warn("Appending AGPL-3.0-or-later to LICENSE since pma is enabled")
> > +        d.appendVar('LICENSE', ' & AGPL-3.0-or-later')
> > +        d.appendVar('LIC_FILES_CHKSUM', ' file://support/pma.h;endline=21;md5=32bd750ee5aa5cbcf7978c1be6462b8a \
> > +                    file://support/pma.c;endline=28;md5=a3f33ec236ab96537cdfd1dcda270c75')
> 
> This should be set unconditionally, as it is specifying source code
> licenses that apply regardless of build time choices. Then you can set
> licenses for a particular package(s) to include AGPL or not depending
> on packageconfig, but I believe that too can be done without resorting
> to anonymous python.
> 
> Alex

You can find an example of this being done in the cairo recipe.

//Peter

On 9/19/25 22:04, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Alexander Kanavin via lists.openembedded.org
>> Sent: den 19 september 2025 12:25
>> To: liezhi.yang@windriver.com
>> Cc: openembedded-core@lists.openembedded.org
>> Subject: Re: [OE-core] [PATCH 1/1] gawk: Append AGPL-3.0-or-later to LICENSE when pma is enabled
>>
>> On Fri, 19 Sept 2025 at 08:48, Robert Yang via lists.openembedded.org <liezhi.yang=windriver.com@lists.openembedded.org> wrote:
>>>   PACKAGECONFIG ??= "readline mpfr"
>>>   PACKAGECONFIG[readline] = "--with-readline,--without-readline,readline"
>>>   PACKAGECONFIG[mpfr] = "--with-mpfr,--without-mpfr, mpfr"
>>> +PACKAGECONFIG[pma] = ",--disable-pma"
>>
>> This needs --enable-pma too, to avoid a floating feature
>> enablement/disablement.
>>
>>> +python() {
>>> +    packageconfig = (d.getVar('PACKAGECONFIG') or '').split()
>>> +    # The support/pma.c and support/pma.h's license is AGPL-3.0-or-later
>>> +    if 'pma' in packageconfig:
>>> +        bb.warn("Appending AGPL-3.0-or-later to LICENSE since pma is enabled")
>>> +        d.appendVar('LICENSE', ' & AGPL-3.0-or-later')
>>> +        d.appendVar('LIC_FILES_CHKSUM', ' file://support/pma.h;endline=21;md5=32bd750ee5aa5cbcf7978c1be6462b8a \
>>> +                    file://support/pma.c;endline=28;md5=a3f33ec236ab96537cdfd1dcda270c75')
>>
>> This should be set unconditionally, as it is specifying source code
>> licenses that apply regardless of build time choices. Then you can set
>> licenses for a particular package(s) to include AGPL or not depending
>> on packageconfig, but I believe that too can be done without resorting
>> to anonymous python.
>>
>> Alex
> 
> You can find an example of this being done in the cairo recipe.

Thanks Alex and Peter, I will send a V2 for it.

// Robert

> 
> //Peter
>