diff mbox series

[kirkstone,2/2] selftest/runtime_test/virgl: Disable for all fedora

Message ID c4760d6a52011515b0f931d08f619c7e49e72158.1728585736.git.steve@sakoman.com
State Accepted, archived
Commit c4760d6a52011515b0f931d08f619c7e49e72158
Delegated to: Steve Sakoman
Headers show
Series [kirkstone,1/2] valgrind: disable avx_estimate_insn.vgtest | expand

Commit Message

Steve Sakoman Oct. 10, 2024, 6:44 p.m. UTC
We can't support vgem on RHEL derived distros so disable this test for
all fedora hosts rather than specific versions.

Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/lib/oeqa/selftest/cases/runtime_test.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Kanavin Oct. 17, 2024, 9:05 a.m. UTC | #1
On Thu, 10 Oct 2024 at 20:44, Steve Sakoman via lists.openembedded.org
<steve=sakoman.com@lists.openembedded.org> wrote:

> We can't support vgem on RHEL derived distros so disable this test for
> all fedora hosts rather than specific versions.
>          render_hint = """If /dev/dri/renderD* is absent due to lack of suitable GPU, 'modprobe vgem' will create one suitable for mesa llvmpipe software renderer."""

I don't think this is accurate. It's the other way around: RHEL is
derived from Fedora. Also, vgem module can be installed in Fedora, but
not on RHEL or rocky/alma (which are derived from RHEL). We do this on
all fedora build hosts, and virgl tests run fine on Fedora workers
then, at least on the master branch.

What prompted this patch specifically?

Alex
Alexander Kanavin Oct. 17, 2024, 9:44 a.m. UTC | #2
On Thu, 10 Oct 2024 at 20:44, Steve Sakoman via lists.openembedded.org
<steve=sakoman.com@lists.openembedded.org> wrote:
>
> We can't support vgem on RHEL derived distros so disable this test for
> all fedora hosts rather than specific versions.
>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  meta/lib/oeqa/selftest/cases/runtime_test.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py b/meta/lib/oeqa/selftest/cases/runtime_test.py
> index 7dcdfd0ab2..93c6da1889 100644
> --- a/meta/lib/oeqa/selftest/cases/runtime_test.py
> +++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
> @@ -258,7 +258,7 @@ class TestImage(OESelftestTestCase):
>
>          distro = oe.lsb.distro_identifier()
>          if distro and (distro in ['debian-9', 'debian-10', 'centos-7', 'centos-8', 'ubuntu-16.04', 'ubuntu-18.04'] or
> -            distro.startswith('almalinux') or distro.startswith('rocky')):
> +            distro.startswith('almalinux') or distro.startswith('fedora') or distro.startswith('rocky')):

Wait, was fedora confused with centos maybe? Centos 9 is not on the
list, but perhaps should be.

Alex
Steve Sakoman Oct. 17, 2024, 12:09 p.m. UTC | #3
On Thu, Oct 17, 2024 at 2:05 AM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> On Thu, 10 Oct 2024 at 20:44, Steve Sakoman via lists.openembedded.org
> <steve=sakoman.com@lists.openembedded.org> wrote:
>
> > We can't support vgem on RHEL derived distros so disable this test for
> > all fedora hosts rather than specific versions.
> >          render_hint = """If /dev/dri/renderD* is absent due to lack of suitable GPU, 'modprobe vgem' will create one suitable for mesa llvmpipe software renderer."""
>
> I don't think this is accurate. It's the other way around: RHEL is
> derived from Fedora. Also, vgem module can be installed in Fedora, but
> not on RHEL or rocky/alma (which are derived from RHEL). We do this on
> all fedora build hosts, and virgl tests run fine on Fedora workers
> then, at least on the master branch.
>
> What prompted this patch specifically?

When we moved to the new autobuilder cluster the kirkstone supported
versions of fedora were no longer available, only fedora 39/40.

The kirkstone virgl headless tests failed 100% of the time with the
new fedora 39/40 workers.  I discussed this with Richard on irc and he
recommended that we disable the test for kirkstone on those workers.

Steve
Alexander Kanavin Oct. 17, 2024, 12:15 p.m. UTC | #4
On Thu, 17 Oct 2024 at 14:10, Steve Sakoman <steve@sakoman.com> wrote:
> When we moved to the new autobuilder cluster the kirkstone supported
> versions of fedora were no longer available, only fedora 39/40.
>
> The kirkstone virgl headless tests failed 100% of the time with the
> new fedora 39/40 workers.  I discussed this with Richard on irc and he
> recommended that we disable the test for kirkstone on those workers.

Right, I'm ok with that then.

Alex
diff mbox series

Patch

diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py b/meta/lib/oeqa/selftest/cases/runtime_test.py
index 7dcdfd0ab2..93c6da1889 100644
--- a/meta/lib/oeqa/selftest/cases/runtime_test.py
+++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
@@ -258,7 +258,7 @@  class TestImage(OESelftestTestCase):
 
         distro = oe.lsb.distro_identifier()
         if distro and (distro in ['debian-9', 'debian-10', 'centos-7', 'centos-8', 'ubuntu-16.04', 'ubuntu-18.04'] or
-            distro.startswith('almalinux') or distro.startswith('rocky')):
+            distro.startswith('almalinux') or distro.startswith('fedora') or distro.startswith('rocky')):
             self.skipTest('virgl headless cannot be tested with %s' %(distro))
 
         render_hint = """If /dev/dri/renderD* is absent due to lack of suitable GPU, 'modprobe vgem' will create one suitable for mesa llvmpipe software renderer."""