diff mbox series

pg-core-weston: Downgrade weston-examples, wayland-utils to RECOMMENDS

Message ID bc74d25252859b33cf6d31e427766e8b55ee3ea1.1750766586.git.joerg.sommer@navimatix.de
State New
Headers show
Series pg-core-weston: Downgrade weston-examples, wayland-utils to RECOMMENDS | expand

Commit Message

Jörg Sommer June 24, 2025, 12:03 p.m. UTC
From: Jörg Sommer <joerg.sommer@navimatix.de>

These tools aren't really necessary to run a weston session.

Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
---
 .../recipes-graphics/packagegroups/packagegroup-core-weston.bb | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ross Burton June 26, 2025, 10:19 a.m. UTC | #1
On 24 Jun 2025, at 13:03, Jörg Sommer via lists.openembedded.org <joerg.sommer=navimatix.de@lists.openembedded.org> wrote:
> 
> From: Jörg Sommer <joerg.sommer@navimatix.de>
> 
> These tools aren't really necessary to run a weston session.
> 
> Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
> ---
> .../recipes-graphics/packagegroups/packagegroup-core-weston.bb | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-graphics/packagegroups/packagegroup-core-weston.bb b/meta/recipes-graphics/packagegroups/packagegroup-core-weston.bb
> index dd302c89e7..890e442edb 100644
> --- a/meta/recipes-graphics/packagegroups/packagegroup-core-weston.bb
> +++ b/meta/recipes-graphics/packagegroups/packagegroup-core-weston.bb
> @@ -9,6 +9,9 @@ REQUIRED_DISTRO_FEATURES = "wayland ${@oe.utils.conditional('VIRTUAL-RUNTIME_ini
> RDEPENDS:${PN} = "\
>     weston \
>     weston-init \
> +    "
> +
> +RRECOMMENDS:${PN} = "\
>     weston-examples \
>     wayland-utils \
>     "

This doesn’t feel like it goes far enough to make the weston packagegroup actually useful, because you’d still need to use NO_RECOMMENDS to stop weston-examples being pull in.

How about splitting the packagegroup recipe into sub-packages (as several others do), so there’s the core package and then an -examples or -demos package that pulls in weston-examples and wayland-utils?

This way the core-image-weston can still pull in both, but your custom image can just use the core packagegroup.

Ross
diff mbox series

Patch

diff --git a/meta/recipes-graphics/packagegroups/packagegroup-core-weston.bb b/meta/recipes-graphics/packagegroups/packagegroup-core-weston.bb
index dd302c89e7..890e442edb 100644
--- a/meta/recipes-graphics/packagegroups/packagegroup-core-weston.bb
+++ b/meta/recipes-graphics/packagegroups/packagegroup-core-weston.bb
@@ -9,6 +9,9 @@  REQUIRED_DISTRO_FEATURES = "wayland ${@oe.utils.conditional('VIRTUAL-RUNTIME_ini
 RDEPENDS:${PN} = "\
     weston \
     weston-init \
+    "
+
+RRECOMMENDS:${PN} = "\
     weston-examples \
     wayland-utils \
     "