[scarthgap,6/7] bluez5: make media control a PACKAGECONFIG option

From: Jeroen Hofstee <jhofstee@victronenergy.com>

When not building with the default PACKAGECONFIG options, the build can fail
with:

undefined reference to `media_player_controller_create'
undefined reference to `media_player_set_status'

Otherwise. So disable it when not set and enable it by default.

The packageconfig option is the same as in Styhead.
https://github.com/openembedded/openembedded-core/commit/ebbdb7cf5c0a3f0e6773704d4c4cc570358ec611#diff-9d9284f6f27a81c75dffffd6d601b40c8266ae12e678d0a49c46bdb8356a0e91R52

Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
 1 file changed, 2 insertions(+)

On 5/6/25 17:13, Steve Sakoman via lists.openembedded.org wrote:
> From: Jeroen Hofstee <jhofstee@victronenergy.com>
>
> When not building with the default PACKAGECONFIG options, the build can fail
> with:
>
> undefined reference to `media_player_controller_create'
> undefined reference to `media_player_set_status'
>
> Otherwise. So disable it when not set and enable it by default.
>
> The packageconfig option is the same as in Styhead.
> https://github.com/openembedded/openembedded-core/commit/ebbdb7cf5c0a3f0e6773704d4c4cc570358ec611#diff-9d9284f6f27a81c75dffffd6d601b40c8266ae12e678d0a49c46bdb8356a0e91R52
>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
Technicality nitpick, depending on how important it is deemed: this
patch is missing the original submitter's sign-off.
> ---
>  meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index 39e1bf389c..731bfa0e40 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -18,6 +18,7 @@ PACKAGECONFIG ??= "obex-profiles \
>      ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
>      a2dp-profiles \
>      avrcp-profiles \
> +    mcp-profiles \
>      network-profiles \
>      hid-profiles \
>      hog-profiles \
> @@ -35,6 +36,7 @@ PACKAGECONFIG[nfc] = "--enable-nfc,--disable-nfc"
>  PACKAGECONFIG[sap-profiles] = "--enable-sap,--disable-sap"
>  PACKAGECONFIG[a2dp-profiles] = "--enable-a2dp,--disable-a2dp"
>  PACKAGECONFIG[avrcp-profiles] = "--enable-avrcp,--disable-avrcp"
> +PACKAGECONFIG[mcp-profiles] = "--enable-mcp,--disable-mcp"
>  PACKAGECONFIG[network-profiles] = "--enable-network,--disable-network"
>  PACKAGECONFIG[hid-profiles] = "--enable-hid,--disable-hid"
>  PACKAGECONFIG[hog-profiles] = "--enable-hog,--disable-hog"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#216063): https://lists.openembedded.org/g/openembedded-core/message/216063
> Mute This Topic: https://lists.openembedded.org/mt/112650828/6084445
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [skandigraun@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

On Tue, May 6, 2025 at 8:19 AM Gyorgy Sarvari <skandigraun@gmail.com> wrote:
>
> On 5/6/25 17:13, Steve Sakoman via lists.openembedded.org wrote:
> > From: Jeroen Hofstee <jhofstee@victronenergy.com>
> >
> > When not building with the default PACKAGECONFIG options, the build can fail
> > with:
> >
> > undefined reference to `media_player_controller_create'
> > undefined reference to `media_player_set_status'
> >
> > Otherwise. So disable it when not set and enable it by default.
> >
> > The packageconfig option is the same as in Styhead.
> > https://github.com/openembedded/openembedded-core/commit/ebbdb7cf5c0a3f0e6773704d4c4cc570358ec611#diff-9d9284f6f27a81c75dffffd6d601b40c8266ae12e678d0a49c46bdb8356a0e91R52
> >
> > Signed-off-by: Steve Sakoman <steve@sakoman.com>
> Technicality nitpick, depending on how important it is deemed: this
> patch is missing the original submitter's sign-off.

Good catch!  Thanks for reviewing.  I will add it before merging.

Steve

> > ---
> >  meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> > index 39e1bf389c..731bfa0e40 100644
> > --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> > +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> > @@ -18,6 +18,7 @@ PACKAGECONFIG ??= "obex-profiles \
> >      ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
> >      a2dp-profiles \
> >      avrcp-profiles \
> > +    mcp-profiles \
> >      network-profiles \
> >      hid-profiles \
> >      hog-profiles \
> > @@ -35,6 +36,7 @@ PACKAGECONFIG[nfc] = "--enable-nfc,--disable-nfc"
> >  PACKAGECONFIG[sap-profiles] = "--enable-sap,--disable-sap"
> >  PACKAGECONFIG[a2dp-profiles] = "--enable-a2dp,--disable-a2dp"
> >  PACKAGECONFIG[avrcp-profiles] = "--enable-avrcp,--disable-avrcp"
> > +PACKAGECONFIG[mcp-profiles] = "--enable-mcp,--disable-mcp"
> >  PACKAGECONFIG[network-profiles] = "--enable-network,--disable-network"
> >  PACKAGECONFIG[hid-profiles] = "--enable-hid,--disable-hid"
> >  PACKAGECONFIG[hog-profiles] = "--enable-hog,--disable-hog"
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#216063): https://lists.openembedded.org/g/openembedded-core/message/216063
> > Mute This Topic: https://lists.openembedded.org/mt/112650828/6084445
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [skandigraun@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>