| Message ID | SA1P223MB1187C93538CD6219C8C10402CB752@SA1P223MB1187.NAMP223.PROD.OUTLOOK.COM |
|---|---|
| State | New |
| Headers | show |
| Series | [master] meta-toolchain: inherit nopackages | expand |
On Sun, 2024-09-29 at 13:55 -0500, Atharva Nandanwar via lists.openembedded.org wrote: > From: Atharva Nandanwar <atharvanandanwar@outlook.com> > > - buildhistory emits hard error when no files are present in > package-split. > - meta-toolchain doesn't install/package any files, hence inheriting > nopackages should allow building this recipe again > > Signed-off-by: Atharva Nandanwar <atharvanandanwar@outlook.com> > --- > meta/recipes-core/meta/meta-toolchain.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/meta/meta-toolchain.bb b/meta/recipes- > core/meta/meta-toolchain.bb > index 260e03934e..c97cc68ad4 100644 > --- a/meta/recipes-core/meta/meta-toolchain.bb > +++ b/meta/recipes-core/meta/meta-toolchain.bb > @@ -2,4 +2,4 @@ SUMMARY = "Meta package for building a installable > toolchain" > LICENSE = "MIT" > > > -inherit populate_sdk > +inherit nopackages populate_sdk This shouldn't be needed on master since: meta/classes-recipe/populate_sdk_base.bbclass has: inherit image-postinst-intercepts image-artifact-names nopackages Cheers, Richard
On 9/29/24 16:57, Richard Purdie wrote: > On Sun, 2024-09-29 at 13:55 -0500, Atharva Nandanwar via > lists.openembedded.org wrote: >> From: Atharva Nandanwar <atharvanandanwar@outlook.com> >> >> - buildhistory emits hard error when no files are present in >> package-split. >> - meta-toolchain doesn't install/package any files, hence inheriting >> nopackages should allow building this recipe again >> >> Signed-off-by: Atharva Nandanwar <atharvanandanwar@outlook.com> >> --- >> meta/recipes-core/meta/meta-toolchain.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-core/meta/meta-toolchain.bb b/meta/recipes- >> core/meta/meta-toolchain.bb >> index 260e03934e..c97cc68ad4 100644 >> --- a/meta/recipes-core/meta/meta-toolchain.bb >> +++ b/meta/recipes-core/meta/meta-toolchain.bb >> @@ -2,4 +2,4 @@ SUMMARY = "Meta package for building a installable >> toolchain" >> LICENSE = "MIT" >> >> >> -inherit populate_sdk >> +inherit nopackages populate_sdk > This shouldn't be needed on master since: > > meta/classes-recipe/populate_sdk_base.bbclass > > has: > > inherit image-postinst-intercepts image-artifact-names nopackages > > Cheers, > > Richard That makes sense. Looks like we need [1] on scarthgap and kirkstone. As the buildhistory patch made it's way onto those branches. 1 - 29ac598c4f754ce5cee59d3360612f661ad02191 Thanks, --Atharva
diff --git a/meta/recipes-core/meta/meta-toolchain.bb b/meta/recipes-core/meta/meta-toolchain.bb index 260e03934e..c97cc68ad4 100644 --- a/meta/recipes-core/meta/meta-toolchain.bb +++ b/meta/recipes-core/meta/meta-toolchain.bb @@ -2,4 +2,4 @@ SUMMARY = "Meta package for building a installable toolchain" LICENSE = "MIT" -inherit populate_sdk +inherit nopackages populate_sdk