| Message ID | 761f050783a445a6b900024a4e10a3c414bd504b.1653489126.git.steve@sakoman.com |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [dunfell,1/4] pcre2: CVE-2022-1586 Out-of-bounds read | expand |
Why should ${PN} rprovide these when they are packaged in separate packages
as ${PN}-nouveau ${PN}-intel ${PN}-radeon?
On Wed, May 25, 2022 at 4:36 PM Steve Sakoman <steve@sakoman.com> wrote:
> From: Minjae Kim <flowergom@gmail.com>
>
> The libdrm-{nouveau,radeon,intel} are generated by libdrm recipe.
> To use these libraries as a dependency in another component,
> It should be explicitly added as RPROVIDES.
>
> Signed-off-by:Minjae Kim <flowergom@gmail.com>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
> meta/recipes-graphics/drm/libdrm_2.4.101.bb | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/meta/recipes-graphics/drm/libdrm_2.4.101.bb
> b/meta/recipes-graphics/drm/libdrm_2.4.101.bb
> index 8ec566faa9..4f3e767af0 100644
> --- a/meta/recipes-graphics/drm/libdrm_2.4.101.bb
> +++ b/meta/recipes-graphics/drm/libdrm_2.4.101.bb
> @@ -57,3 +57,9 @@ FILES_${PN}-amdgpu = "${libdir}/libdrm_amdgpu.so.*
> ${datadir}/${PN}/amdgpu.ids"
> FILES_${PN}-etnaviv = "${libdir}/libdrm_etnaviv.so.*"
>
> BBCLASSEXTEND = "native nativesdk"
> +
> +RPROVIDES_${PN} += " \
> + libdrm-nouveau \
> + libdrm-radeon \
> + libdrm-intel \
> +"
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#166150):
> https://lists.openembedded.org/g/openembedded-core/message/166150
> Mute This Topic: https://lists.openembedded.org/mt/91334283/3617156
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> Martin.Jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
On Wed, May 25, 2022 at 4:41 AM Martin Jansa <martin.jansa@gmail.com> wrote: > > Why should ${PN} rprovide these when they are packaged in separate packages as ${PN}-nouveau ${PN}-intel ${PN}-radeon? Good question! Sorry I didn't catch this earlier. I'll drop this patch from the pull request. Thanks for reviewing. Steve > On Wed, May 25, 2022 at 4:36 PM Steve Sakoman <steve@sakoman.com> wrote: >> >> From: Minjae Kim <flowergom@gmail.com> >> >> The libdrm-{nouveau,radeon,intel} are generated by libdrm recipe. >> To use these libraries as a dependency in another component, >> It should be explicitly added as RPROVIDES. >> >> Signed-off-by:Minjae Kim <flowergom@gmail.com> >> Signed-off-by: Steve Sakoman <steve@sakoman.com> >> --- >> meta/recipes-graphics/drm/libdrm_2.4.101.bb | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/meta/recipes-graphics/drm/libdrm_2.4.101.bb b/meta/recipes-graphics/drm/libdrm_2.4.101.bb >> index 8ec566faa9..4f3e767af0 100644 >> --- a/meta/recipes-graphics/drm/libdrm_2.4.101.bb >> +++ b/meta/recipes-graphics/drm/libdrm_2.4.101.bb >> @@ -57,3 +57,9 @@ FILES_${PN}-amdgpu = "${libdir}/libdrm_amdgpu.so.* ${datadir}/${PN}/amdgpu.ids" >> FILES_${PN}-etnaviv = "${libdir}/libdrm_etnaviv.so.*" >> >> BBCLASSEXTEND = "native nativesdk" >> + >> +RPROVIDES_${PN} += " \ >> + libdrm-nouveau \ >> + libdrm-radeon \ >> + libdrm-intel \ >> +" >> -- >> 2.25.1 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#166150): https://lists.openembedded.org/g/openembedded-core/message/166150 >> Mute This Topic: https://lists.openembedded.org/mt/91334283/3617156 >> Group Owner: openembedded-core+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [Martin.Jansa@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
To these packages( ${PN}-nouveau ${PN}-intel ${PN}-radeon) use as rdepends, these packages will not be installed when just libdrm add.
So I would like to use these packages directly, I added it as RPROVIDES.
In case of installing packages using DNF from binary feed on the target image,
this change can install packages specified by RDEPENDS at the same time.
diff --git a/meta/recipes-graphics/drm/libdrm_2.4.101.bb b/meta/recipes-graphics/drm/libdrm_2.4.101.bb index 8ec566faa9..4f3e767af0 100644 --- a/meta/recipes-graphics/drm/libdrm_2.4.101.bb +++ b/meta/recipes-graphics/drm/libdrm_2.4.101.bb @@ -57,3 +57,9 @@ FILES_${PN}-amdgpu = "${libdir}/libdrm_amdgpu.so.* ${datadir}/${PN}/amdgpu.ids" FILES_${PN}-etnaviv = "${libdir}/libdrm_etnaviv.so.*" BBCLASSEXTEND = "native nativesdk" + +RPROVIDES_${PN} += " \ + libdrm-nouveau \ + libdrm-radeon \ + libdrm-intel \ +"