diff mbox series

[1/1] bootchart2: Fix native build

Message ID 6890ffe7090972af68b585b0a130b29bbc700548.1731341964.git.liezhi.yang@windriver.com
State New
Headers show
Series [1/1] bootchart2: Fix native build | expand

Commit Message

Robert Yang Nov. 11, 2024, 4:20 p.m. UTC 
From: Robert Yang <liezhi.yang@windriver.com>

Fixed:
$ bitbake bootchart2-native
gzip: /path/to/bootchart2-native/0.14.9/recipe-sysroot-native/usr/share/man/man1/*.gz: No such file or directory

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ross Burton Nov. 12, 2024, 11:02 a.m. UTC | #1 
On 11 Nov 2024, at 16:20, Robert Yang via lists.openembedded.org <liezhi.yang=windriver.com@lists.openembedded.org> wrote:
> 
> From: Robert Yang <liezhi.yang@windriver.com>
> 
> Fixed:
> $ bitbake bootchart2-native
> gzip: /path/to/bootchart2-native/0.14.9/recipe-sysroot-native/usr/share/man/man1/*.gz: No such file or directory

The question is why does the manpage not exist in native builds, when there’s nothing in the makefile or recipe to disable the manpage.

/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9
$ find image/ -type f
image/etc/bootchartd.conf
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/etc/bootchartd.conf
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/etc/init.d/bootchartd_stop.sh
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/sbin/bootchartd
…
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/usr/lib/python3.13/site-packages/pybootchartgui/__init__.py
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/usr/lib/python3.13/site-packages/pybootchartgui/gui.py
image/usr/share/docs/bootchart/README
image/usr/share/docs/bootchart/README.pybootchart
image/usr/share/man/man1/bootchart2.1.gz
image/usr/share/man/man1/bootchartd.1.gz
image/usr/share/man/man1/pybootchartgui.1.gz

It’s because the install is broken, more paths need to be given to the makefile.  Fix the cause, don’t work around the symptoms.

Also adding -n to the gzip calls in the Makefile would make the resulting files reproducible, so we don’t need to decompress them.

Ross
Robert Yang Nov. 12, 2024, 11:21 a.m. UTC | #2 
On 11/12/24 19:02, Ross Burton via lists.openembedded.org wrote:
> On 11 Nov 2024, at 16:20, Robert Yang via lists.openembedded.org <liezhi.yang=windriver.com@lists.openembedded.org> wrote:
>>
>> From: Robert Yang <liezhi.yang@windriver.com>
>>
>> Fixed:
>> $ bitbake bootchart2-native
>> gzip: /path/to/bootchart2-native/0.14.9/recipe-sysroot-native/usr/share/man/man1/*.gz: No such file or directory
> 
> The question is why does the manpage not exist in native builds, when there’s nothing in the makefile or recipe to disable the manpage.
> 
> /work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9
> $ find image/ -type f
> image/etc/bootchartd.conf
> image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/etc/bootchartd.conf
> image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/etc/init.d/bootchartd_stop.sh
> image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/sbin/bootchartd
> …
> image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/usr/lib/python3.13/site-packages/pybootchartgui/__init__.py
> image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/usr/lib/python3.13/site-packages/pybootchartgui/gui.py
> image/usr/share/docs/bootchart/README
> image/usr/share/docs/bootchart/README.pybootchart
> image/usr/share/man/man1/bootchart2.1.gz
> image/usr/share/man/man1/bootchartd.1.gz
> image/usr/share/man/man1/pybootchartgui.1.gz
> 
> It’s because the install is broken, more paths need to be given to the makefile.  Fix the cause, don’t work around the symptoms.

You're right, I just fixed it by hand. I will send a V2 for it.

// Robert

> 
> Also adding -n to the gzip calls in the Makefile would make the resulting files reproducible, so we don’t need to decompress them.
> 
> Ross
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#207042): https://lists.openembedded.org/g/openembedded-core/message/207042
> Mute This Topic: https://lists.openembedded.org/mt/109517754/7304958
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [liezhi.yang@eng.windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
index 8a211366bf..535af94ecd 100644
--- a/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
+++ b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
@@ -138,7 +138,9 @@  do_install () {
 
    # Use python 3 instead of python 2
    sed -i -e '1s,#!.*python.*,#!${USRBINPATH}/env python3,' ${D}${bindir}/pybootchartgui
+}
 
+do_install:append:class-target () {
     # The timestamps embedded in compressed man pages is not reproducible
     gzip -d ${D}${mandir}/man1/*.gz
 }