diff mbox series

[4/4] Revert "python3-websockets: enable ptest"

Message ID 67b03cb15e4d75bced1c4837a0cf391105a2a379.1785799308.git.tim.orling@konsulko.com
State New
Headers show
Series [1/4] python3-cryptography{-vectors}: upgrade 49.0.0 -> 50.0.0 | expand

Commit Message

Tim Orling Aug. 3, 2026, 11:26 p.m. UTC 
From: Tim Orling <tim.orling@konsulko.com>

The tests/ are no longer packaged in the sdist and this is intentional:
https://github.com/python-websockets/websockets/issues/1739#issuecomment-5016084799

References:
https://websockets.readthedocs.io/en/stable/project/contributing.html#packaging

"You mustn’t rely on the git repository as input. Specifically, you
mustn’t attempt to run the main test suite. It isn’t treated as a
deliverable of the project. It doesn’t do what you think it does. It’s
designed for the needs of developers, not packagers.

On a typical build farm for a distribution, tests that exercise timeouts
will fail randomly. Indeed, the test suite is optimized for running very
fast, with a tolerable level of flakiness, on a high-end laptop without
noisy neighbors. This isn’t your context."

This reverts commit b75738de6f961a52f94dc89bf8178fef60217984.

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
---
 meta/conf/distro/include/ptest-packagelists.inc  |  1 -
 .../python/python3-websockets/run-ptest          |  7 -------
 .../python/python3-websockets_17.0.1.bb          | 16 +---------------
 3 files changed, 1 insertion(+), 23 deletions(-)
 delete mode 100644 meta/recipes-devtools/python/python3-websockets/run-ptest
diff mbox series

Patch

diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
index 453fb87c17..370606ead7 100644
--- a/meta/conf/distro/include/ptest-packagelists.inc
+++ b/meta/conf/distro/include/ptest-packagelists.inc
@@ -94,7 +94,6 @@  PTESTS_FAST = "\
     python3-uritools \
     python3-wcwidth \
     python3-webcolors \
-    python3-websockets \
     python3-wheel \
     qemu \
     quilt \
diff --git a/meta/recipes-devtools/python/python3-websockets/run-ptest b/meta/recipes-devtools/python/python3-websockets/run-ptest
deleted file mode 100644
index 5fe2bdf545..0000000000
--- a/meta/recipes-devtools/python/python3-websockets/run-ptest
+++ /dev/null
@@ -1,7 +0,0 @@ 
-#!/bin/sh
-
-# Skip these 2 test cases with fail due to an inherent test-order/caching
-# issue in that test module
-pytest --automake \
-    --deselect=tests/test_imports.py::ImportsTests::test_get_alias \
-    --deselect=tests/test_imports.py::ImportsTests::test_get_deprecated_alias
diff --git a/meta/recipes-devtools/python/python3-websockets_17.0.1.bb b/meta/recipes-devtools/python/python3-websockets_17.0.1.bb
index b84aa0dcef..6733cfd0f9 100644
--- a/meta/recipes-devtools/python/python3-websockets_17.0.1.bb
+++ b/meta/recipes-devtools/python/python3-websockets_17.0.1.bb
@@ -4,9 +4,7 @@  HOMEPAGE = "https://github.com/aaugustin/websockets"
 LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=51924a6af4495b8cfaee1b1da869b6f4"
 
-inherit pypi python_setuptools_build_meta ptest-python-pytest
-
-SRC_URI += "file://run-ptest"
+inherit pypi python_setuptools_build_meta
 
 SRC_URI[sha256sum] = "5baa9bc0dfbae8c507e51c8cf1b6d4628086f7a87bbd3a9952bd5f035451f1cc"
 
@@ -15,15 +13,3 @@  BBCLASSEXTEND = "native nativesdk"
 RDEPENDS:${PN} = " \
     python3-asyncio \
 "
-
-do_install_ptest:append() {
-    # These modules import test helpers from tests/asyncio, tests/sync or
-    # tests/extensions, which exist in the git checkout but are not part
-    # of the sdist, so they fail to collect. Drop them and keep only the
-    # self-contained sdist tests.
-    for f in test_auth.py test_cli.py test_client.py test_connection.py \
-             test_exceptions.py test_frames.py test_http.py test_http11.py \
-             test_protocol.py test_server.py test_streams.py; do
-        rm -f ${D}${PTEST_PATH}/tests/$f
-    done
-}