diff mbox series

[v2] icu: Workaround buildpaths QA check, if TMPDIR is /build/tmp

Message ID 6401da269fe72dc465d76c60f7ae5fd6eff27652.1774731856.git.joerg.sommer@navimatix.de
State New
Headers show
Series [v2] icu: Workaround buildpaths QA check, if TMPDIR is /build/tmp | expand

Commit Message

Jörg Sommer March 28, 2026, 9:04 p.m. UTC 
From: Jörg Sommer <joerg.sommer@navimatix.de>

The file udatatst.c really contains the string /build/tmp. When building
with kas-container the build directory is /build and hence the TMPDIR
becomes /build/tmp. This triggers the QA check *buildpaths*. To work around
this, slightly modify the string in the source code.

% grep -n -C2 /build/tmp source/test/cintltst/udatatst.c
136-    char* path=(char*)malloc(sizeof(char) * (strlen(ctest_dataOutDir())
137-                                           + strlen(U_ICUDATA_NAME)
138:                                           + strlen("/build/tmp/..")+1 ) );
139-
140-    char        *icuDataFilePath = 0;

Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
---
 .../icu/icu/mangle-build-tmp.patch            | 32 +++++++++++++++++++
 meta/recipes-support/icu/icu_78.3.bb          |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 meta/recipes-support/icu/icu/mangle-build-tmp.patch

Comments

patchtest@automation.yoctoproject.org March 28, 2026, 9:15 p.m. UTC | #1 
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/v2-icu-Workaround-buildpaths-QA-check-if-TMPDIR-is-build-tmp.patch

FAIL: test Upstream-Status presence: Upstream-Status is present only after the patch scissors. It must be placed in the patch header before the scissors line. (test_patch.TestPatch.test_upstream_status_presence_format)

PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!
diff mbox series

Patch

diff --git a/meta/recipes-support/icu/icu/mangle-build-tmp.patch b/meta/recipes-support/icu/icu/mangle-build-tmp.patch
new file mode 100644
index 0000000000..cf24e53b88
--- /dev/null
+++ b/meta/recipes-support/icu/icu/mangle-build-tmp.patch
@@ -0,0 +1,32 @@ 
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?J=C3=B6rg=20Sommer?= <joerg.sommer@navimatix.de>
+Date: Sat, 28 Mar 2026 20:29:53 +0100
+Subject: [PATCH] test/udatatst: Mangle /build/tmp
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+This string matches $TMPDIR (in a kas-container) which triggers the QA
+check buildpaths:
+
+ERROR: icu-78.2-r0 do_package_qa: QA Issue: File /usr/src/debug/icu/78.2/test/cintltst/udatatst.c in package icu-src contains reference to TMPDIR [buildpaths] 
+
+Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
+---
+Upstream-Status: Inappropriate [This QA check collision of Yocto specific]
+
+ test/cintltst/udatatst.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/test/cintltst/udatatst.c b/test/cintltst/udatatst.c
+index 003d7d4..7175725 100644
+--- a/test/cintltst/udatatst.c
++++ b/test/cintltst/udatatst.c
+@@ -135,7 +135,7 @@ static void TestUDataOpen(void){
+ 
+     char* path=(char*)malloc(sizeof(char) * (strlen(ctest_dataOutDir())
+                                            + strlen(U_ICUDATA_NAME)
+-                                           + strlen("/build/tmp/..")+1 ) );
++                                           + strlen("/""build/tmp/..")+1 ) );
+ 
+     char        *icuDataFilePath = 0;
+     
diff --git a/meta/recipes-support/icu/icu_78.3.bb b/meta/recipes-support/icu/icu_78.3.bb
index 367e2641e7..ad920f3ef4 100644
--- a/meta/recipes-support/icu/icu_78.3.bb
+++ b/meta/recipes-support/icu/icu_78.3.bb
@@ -111,6 +111,7 @@  SRC_URI = "${BASE_SRC_URI};name=code \
            file://0001-test-Add-support-ptest.patch \
            file://run-ptest \
            file://0001-Make-ICU-test-output-compatible-with-Automake-format.patch \
+           file://mangle-build-tmp.patch \
           "
 
 SRC_URI:append:class-target = "\