diff mbox series

[RFC,3/3] time: fix runtime version from UNKNOWN to 1.9

Message ID 4fb03305a3cf138c9a40f40e04004b022989d520.1743052694.git.Qi.Chen@windriver.com
State New
Headers show
Series [RFC,1/3] version-check.conf: add mechanism for checking version mismatch | expand

Commit Message

ChenQi March 27, 2025, 6:21 a.m. UTC 
From: Chen Qi <Qi.Chen@windriver.com>

The runtime version of time is determined by:
build-aux/git-version-gen .tarball-version

But there's no .tarball-version in the tarball. And time's last
commit dates back to 20210105, it's very unlikely for them to
generate a new tarball. So we add this file manually with ${PV}
as the content.

Before the fix, time --version:
time (GNU Time) UNKNOWN

After the fix, time --version:
time (GNU Time) 1.9

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-extended/time/time_1.9.bb | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Ross Burton March 27, 2025, 10:56 a.m. UTC | #1 
On 27 Mar 2025, at 06:21, Chen Qi via lists.openembedded.org <Qi.Chen=windriver.com@lists.openembedded.org> wrote:
> 
> From: Chen Qi <Qi.Chen@windriver.com>
> 
> The runtime version of time is determined by:
> build-aux/git-version-gen .tarball-version
> 
> But there's no .tarball-version in the tarball. And time's last
> commit dates back to 20210105, it's very unlikely for them to
> generate a new tarball. So we add this file manually with ${PV}
> as the content.

The upstream git repo has had activity since the 1.9 release so there _might_ be a new release in the future.

Can you link to the submitted fix for this (https://lists.gnu.org/archive/html/bug-time/2021-01/msg00000.html) and only write to .tarball-version if it doesn’t exist, so we don’t overwrite a file if it appears in a future release.

Ross
diff mbox series

Patch

diff --git a/meta/recipes-extended/time/time_1.9.bb b/meta/recipes-extended/time/time_1.9.bb
index 8364210e61..1872a409f7 100644
--- a/meta/recipes-extended/time/time_1.9.bb
+++ b/meta/recipes-extended/time/time_1.9.bb
@@ -21,3 +21,9 @@  SRC_URI[md5sum] = "d2356e0fe1c0b85285d83c6b2ad51b5f"
 SRC_URI[sha256sum] = "fbacf0c81e62429df3e33bda4cee38756604f18e01d977338e23306a3e3b521e"
 
 inherit autotools
+
+# We don't want our version to be "UNKNOWN", and time repo's latest commits dates back
+# to 20210105. It's very unlikely it'll generate a new tarball with a .tarball-version included.
+do_configure:prepend () {
+    echo ${PV} > ${S}/.tarball-version
+}