[kirkstone,21/27] sdk.py: error out when moving file fails

Message ID	4ed94fef70df05c874cf0c68dcc95c5636687825.1689689618.git.steve@sakoman.com
State	Accepted, archived
Commit	4ed94fef70df05c874cf0c68dcc95c5636687825
Headers	show Return-Path: <steve@sakoman.com> ip: 209.85.210.176, mailfrom: steve@sakoman.com) From: Steve Sakoman <steve@sakoman.com> To: openembedded-core@lists.openembedded.org Subject: [OE-core][kirkstone 21/27] sdk.py: error out when moving file fails Date: Tue, 18 Jul 2023 04:25:55 -1000 Message-Id: <4ed94fef70df05c874cf0c68dcc95c5636687825.1689689618.git.steve@sakoman.com> In-Reply-To: <cover.1689689618.git.steve@sakoman.com> References: <cover.1689689618.git.steve@sakoman.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	[kirkstone,01/27] perl: Fix CVE-2023-31486 \| expand [kirkstone,01/27] perl: Fix CVE-2023-31486 [kirkstone,02/27] sqlite3: CVE-2023-36191 CLI fault on missing -nonce [kirkstone,03/27] bind : fix CVE-2023-2828 & CVE-2023-2911 [kirkstone,04/27] libx11: Fix CVE-2023-3138 for kirkstone branch [kirkstone,05/27] curl: Added CVE-2023-28320 Follow-up patch [kirkstone,06/27] libwebp: Fix CVE-2023-1999 [kirkstone,07/27] tzdata: upgrade to 2023c [kirkstone,08/27] serf: upgrade 1.3.9 -> 1.3.10 [kirkstone,09/27] wget: upgrade 1.21.3 -> 1.21.4 [kirkstone,10/27] linux-firmware: upgrade 20230404 -> 20230515 [kirkstone,11/27] wireless-regdb: upgrade 2023.02.13 -> 2023.05.03 [kirkstone,12/27] vim: upgrade 9.0.1527 -> 9.0.1592 [kirkstone,13/27] selftest reproducible.py: support different build targets [kirkstone,14/27] selftest/reproducible: Allow chose the package manager [kirkstone,15/27] libpng: Add ptest for libpng [kirkstone,16/27] logrotate: Do not create logrotate.status file [kirkstone,17/27] pybootchartgui: show elapsed time for each task [kirkstone,18/27] systemd: Backport nspawn: make sure host root can write to the uidmapped mounts w… [kirkstone,19/27] rust-llvm: backport a fix for build with gcc-13 [kirkstone,20/27] bitbake.conf: add unzstd in HOSTTOOLS [kirkstone,21/27] sdk.py: error out when moving file fails [kirkstone,22/27] sdk.py: fix moving dnf contents [kirkstone,23/27] zip: fix configure check by using _Static_assert [kirkstone,24/27] unzip: fix configure check for cross compilation [kirkstone,25/27] sysfsutils: fetch a supported fork from github [kirkstone,26/27] wic: Add dependencies for erofs-utils [kirkstone,27/27] cmake: Fix CMAKE_SYSTEM_PROCESSOR setting for SDK

Message ID

4ed94fef70df05c874cf0c68dcc95c5636687825.1689689618.git.steve@sakoman.com

State

Accepted, archived

Commit

4ed94fef70df05c874cf0c68dcc95c5636687825

Headers

From: Steve Sakoman <steve@sakoman.com>
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][kirkstone 21/27] sdk.py: error out when moving file fails
Date: Tue, 18 Jul 2023 04:25:55 -1000
Message-Id: 
 <4ed94fef70df05c874cf0c68dcc95c5636687825.1689689618.git.steve@sakoman.com>
In-Reply-To: <cover.1689689618.git.steve@sakoman.com>
References: <cover.1689689618.git.steve@sakoman.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

[kirkstone,01/27] perl: Fix CVE-2023-31486 | expand

Commit Message

Steve Sakoman July 18, 2023, 2:25 p.m. UTC

From: Chen Qi <Qi.Chen@windriver.com>

Instead of printing an error message and continuing, we should just
error out when moving file fails.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 12aecd9da94b5f27041982c661e8bab316d365d4)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/lib/oe/sdk.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oe/sdk.py b/meta/lib/oe/sdk.py
index 27347667e8..2383bd58b7 100644
--- a/meta/lib/oe/sdk.py
+++ b/meta/lib/oe/sdk.py
@@ -68,7 +68,7 @@  class Sdk(object, metaclass=ABCMeta):
         #FIXME: using umbrella exc catching because bb.utils method raises it
         except Exception as e:
             bb.debug(1, "printing the stack trace\n %s" %traceback.format_exc())
-            bb.error("unable to place %s in final SDK location" % sourcefile)
+            bb.fatal("unable to place %s in final SDK location" % sourcefile)
 
     def mkdirhier(self, dirpath):
         try:

[kirkstone,21/27] sdk.py: error out when moving file fails

Commit Message

Patch