| Message ID | 3a20c600314b7acb3eb3015583a6cbc4ceb4970f.1749554012.git.liezhi.yang@windriver.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] libcheck: Fix do_install error with automake 1.18 | expand |
On 10 Jun 2025, at 12:17, liezhi.yang@windriver.com wrote: > > From: Robert Yang <liezhi.yang@windriver.com> > > * Drop 0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch, it is a > warning not an error any more, so just drop it. > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com> I still request holding off this until the rebuild problem that I’ve seen has been investigated properly. Ross
Hi Ross, On 6/10/25 19:21, Ross Burton via lists.openembedded.org wrote: > On 10 Jun 2025, at 12:17, liezhi.yang@windriver.com wrote: >> >> From: Robert Yang <liezhi.yang@windriver.com> >> >> * Drop 0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch, it is a >> warning not an error any more, so just drop it. >> >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > > I still request holding off this until the rebuild problem that I’ve seen has been investigated properly. I've replied in V1, did that address your problem? Or how can I reproduce the problem, please? The automake before 1.17's mdate-sh couldn't update libcheck's doc/version.texi, so the doc/check.info wasn't re-generated, then we couldn't see the build error before. I think this can also address Ross' question about rebuild libcheck failed with automake 1.18, it is because doc/check.info wasn't re-generated with automake 1.17, then we couldn't see the error. And for other recipes' rebuild, I've done the testing with: $ bitbake world Edit autotools.bbclass to triger rebuild $ bitbake world All of them worked well. // Robert > > Ross > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#218345): https://lists.openembedded.org/g/openembedded-core/message/218345 > Mute This Topic: https://lists.openembedded.org/mt/113567518/7304958 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [liezhi.yang@eng.windriver.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/recipes-devtools/automake/automake/0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch b/meta/recipes-devtools/automake/automake/0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch deleted file mode 100644 index 5a38feb16c..0000000000 --- a/meta/recipes-devtools/automake/automake/0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch +++ /dev/null @@ -1,34 +0,0 @@ -From 4339a2298a2d486fb4636b72393499b59805edde Mon Sep 17 00:00:00 2001 -From: Changqing Li <changqing.li@windriver.com> -Date: Thu, 21 Nov 2024 14:54:37 +0800 -Subject: [PATCH] configure: don't report error when the path of Perl contains - spaces or tabs - -In order to make setting PERL to "/usr/bin/env perl" works well, patch -configure as upstream suggested, refer [1]. - -[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74453 - -Upstream-Status: Inappropriate [ oe-specific ] - -Signed-off-by: Changqing Li <changqing.li@windriver.com> ---- - configure | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/configure b/configure -index 45bf85a..68d3c7d 100755 ---- a/configure -+++ b/configure -@@ -3514,7 +3514,7 @@ case $PERL in - as_fn_error $? "perl not found" "$LINENO" 5 - ;; - *' '* | *' '*) -- as_fn_error $? "The path to your Perl contains spaces or tabs. -+ : as_fn_error $? "The path to your Perl contains spaces or tabs. - This would cause build failures later or unusable programs. - Please use a path without spaces and try again." "$LINENO" 5 - ;; --- -2.25.1 - diff --git a/meta/recipes-devtools/automake/automake_1.17.bb b/meta/recipes-devtools/automake/automake_1.18.bb similarity index 85% rename from meta/recipes-devtools/automake/automake_1.17.bb rename to meta/recipes-devtools/automake/automake_1.18.bb index 4cda04e47b..516d0a58d9 100644 --- a/meta/recipes-devtools/automake/automake_1.17.bb +++ b/meta/recipes-devtools/automake/automake_1.18.bb @@ -22,10 +22,9 @@ SRC_URI += "\ file://0002-automake-Update-for-python.m4-to-respect-libdir.patch \ file://0004-Add-a-new-distro-feature-ptest.patch \ file://0006-automake-Remove-delays-in-configure-scripts-using-au.patch \ - file://0001-configure-don-t-report-error-when-the-path-of-Perl-c.patch \ " -SRC_URI[sha256sum] = "397767d4db3018dd4440825b60c64258b636eaf6bf99ac8b0897f06c89310acd" +SRC_URI[sha256sum] = "af6043a5d4b3beef0c48161f4a6936259321cd101a34c1ab0768328515626c8a" PERL = "${USRBINPATH}/perl" PERL:class-native = "${USRBINPATH}/env perl"