diff mbox series

[v2,32/32] python3-nose: drop recipe

Message ID 3071336da7ba931774c91ba3a937f277c7b7c7d7.1645478020.git.tim.orling@konsulko.com
State Accepted, archived
Commit 19135f8b7cbaabeb2e38572d11e909ce386d60b8
Headers show
Series [v2,01/32] python3-wheel: move 0.37.0 from meta-python | expand

Commit Message

Tim Orling Feb. 21, 2022, 9:23 p.m. UTC 
The code has not been touched since 2016 and numerous files still have
Python2 syntax code in them. This causes do_compile errors when
packaging a wheel (PEP-517 packaging).

Nothing in oe-core depends on python3-nose.

[YOCTO #14638]

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
---
 meta/conf/distro/include/maintainers.inc       |  1 -
 meta/recipes-devtools/python/python-nose.inc   | 18 ------------------
 .../python/python3-nose_1.3.7.bb               |  2 --
 3 files changed, 21 deletions(-)
 delete mode 100644 meta/recipes-devtools/python/python-nose.inc
 delete mode 100644 meta/recipes-devtools/python/python3-nose_1.3.7.bb

Comments

Khem Raj Feb. 22, 2022, 10:24 p.m. UTC | #1 
there are packages in meta-python which still need it

  meta-networking/recipes-connectivity/netplan/netplan_0.103.bb:RDEPENDS:${PN}
= "python3 python3-core python3-pyyaml python3-netifaces python3-nos
e python3-coverage python3-pycodestyle python3-pyflakes
util-linux-libuuid libnetplan"
  meta-python/recipes-devtools/python/python3-anyjson_0.3.3.bb:
${PYTHON_PN}-nose \
  meta-python/recipes-devtools/python/python3-blinker_1.4.bb:
${PYTHON_PN}-nose \
  meta-python/recipes-devtools/python/python3-oauthlib_3.2.0.bb:PACKAGECONFIG[test]
= ",,,${PYTHON_PN}-blinker ${PYTHON_PN}-cryptography ${PYTHON_P
N}-nose ${PYTHON_PN}-pyjwt"

I wonder if these recipes can either be also removed or made free of
nose module.

On Mon, Feb 21, 2022 at 1:25 PM Tim Orling <ticotimo@gmail.com> wrote:
>
> The code has not been touched since 2016 and numerous files still have
> Python2 syntax code in them. This causes do_compile errors when
> packaging a wheel (PEP-517 packaging).
>
> Nothing in oe-core depends on python3-nose.
>
> [YOCTO #14638]
>
> Signed-off-by: Tim Orling <tim.orling@konsulko.com>
> ---
>  meta/conf/distro/include/maintainers.inc       |  1 -
>  meta/recipes-devtools/python/python-nose.inc   | 18 ------------------
>  .../python/python3-nose_1.3.7.bb               |  2 --
>  3 files changed, 21 deletions(-)
>  delete mode 100644 meta/recipes-devtools/python/python-nose.inc
>  delete mode 100644 meta/recipes-devtools/python/python3-nose_1.3.7.bb
>
> diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
> index 7a65612b7c6..333685cd8b8 100644
> --- a/meta/conf/distro/include/maintainers.inc
> +++ b/meta/conf/distro/include/maintainers.inc
> @@ -616,7 +616,6 @@ RECIPE_MAINTAINER:pn-python3-mako = "Oleksandr Kravchuk <open.source@oleksandr-k
>  RECIPE_MAINTAINER:pn-python3-markdown = "Alexander Kanavin <alex.kanavin@gmail.com>"
>  RECIPE_MAINTAINER:pn-python3-markupsafe = "Richard Purdie <richard.purdie@linuxfoundation.org>"
>  RECIPE_MAINTAINER:pn-python3-more-itertools = "Tim Orling <tim.orling@konsulko.com>"
> -RECIPE_MAINTAINER:pn-python3-nose = "Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>"
>  RECIPE_MAINTAINER:pn-python3-numpy = "Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>"
>  RECIPE_MAINTAINER:pn-python3-packaging = "Tim Orling <tim.orling@konsulko.com>"
>  RECIPE_MAINTAINER:pn-python3-pathlib2 = "Tim Orling <tim.orling@konsulko.com>"
> diff --git a/meta/recipes-devtools/python/python-nose.inc b/meta/recipes-devtools/python/python-nose.inc
> deleted file mode 100644
> index 08c380d637c..00000000000
> --- a/meta/recipes-devtools/python/python-nose.inc
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -SUMMARY = "Extends Python unittest to make testing easier"
> -HOMEPAGE = "http://readthedocs.org/docs/nose/"
> -DESCRIPTION = "nose extends the test loading and running features of unittest, \
> -making it easier to write, find and run tests."
> -SECTION = "devel/python"
> -LICENSE = "LGPL-2.1-only"
> -LIC_FILES_CHKSUM = "file://lgpl.txt;md5=a6f89e2100d9b6cdffcea4f398e37343"
> -
> -SRC_URI[md5sum] = "4d3ad0ff07b61373d2cefc89c5d0b20b"
> -SRC_URI[sha256sum] = "f1bffef9cbc82628f6e7d7b40d7e255aefaa1adb6a1b1d26c69a8b79e6208a98"
> -
> -inherit pypi
> -
> -RDEPENDS:${PN} = "\
> -  ${PYTHON_PN}-unittest \
> -  "
> -
> -BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-devtools/python/python3-nose_1.3.7.bb b/meta/recipes-devtools/python/python3-nose_1.3.7.bb
> deleted file mode 100644
> index 13dbf96179a..00000000000
> --- a/meta/recipes-devtools/python/python3-nose_1.3.7.bb
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -inherit setuptools3
> -require python-nose.inc
> --
> 2.30.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#162108): https://lists.openembedded.org/g/openembedded-core/message/162108
> Mute This Topic: https://lists.openembedded.org/mt/89304054/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Tim Orling Feb. 22, 2022, 10:33 p.m. UTC | #2 
On Tue, Feb 22, 2022 at 2:24 PM Khem Raj <raj.khem@gmail.com> wrote:

> there are packages in meta-python which still need it
>
>   meta-networking/recipes-connectivity/netplan/netplan_0.103.bb:
> RDEPENDS:${PN}
> = "python3 python3-core python3-pyyaml python3-netifaces python3-nos
> e python3-coverage python3-pycodestyle python3-pyflakes
> util-linux-libuuid libnetplan"
>   meta-python/recipes-devtools/python/python3-anyjson_0.3.3.bb:
> ${PYTHON_PN}-nose \
>   meta-python/recipes-devtools/python/python3-blinker_1.4.bb:
> ${PYTHON_PN}-nose \
>   meta-python/recipes-devtools/python/python3-oauthlib_3.2.0.bb:
> PACKAGECONFIG[test]
> = ",,,${PYTHON_PN}-blinker ${PYTHON_PN}-cryptography ${PYTHON_P
> N}-nose ${PYTHON_PN}-pyjwt"
>
> I wonder if these recipes can either be also removed or made free of
> nose module.
>
>
I am thinking the same thing. While we could probably run 2to3 on the nose
plugins
that are the legacy python2 code, I would rather do the right thing.

In some cases, pytest can be a drop in replacement for nosetests, but not
always.

If anyone has any other ideas, please chime in. I am all ears.

On Mon, Feb 21, 2022 at 1:25 PM Tim Orling <ticotimo@gmail.com> wrote:
> >
> > The code has not been touched since 2016 and numerous files still have
> > Python2 syntax code in them. This causes do_compile errors when
> > packaging a wheel (PEP-517 packaging).
> >
> > Nothing in oe-core depends on python3-nose.
> >
> > [YOCTO #14638]
> >
> > Signed-off-by: Tim Orling <tim.orling@konsulko.com>
> > ---
> >  meta/conf/distro/include/maintainers.inc       |  1 -
> >  meta/recipes-devtools/python/python-nose.inc   | 18 ------------------
> >  .../python/python3-nose_1.3.7.bb               |  2 --
> >  3 files changed, 21 deletions(-)
> >  delete mode 100644 meta/recipes-devtools/python/python-nose.inc
> >  delete mode 100644 meta/recipes-devtools/python/python3-nose_1.3.7.bb
> >
> > diff --git a/meta/conf/distro/include/maintainers.inc
> b/meta/conf/distro/include/maintainers.inc
> > index 7a65612b7c6..333685cd8b8 100644
> > --- a/meta/conf/distro/include/maintainers.inc
> > +++ b/meta/conf/distro/include/maintainers.inc
> > @@ -616,7 +616,6 @@ RECIPE_MAINTAINER:pn-python3-mako = "Oleksandr
> Kravchuk <open.source@oleksandr-k
> >  RECIPE_MAINTAINER:pn-python3-markdown = "Alexander Kanavin <
> alex.kanavin@gmail.com>"
> >  RECIPE_MAINTAINER:pn-python3-markupsafe = "Richard Purdie <
> richard.purdie@linuxfoundation.org>"
> >  RECIPE_MAINTAINER:pn-python3-more-itertools = "Tim Orling <
> tim.orling@konsulko.com>"
> > -RECIPE_MAINTAINER:pn-python3-nose = "Oleksandr Kravchuk <
> open.source@oleksandr-kravchuk.com>"
> >  RECIPE_MAINTAINER:pn-python3-numpy = "Oleksandr Kravchuk <
> open.source@oleksandr-kravchuk.com>"
> >  RECIPE_MAINTAINER:pn-python3-packaging = "Tim Orling <
> tim.orling@konsulko.com>"
> >  RECIPE_MAINTAINER:pn-python3-pathlib2 = "Tim Orling <
> tim.orling@konsulko.com>"
> > diff --git a/meta/recipes-devtools/python/python-nose.inc
> b/meta/recipes-devtools/python/python-nose.inc
> > deleted file mode 100644
> > index 08c380d637c..00000000000
> > --- a/meta/recipes-devtools/python/python-nose.inc
> > +++ /dev/null
> > @@ -1,18 +0,0 @@
> > -SUMMARY = "Extends Python unittest to make testing easier"
> > -HOMEPAGE = "http://readthedocs.org/docs/nose/"
> > -DESCRIPTION = "nose extends the test loading and running features of
> unittest, \
> > -making it easier to write, find and run tests."
> > -SECTION = "devel/python"
> > -LICENSE = "LGPL-2.1-only"
> > -LIC_FILES_CHKSUM =
> "file://lgpl.txt;md5=a6f89e2100d9b6cdffcea4f398e37343"
> > -
> > -SRC_URI[md5sum] = "4d3ad0ff07b61373d2cefc89c5d0b20b"
> > -SRC_URI[sha256sum] =
> "f1bffef9cbc82628f6e7d7b40d7e255aefaa1adb6a1b1d26c69a8b79e6208a98"
> > -
> > -inherit pypi
> > -
> > -RDEPENDS:${PN} = "\
> > -  ${PYTHON_PN}-unittest \
> > -  "
> > -
> > -BBCLASSEXTEND = "native nativesdk"
> > diff --git a/meta/recipes-devtools/python/python3-nose_1.3.7.bb
> b/meta/recipes-devtools/python/python3-nose_1.3.7.bb
> > deleted file mode 100644
> > index 13dbf96179a..00000000000
> > --- a/meta/recipes-devtools/python/python3-nose_1.3.7.bb
> > +++ /dev/null
> > @@ -1,2 +0,0 @@
> > -inherit setuptools3
> > -require python-nose.inc
> > --
> > 2.30.2
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#162108):
> https://lists.openembedded.org/g/openembedded-core/message/162108
> > Mute This Topic: https://lists.openembedded.org/mt/89304054/1997914
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
diff mbox series

Patch

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index 7a65612b7c6..333685cd8b8 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -616,7 +616,6 @@  RECIPE_MAINTAINER:pn-python3-mako = "Oleksandr Kravchuk <open.source@oleksandr-k
 RECIPE_MAINTAINER:pn-python3-markdown = "Alexander Kanavin <alex.kanavin@gmail.com>"
 RECIPE_MAINTAINER:pn-python3-markupsafe = "Richard Purdie <richard.purdie@linuxfoundation.org>"
 RECIPE_MAINTAINER:pn-python3-more-itertools = "Tim Orling <tim.orling@konsulko.com>"
-RECIPE_MAINTAINER:pn-python3-nose = "Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>"
 RECIPE_MAINTAINER:pn-python3-numpy = "Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>"
 RECIPE_MAINTAINER:pn-python3-packaging = "Tim Orling <tim.orling@konsulko.com>"
 RECIPE_MAINTAINER:pn-python3-pathlib2 = "Tim Orling <tim.orling@konsulko.com>"
diff --git a/meta/recipes-devtools/python/python-nose.inc b/meta/recipes-devtools/python/python-nose.inc
deleted file mode 100644
index 08c380d637c..00000000000
--- a/meta/recipes-devtools/python/python-nose.inc
+++ /dev/null
@@ -1,18 +0,0 @@ 
-SUMMARY = "Extends Python unittest to make testing easier"
-HOMEPAGE = "http://readthedocs.org/docs/nose/"
-DESCRIPTION = "nose extends the test loading and running features of unittest, \
-making it easier to write, find and run tests."
-SECTION = "devel/python"
-LICENSE = "LGPL-2.1-only"
-LIC_FILES_CHKSUM = "file://lgpl.txt;md5=a6f89e2100d9b6cdffcea4f398e37343"
-
-SRC_URI[md5sum] = "4d3ad0ff07b61373d2cefc89c5d0b20b"
-SRC_URI[sha256sum] = "f1bffef9cbc82628f6e7d7b40d7e255aefaa1adb6a1b1d26c69a8b79e6208a98"
-
-inherit pypi
-
-RDEPENDS:${PN} = "\
-  ${PYTHON_PN}-unittest \
-  "
-
-BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-devtools/python/python3-nose_1.3.7.bb b/meta/recipes-devtools/python/python3-nose_1.3.7.bb
deleted file mode 100644
index 13dbf96179a..00000000000
--- a/meta/recipes-devtools/python/python3-nose_1.3.7.bb
+++ /dev/null
@@ -1,2 +0,0 @@ 
-inherit setuptools3
-require python-nose.inc