diff mbox series

[kirkstone,15/15] gcc-runtime: Pass -nostartfiles when building dummy libstdc++.so

Message ID 2bc86c029fb82ae572f6a89407ccfe332972568c.1658882276.git.steve@sakoman.com
State New, archived
Headers show
Series [kirkstone,01/15] lua: Backport fix for CVE-2022-33099 | expand

Commit Message

Steve Sakoman July 27, 2022, 12:40 a.m. UTC
From: Khem Raj <raj.khem@gmail.com>

This is a dummy shared object therefore reduce dependencies further by
not requiring the C startup files, we wont use this shared library for
anything useful anyway

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Pavel Zhukov <pavel.zhukov@huawei.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/recipes-devtools/gcc/gcc-runtime.inc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Jon Mason Aug. 1, 2022, 2:31 p.m. UTC | #1
Can we get this patch in ASAP?  meta-zephyr (and layers that use it)
have been broken for weeks now in kirkstone, and I can confirm that
this patch fixes the issue.

Thanks,
Jon

On Tue, Jul 26, 2022 at 8:41 PM Steve Sakoman <steve@sakoman.com> wrote:
>
> From: Khem Raj <raj.khem@gmail.com>
>
> This is a dummy shared object therefore reduce dependencies further by
> not requiring the C startup files, we wont use this shared library for
> anything useful anyway
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Pavel Zhukov <pavel.zhukov@huawei.com>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  meta/recipes-devtools/gcc/gcc-runtime.inc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc b/meta/recipes-devtools/gcc/gcc-runtime.inc
> index c85b5888d4..8074bf1025 100644
> --- a/meta/recipes-devtools/gcc/gcc-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
> @@ -68,8 +68,7 @@ do_configure () {
>         # libstdc++ isn't built yet so CXX would error not able to find it which breaks stdc++'s configure
>         # tests. Create a dummy empty lib for the purposes of configure.
>         mkdir -p ${WORKDIR}/dummylib
> -       touch ${WORKDIR}/dummylib/dummylib.c
> -       ${CC} ${WORKDIR}/dummylib/dummylib.c -shared -o ${WORKDIR}/dummylib/libstdc++.so
> +       ${CC} -x c /dev/null -nostartfiles -shared -o ${WORKDIR}/dummylib/libstdc++.so
>         for d in libgcc ${RUNTIMETARGET}; do
>                 echo "Configuring $d"
>                 rm -rf ${B}/${TARGET_SYS}/$d/
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#168538): https://lists.openembedded.org/g/openembedded-core/message/168538
> Mute This Topic: https://lists.openembedded.org/mt/92640672/3616920
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [jdmason@kudzu.us]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Steve Sakoman Aug. 1, 2022, 2:38 p.m. UTC | #2
On Mon, Aug 1, 2022 at 4:31 AM Jon Mason <jdmason@kudzu.us> wrote:
>
> Can we get this patch in ASAP?  meta-zephyr (and layers that use it)
> have been broken for weeks now in kirkstone, and I can confirm that
> this patch fixes the issue.

Pull request for this series was sent last Thursday.  IIRC Richard was
out of the office over the extended weekend, so perhaps he will get to
it today.

Steve

> On Tue, Jul 26, 2022 at 8:41 PM Steve Sakoman <steve@sakoman.com> wrote:
> >
> > From: Khem Raj <raj.khem@gmail.com>
> >
> > This is a dummy shared object therefore reduce dependencies further by
> > not requiring the C startup files, we wont use this shared library for
> > anything useful anyway
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > Signed-off-by: Pavel Zhukov <pavel.zhukov@huawei.com>
> > Signed-off-by: Steve Sakoman <steve@sakoman.com>
> > ---
> >  meta/recipes-devtools/gcc/gcc-runtime.inc | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc b/meta/recipes-devtools/gcc/gcc-runtime.inc
> > index c85b5888d4..8074bf1025 100644
> > --- a/meta/recipes-devtools/gcc/gcc-runtime.inc
> > +++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
> > @@ -68,8 +68,7 @@ do_configure () {
> >         # libstdc++ isn't built yet so CXX would error not able to find it which breaks stdc++'s configure
> >         # tests. Create a dummy empty lib for the purposes of configure.
> >         mkdir -p ${WORKDIR}/dummylib
> > -       touch ${WORKDIR}/dummylib/dummylib.c
> > -       ${CC} ${WORKDIR}/dummylib/dummylib.c -shared -o ${WORKDIR}/dummylib/libstdc++.so
> > +       ${CC} -x c /dev/null -nostartfiles -shared -o ${WORKDIR}/dummylib/libstdc++.so
> >         for d in libgcc ${RUNTIMETARGET}; do
> >                 echo "Configuring $d"
> >                 rm -rf ${B}/${TARGET_SYS}/$d/
> > --
> > 2.25.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#168538): https://lists.openembedded.org/g/openembedded-core/message/168538
> > Mute This Topic: https://lists.openembedded.org/mt/92640672/3616920
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [jdmason@kudzu.us]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
diff mbox series

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc b/meta/recipes-devtools/gcc/gcc-runtime.inc
index c85b5888d4..8074bf1025 100644
--- a/meta/recipes-devtools/gcc/gcc-runtime.inc
+++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
@@ -68,8 +68,7 @@  do_configure () {
 	# libstdc++ isn't built yet so CXX would error not able to find it which breaks stdc++'s configure
 	# tests. Create a dummy empty lib for the purposes of configure.
 	mkdir -p ${WORKDIR}/dummylib
-	touch ${WORKDIR}/dummylib/dummylib.c
-	${CC} ${WORKDIR}/dummylib/dummylib.c -shared -o ${WORKDIR}/dummylib/libstdc++.so
+	${CC} -x c /dev/null -nostartfiles -shared -o ${WORKDIR}/dummylib/libstdc++.so
 	for d in libgcc ${RUNTIMETARGET}; do
 		echo "Configuring $d"
 		rm -rf ${B}/${TARGET_SYS}/$d/