diff mbox series

[1/5] python3: don't copy from UNPACKDIR to WORKDIR

Message ID 20261116210435.4161338-1-ross.burton@arm.com
State New
Headers show
Series [1/5] python3: don't copy from UNPACKDIR to WORKDIR | expand

Commit Message

Ross Burton Nov. 16, 2026, 9:04 p.m. UTC
There's no need to copy files from UNPACKDIR to WORKDIR, we can just do
the work in UNPACKDIR.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-devtools/python/python3_3.14.10.bb | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Khem Raj Nov. 16, 2026, 9:09 p.m. UTC | #1
On Mon, Nov 16, 2026 at 1:04 PM Ross Burton via openembedded-core
<ross.burton=arm.com@lists.openembedded.org> wrote:

> There's no need to copy files from UNPACKDIR to WORKDIR, we can just do
> the work in UNPACKDIR.
>

IMO unpackdir is more of less what sources come from unpacking and patching
modifications happen in workdir. is it not the case ?


>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/recipes-devtools/python/python3_3.14.10.bb | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/meta/recipes-devtools/python/python3_3.14.10.bb
> b/meta/recipes-devtools/python/python3_3.14.10.bb
> index c50c4d4babc..765f93ddc66 100644
> --- a/meta/recipes-devtools/python/python3_3.14.10.bb
> +++ b/meta/recipes-devtools/python/python3_3.14.10.bb
> @@ -498,11 +498,8 @@ do_create_manifest() {
>      # e.g. BerkeleyDB is an optional build dependency so it may or may not
>      # be present, we must ensure it is.
>
> -    cp ${UNPACKDIR}/create_manifest3.py ${WORKDIR}
> -    cp ${UNPACKDIR}/python3-manifest.json ${WORKDIR}
> -    cp ${UNPACKDIR}/get_module_deps3.py ${WORKDIR}
> -    cd ${WORKDIR}
>      # This needs to be executed by python-native and NOT by HOST's python
> +    cd ${UNPACKDIR}
>      nativepython3 create_manifest3.py ${PYTHON_MAJMIN}
>      cp python3-manifest.json.new ${THISDIR}/python3/python3-manifest.json
>  }
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#250376):
> https://lists.openembedded.org/g/openembedded-core/message/250376
> Mute This Topic: https://lists.openembedded.org/mt/122302833/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta/recipes-devtools/python/python3_3.14.10.bb b/meta/recipes-devtools/python/python3_3.14.10.bb
index c50c4d4babc..765f93ddc66 100644
--- a/meta/recipes-devtools/python/python3_3.14.10.bb
+++ b/meta/recipes-devtools/python/python3_3.14.10.bb
@@ -498,11 +498,8 @@  do_create_manifest() {
     # e.g. BerkeleyDB is an optional build dependency so it may or may not
     # be present, we must ensure it is.
 
-    cp ${UNPACKDIR}/create_manifest3.py ${WORKDIR}
-    cp ${UNPACKDIR}/python3-manifest.json ${WORKDIR}
-    cp ${UNPACKDIR}/get_module_deps3.py ${WORKDIR}
-    cd ${WORKDIR}
     # This needs to be executed by python-native and NOT by HOST's python
+    cd ${UNPACKDIR}
     nativepython3 create_manifest3.py ${PYTHON_MAJMIN}
     cp python3-manifest.json.new ${THISDIR}/python3/python3-manifest.json
 }