diff mbox series

slang: Fix link with lld

Message ID 20261107193744.1040700-1-khem.raj@oss.qualcomm.com
State New
Headers show
Series slang: Fix link with lld | expand

Commit Message

Khem Raj Nov. 7, 2026, 7:37 p.m. UTC 
src/slang.ver lists SLang_Rline_Quit, which is not defined anywhere.
lld defaults to --no-undefined-version and fails:

  ld.lld: error: version script assignment of 'SLANG2' to symbol
  'SLang_Rline_Quit' failed: symbol not defined

meta-clang worked around this with -Wl,--undefined-version for slang;
backport the upstream fix instead, which drops the entry. GNU ld ignored
it, so the exported symbol set is unchanged.

Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 ...ve-undefined-symbol-SLang_Rline_Quit.patch | 32 +++++++++++++++++++
 meta/recipes-extended/slang/slang_2.3.3.bb    |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 meta/recipes-extended/slang/slang/0001-src-slang.ver-Remove-undefined-symbol-SLang_Rline_Quit.patch
diff mbox series

Patch

diff --git a/meta/recipes-extended/slang/slang/0001-src-slang.ver-Remove-undefined-symbol-SLang_Rline_Quit.patch b/meta/recipes-extended/slang/slang/0001-src-slang.ver-Remove-undefined-symbol-SLang_Rline_Quit.patch
new file mode 100644
index 0000000000..30458ad721
--- /dev/null
+++ b/meta/recipes-extended/slang/slang/0001-src-slang.ver-Remove-undefined-symbol-SLang_Rline_Quit.patch
@@ -0,0 +1,32 @@ 
+From eb22c5c3cb253bd4c6ad20d73f76dc7105ed0f3d Mon Sep 17 00:00:00 2001
+From: "John E. Davis" <jed@jedsoft.org>
+Date: Thu, 1 Feb 2024 13:18:03 -0500
+Subject: [PATCH] src/slang.ver: Remove the undefined symbol SLang_Rline_Quit
+
+SLang_Rline_Quit is listed in the version script but not defined
+anywhere. lld rejects this by default (--no-undefined-version):
+
+  ld.lld: error: version script assignment of 'SLANG2' to symbol
+  'SLang_Rline_Quit' failed: symbol not defined
+
+Only the src/slang.ver hunk of the upstream commit is taken; the rest
+is the pre-release version bump and changes.txt.
+
+Upstream-Status: Backport [git://git.jedsoft.org/git/slang.git eb22c5c3cb253bd4c6ad20d73f76dc7105ed0f3d]
+Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
+---
+ src/slang.ver | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/src/slang.ver b/src/slang.ver
+index aa030c9..4b01f9f 100644
+--- a/src/slang.ver
++++ b/src/slang.ver
+@@ -70,7 +70,6 @@ SLANG2 {
+ 		SLang_Last_Key_Char;
+ 		SLang_Load_File_Hook;
+ 		SLang_Num_Function_Args;
+-		SLang_Rline_Quit;
+ 		SLang_TT_Baud_Rate;
+ 		SLang_TT_Read_FD;
+ 		SLang_TT_Write_FD;
diff --git a/meta/recipes-extended/slang/slang_2.3.3.bb b/meta/recipes-extended/slang/slang_2.3.3.bb
index 3f365cb3cf..67d1d62eba 100644
--- a/meta/recipes-extended/slang/slang_2.3.3.bb
+++ b/meta/recipes-extended/slang/slang_2.3.3.bb
@@ -20,6 +20,7 @@  SRC_URI = "http://www.jedsoft.org/releases/${BPN}/${BP}.tar.bz2 \
            file://test-add-output-in-the-format-result-testname.patch \
            file://terminfo_fixes.patch \
            file://array_test.patch \
+           file://0001-src-slang.ver-Remove-undefined-symbol-SLang_Rline_Quit.patch \
            file://run-ptest \
           "