| Message ID | 20261106141408.2757659-1-peter@berginkonsult.se |
|---|---|
| State | Under Review |
| Headers | show |
| Series | oe-selftest: rootfspostcommandstests: fix check for default sort command | expand |
diff --git a/meta/lib/oeqa/selftest/cases/rootfspostcommandstests.py b/meta/lib/oeqa/selftest/cases/rootfspostcommandstests.py index 44e2c09a6f..46940a2eb1 100644 --- a/meta/lib/oeqa/selftest/cases/rootfspostcommandstests.py +++ b/meta/lib/oeqa/selftest/cases/rootfspostcommandstests.py @@ -34,7 +34,7 @@ class ShadowUtilsTidyFiles(OESelftestTestCase): test_image) passwd_postprocess_cmd = vars["SORT_PASSWD_POSTPROCESS_COMMAND"] self.assertIsNotNone(passwd_postprocess_cmd) - if (passwd_postprocess_cmd.strip() != 'tidy_shadowutils_files;'): + if (passwd_postprocess_cmd.strip() != 'tidy_shadowutils_files'): raise unittest.SkipTest("Testcase skipped as 'tidy_shadowutils_files' " "rootfs post process command is not the set SORT_PASSWD_POSTPROCESS_COMMAND.")
Since commit [1] SORT_PASSWD_POSTPROCESS_COMMAND defaults to "tidy_shadowutils_files" without the trailing ';', so the check never matched and both tests in ShadowUtilsTidyFiles have been skipped ever since. The yocto-4.3 regression report [2] shows both going from PASSED to SKIPPED. Fix the check so the tests run again. [1] https://git.openembedded.org/openembedded-core/commit/?id=c3365dfd9ddd7fbe70b62e0f11166e57a8ca6f73 [2] https://downloads.yoctoproject.org/releases/yocto/yocto-4.3/testresults/testresult-regressions-report.txt AI-Generated: Uses Claude Code (Claude Opus 5.5) Fixes: c3365dfd9ddd ("classes: Drop ';' delimiter from ROOTFS/IMAGE*COMMAND variables") Signed-off-by: Peter Bergin <peter@berginkonsult.se> --- meta/lib/oeqa/selftest/cases/rootfspostcommandstests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)