diff mbox series

[scarthgap,v2] connman: fix syslog identity with glibc

Message ID 20261013132308.3742518-1-gael.portay+rtone@gmail.com
State New
Headers show
Series [scarthgap,v2] connman: fix syslog identity with glibc | expand

Commit Message

Gaël PORTAY Oct. 13, 2026, 1:23 p.m. UTC 
The patch 0001-src-log.c-Include-libgen.h-for-basename-API.patch changes
how the syslog's ident string is handled to fix a build issue with musl.

It passes a locally allocated string to openlog(), which introduces a
regression with glibc, as glibc does not make an internal copy of the
ident string[1], unlike musl[2].

As documented in the syslog(3) man page[3], the ident string passed to
openlog() may be stored as-is. Modifying the string or allowing it to
cease to exist can therefore lead to unexpected behavior or undefined
results.

This removes 0001-src-log.c-Include-libgen.h-for-basename-API.patch from
SRC_URI for glibc by moving it to the libc-musl override, ensuring that
it is applied only when building with musl.

Note: The patch was submitted upstream to connman but was never
merged[4]. It was also removed from oe-core when connman was upgraded to
version 1.43[5].

Fixes:

	Sep  7 06:10:36 qemux86-64 daemon.info ^A[776]: Connection Manager version 1.42

This fixes commit d0139bcbe0 (connman: Fix build with musl).

[1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=misc/syslog.c;h=b7414e7b43a510342273bece335b4258e8754905;hb=47dd7e0dacf50c740b04c78d3f85fbf983d53aba#l338
[2]: https://git.musl-libc.org/cgit/musl/tree/src/misc/syslog.c?h=v1.2.4#n64
[3]: https://linux.die.net/man/3/syslog
[4]: https://lore.kernel.org/connman/0caf957f-e046-4453-a8ae-fd6c994ac95d@gmail.com/
[5]: https://github.com/openembedded/openembedded-core/commit/467d28f5d243d821722cf8dcdbb9675a2820cd4f

Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
---
Changes since v1:
 - Move file 0001-src-log.c-Include-libgen.h-for-basename-API.patch to
   libc-musl override (instead of moving incorrect file
   0001-vpn-Adding-support-for-latest-pppd-2.5.0-release.patch)
 - Entire message reword
 - Update references using oe-core instead of poky

 meta/recipes-connectivity/connman/connman_1.42.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/meta/recipes-connectivity/connman/connman_1.42.bb b/meta/recipes-connectivity/connman/connman_1.42.bb
index 9b3abbe258..4fb7bf6a35 100644
--- a/meta/recipes-connectivity/connman/connman_1.42.bb
+++ b/meta/recipes-connectivity/connman/connman_1.42.bb
@@ -6,12 +6,13 @@  SRC_URI = "${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
            file://connman \
            file://no-version-scripts.patch \
            file://0001-vpn-Adding-support-for-latest-pppd-2.5.0-release.patch \
-           file://0001-src-log.c-Include-libgen.h-for-basename-API.patch \
            file://CVE-2025-32743.patch \
            file://CVE-2025-32366.patch \
            "
 
-SRC_URI:append:libc-musl = " file://0002-resolve-musl-does-not-implement-res_ninit.patch"
+SRC_URI:append:libc-musl = " file://0001-src-log.c-Include-libgen.h-for-basename-API.patch \
+                             file://0002-resolve-musl-does-not-implement-res_ninit.patch \
+                           "
 
 SRC_URI[sha256sum] = "a3e6bae46fc081ef2e9dae3caa4f7649de892c3de622c20283ac0ca81423c2aa"