diff mbox series

[scarthgap] connman: fix syslog identity with glibc

Message ID 20260929093009.847328-1-gael.portay+rtone@gmail.com
State New
Headers show
Series [scarthgap] connman: fix syslog identity with glibc | expand

Commit Message

Gaël PORTAY Sept. 29, 2026, 9:30 a.m. UTC 
The connman syslog patch modifies the handling of the ident string to
solve a build issue with musl. This introduces a regression with glibc
that does not make an internally copy of the indent string[1], while
musl copies it[2]. Thus, that change is unsafe to apply in the glibc
world.

Also, syslog(3)[3] man page tells:

	NOTES

	The argument ident in the call of openlog() is probably stored
	as-is. Thus, if the string it points to is changed, syslog() may
	start prepending the changed string, and if the string it points
	to ceases to exist, the results are undefined. Most portable is
	to use a string constant.

This removes 0001-src-log.c-Include-libgen.h-for-basename-API.patch[4]
from the SRC_URI if libc-glibc overrides so that it is not applied when
using glibc.

Note: The patch was submitted to connamn, and was never get merged[5].
Moreover the patch was removed from poky after bumping to 1.43[6].

Fixes:

	Sep  7 06:10:36 qemux86-64 daemon.info ^A[776]: Connection Manager version 1.42

This fixes commit 992d59564b84333740e6465ec696238274b73938.

[1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=misc/syslog.c;h=b7414e7b43a510342273bece335b4258e8754905;hb=47dd7e0dacf50c740b04c78d3f85fbf983d53aba#l338
[2]: https://git.musl-libc.org/cgit/musl/tree/src/misc/syslog.c?h=v1.2.4#n64
[3]: https://linux.die.net/man/3/syslog
[4]: https://git.yoctoproject.org/poky/tree/meta/recipes-connectivity/connman/connman/0001-src-log.c-Include-libgen.h-for-basename-API.patch?h=scarthgap
[5]: https://lore.kernel.org/connman/0caf957f-e046-4453-a8ae-fd6c994ac95d@gmail.com/
[6]: https://github.com/openembedded/openembedded-core/commit/467d28f5d243d821722cf8dcdbb9675a2820cd4f

Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
---
 meta/recipes-connectivity/connman/connman_1.42.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/meta/recipes-connectivity/connman/connman_1.42.bb b/meta/recipes-connectivity/connman/connman_1.42.bb
index 9b3abbe258..5c8bdd43f2 100644
--- a/meta/recipes-connectivity/connman/connman_1.42.bb
+++ b/meta/recipes-connectivity/connman/connman_1.42.bb
@@ -5,13 +5,14 @@  SRC_URI = "${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
            file://0001-connman.service-stop-systemd-resolved-when-we-use-co.patch \
            file://connman \
            file://no-version-scripts.patch \
-           file://0001-vpn-Adding-support-for-latest-pppd-2.5.0-release.patch \
            file://0001-src-log.c-Include-libgen.h-for-basename-API.patch \
            file://CVE-2025-32743.patch \
            file://CVE-2025-32366.patch \
            "
 
-SRC_URI:append:libc-musl = " file://0002-resolve-musl-does-not-implement-res_ninit.patch"
+SRC_URI:append:libc-musl = " file://0001-vpn-Adding-support-for-latest-pppd-2.5.0-release.patch \
+                             file://0002-resolve-musl-does-not-implement-res_ninit.patch \
+                           "
 
 SRC_URI[sha256sum] = "a3e6bae46fc081ef2e9dae3caa4f7649de892c3de622c20283ac0ca81423c2aa"