diff mbox series

[2/2] gptfdisk: remove recipe

Message ID 20260811153619.2048639-2-ross.burton@arm.com
State Under Review
Headers show
Series [1/2] wic: remove gptfdisk dependency | expand

Commit Message

Ross Burton Aug. 11, 2026, 3:36 p.m. UTC
There are no dependencies on this recipe in oe-core or meta-oe now, as
the standard fdisk command in util-linux has both a scriptable frontend
and supports GPT partition tables.

Also the last release was in 2024 and there's very little activity
upstream.

As such, remove the recipe.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/conf/distro/include/maintainers.inc      |  1 -
 ...gptcurses-correctly-include-curses.h.patch | 27 --------------
 .../recipes-devtools/fdisk/gptfdisk_1.0.10.bb | 35 -------------------
 3 files changed, 63 deletions(-)
 delete mode 100644 meta/recipes-devtools/fdisk/gptfdisk/0001-gptcurses-correctly-include-curses.h.patch
 delete mode 100644 meta/recipes-devtools/fdisk/gptfdisk_1.0.10.bb

Comments

Mathieu Dubois-Briand Aug. 11, 2026, 6:48 p.m. UTC | #1
On Tue Aug 11, 2026 at 5:36 PM CEST, Ross Burton via lists.openembedded.org wrote:
> There are no dependencies on this recipe in oe-core or meta-oe now, as
> the standard fdisk command in util-linux has both a scriptable frontend
> and supports GPT partition tables.
>
> Also the last release was in 2024 and there's very little activity
> upstream.
>
> As such, remove the recipe.
>

And break the build :)

Looks like we do have a dependency on gptfdisk-native. Maybe this match
in meta-yocto?

meta-yocto-bsp/conf/machine/include/genericx86-common.inc:do_image_wic[depends] += "gptfdisk-native:do_populate_sysroot"

Here is the error:
ERROR: Nothing PROVIDES 'gptfdisk-native'. Close matches:
  gperf-native
  gtk+3-native
  gtk4-native
ERROR: Nothing RPROVIDES 'core-image-sato'
No eligible RPROVIDERs exist for 'core-image-sato'
NOTE: Runtime target 'core-image-sato' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['core-image-sato']
ERROR: Nothing RPROVIDES 'core-image-sato-sdk'
No eligible RPROVIDERs exist for 'core-image-sato-sdk'
NOTE: Runtime target 'core-image-sato-sdk' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['core-image-sato-sdk']
ERROR: Nothing RPROVIDES 'core-image-minimal'
No eligible RPROVIDERs exist for 'core-image-minimal'
NOTE: Runtime target 'core-image-minimal' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['core-image-minimal']
ERROR: Nothing RPROVIDES 'core-image-full-cmdline'
No eligible RPROVIDERs exist for 'core-image-full-cmdline'
NOTE: Runtime target 'core-image-full-cmdline' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['core-image-full-cmdline']

https://autobuilder.yoctoproject.org/valkyrie/#/builders/4/builds/4388
https://autobuilder.yoctoproject.org/valkyrie/#/builders/19/builds/4362
https://autobuilder.yoctoproject.org/valkyrie/#/builders/65/builds/4336
...

Thanks,
Mathieu
Ross Burton Aug. 11, 2026, 7:45 p.m. UTC | #2
On 11 Aug 2026, at 19:48, Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> wrote:
>> As such, remove the recipe.
> 
> And break the build :)
> 
> Looks like we do have a dependency on gptfdisk-native. Maybe this match
> in meta-yocto?

Sorry, I didn’t notice that one, patch just sent to poky@.

Ross
diff mbox series

Patch

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index c5b701c2447..f30aa06e15d 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -242,7 +242,6 @@  RECIPE_MAINTAINER:pn-go-runtime = "Khem Raj <raj.khem@gmail.com>"
 RECIPE_MAINTAINER:pn-gobject-introspection = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-gperf = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-gpgme = "Hongxu Jia <hongxu.jia@windriver.com>"
-RECIPE_MAINTAINER:pn-gptfdisk = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-graphene = "Markus Volk <f_l_k@t-online.de>"
 RECIPE_MAINTAINER:pn-grep = "Denys Dmytriyenko <denis@denix.org>"
 RECIPE_MAINTAINER:pn-groff = "Hongxu Jia <hongxu.jia@windriver.com>"
diff --git a/meta/recipes-devtools/fdisk/gptfdisk/0001-gptcurses-correctly-include-curses.h.patch b/meta/recipes-devtools/fdisk/gptfdisk/0001-gptcurses-correctly-include-curses.h.patch
deleted file mode 100644
index 011eec36f98..00000000000
--- a/meta/recipes-devtools/fdisk/gptfdisk/0001-gptcurses-correctly-include-curses.h.patch
+++ /dev/null
@@ -1,27 +0,0 @@ 
-From 510d0d27f90dfb1c4afd0722580bb8a828b52b7f Mon Sep 17 00:00:00 2001
-From: Alexander Kanavin <alex.kanavin@gmail.com>
-Date: Mon, 30 Mar 2020 17:11:19 +0200
-Subject: [PATCH] gptcurses: correctly include curses.h
-
-Upstream-Status: Inappropriate [oe-core specific]
-Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
----
- gptcurses.cc | 4 ----
- 1 file changed, 4 deletions(-)
-
-diff --git a/gptcurses.cc b/gptcurses.cc
-index b476700..476fc43 100644
---- a/gptcurses.cc
-+++ b/gptcurses.cc
-@@ -23,11 +23,7 @@
- #include <iostream>
- #include <string>
- #include <sstream>
--#if defined (__APPLE__) || (__FreeBSD__)
- #include <ncurses.h>
--#else
--#include <ncursesw/ncurses.h>
--#endif
- #include "gptcurses.h"
- #include "support.h"
- 
diff --git a/meta/recipes-devtools/fdisk/gptfdisk_1.0.10.bb b/meta/recipes-devtools/fdisk/gptfdisk_1.0.10.bb
deleted file mode 100644
index ba891931aca..00000000000
--- a/meta/recipes-devtools/fdisk/gptfdisk_1.0.10.bb
+++ /dev/null
@@ -1,35 +0,0 @@ 
-SUMMARY = "Utility for modifying GPT disk partitioning"
-DESCRIPTION = "GPT fdisk is a disk partitioning tool loosely modeled on Linux fdisk, but used for modifying GUID Partition Table (GPT) disks. The related FixParts utility fixes some common problems on Master Boot Record (MBR) disks."
-HOMEPAGE = "https://sourceforge.net/projects/gptfdisk/"
-
-LICENSE = "GPL-2.0-only"
-LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
-
-DEPENDS = "util-linux"
-
-SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${PV}/${BP}.tar.gz \
-           file://0001-gptcurses-correctly-include-curses.h.patch \
-           "
-SRC_URI[sha256sum] = "2abed61bc6d2b9ec498973c0440b8b804b7a72d7144069b5a9209b2ad693a282"
-
-UPSTREAM_CHECK_URI = "http://sourceforge.net/projects/gptfdisk/files/gptfdisk/"
-UPSTREAM_CHECK_REGEX = "/gptfdisk/(?P<pver>(\d+[\.\-_]*)+)/"
-
-EXTRA_OEMAKE = "'CC=${CC}' 'CXX=${CXX}' gdisk fixparts ${PACKAGECONFIG_CONFARGS}"
-
-PACKAGECONFIG ??= "ncurses popt"
-PACKAGECONFIG[ncurses] = "cgdisk,,ncurses"
-PACKAGECONFIG[popt] = "sgdisk,,popt"
-
-do_install() {
-    install -d ${D}${sbindir}
-    for f in cgdisk sgdisk; do
-        if [ -x $f ]; then
-            install -m 0755 $f ${D}${sbindir}
-        fi
-    done
-    install -m 0755 gdisk ${D}${sbindir}
-    install -m 0755 fixparts ${D}${sbindir}
-}
-
-BBCLASSEXTEND = "native nativesdk"