| Message ID | 20260811104428.1875677-2-ross.burton@arm.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [1/2] classes/ptest-cargo: use oe.path.join instead of os.path.join | expand |
diff --git a/meta/classes-recipe/ptest-cargo.bbclass b/meta/classes-recipe/ptest-cargo.bbclass index f4c881c2f9d..2e008b306a8 100644 --- a/meta/classes-recipe/ptest-cargo.bbclass +++ b/meta/classes-recipe/ptest-cargo.bbclass @@ -95,6 +95,8 @@ python do_install_ptest_cargo() { test_paths = [] for test_bin in test_bins: + # Note that we can't strip the hash from the filename as some packages + # (eg librsvg) have multiple binaries with the same prefix. shutil.copy2(test_bin, ptest_dir) test_paths.append(os.path.join(ptest_path, os.path.basename(test_bin)))
Add a comment to avoid someone else in the future wasting their time by having the the idea of stripping the cargo hash from the test binary filenames. Some packages, notably librsvg, build multiple tests with the same base name that are differentiated by the hash: primitives-3fd9d71b0a55e20a reference-00d9b406d910a645 render_crash-c88a2b880ba97e09 rsvg_convert-b43bd2236753f43d rsvg_convert-eef250e6c0174413 rsvg_convert-f70976dd6cda88b0 rsvg-eec8e799568381a3 Signed-off-by: Ross Burton <ross.burton@arm.com> --- meta/classes-recipe/ptest-cargo.bbclass | 2 ++ 1 file changed, 2 insertions(+)