| Message ID | 20260806162730.352060-1-ross.burton@arm.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [1/3] cross-localedef-native: prune patch list | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/1-3-cross-localedef-native-prune-patch-list.patch FAIL: test src uri left files: Patches not removed from tree. Remove them and amend the submitted mbox (test_metadata.TestMetadata.test_src_uri_left_files) PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files) PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test auh changelog truncation notice (test_mbox.TestMbox.test_auh_changelog_truncation_notice) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test CVE tag format: No new source patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new source patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new source patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
The fixes were needed for build only pieces. It does build fair bit of glibc infra before building localedef. But its good to review it from time to time. If there are no build issues we should largely be OK with this patch On Thu, Aug 6, 2026, 9:27 AM Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote: > The cross-localedef-native recipe builds on top of glibc and drops in an > autoconf tree to build just localedef. For some reason we're applying a > partial subset of glibc patches that do not impact the localedef build > at all, for example adding documentation or fixing nscd. > > Remove patches and other assignments that don't impact the build of > localedef. > > Signed-off-by: Ross Burton <ross.burton@arm.com> > --- > meta/recipes-core/glibc/cross-localedef-native_2.44.bb | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/meta/recipes-core/glibc/cross-localedef-native_2.44.bb > b/meta/recipes-core/glibc/cross-localedef-native_2.44.bb > index cf48b9c83bf..47018ff23b4 100644 > --- a/meta/recipes-core/glibc/cross-localedef-native_2.44.bb > +++ b/meta/recipes-core/glibc/cross-localedef-native_2.44.bb > @@ -25,13 +25,8 @@ SRC_URI = > "${GLIBC_GIT_URI};branch=${SRCBRANCH};name=glibc \ > > file://0001-localedef-Add-hardlink-resolver-from-util-linux.patch \ > > file://0002-localedef-fix-ups-hardlink-to-make-it-compile.patch \ > \ > - > file://0009-eglibc-Cross-building-and-testing-instructions.patch \ > - file://0010-eglibc-Help-bootstrap-cross-toolchain.patch \ > - file://0011-eglibc-Resolve-__fpscr_values-on-SH4.patch \ > > file://0012-eglibc-Forward-port-cross-locale-generation-support.patch \ > > file://0013-localedef-add-to-archive-uses-a-hard-coded-locale-pa.patch \ > - > file://0016-Replace-echo-with-printf-builtin-in-nscd-init-script.patch \ > - > file://0018-timezone-Make-shell-interpreter-overridable-in-tzsel.patch \ > " > # Makes for a rather long rev (22 characters), but... > # > @@ -39,10 +34,6 @@ SRCREV_FORMAT = "glibc_localedef" > > EXTRA_OECONF = "--with-glibc=${S}" > > -# We do not need bash to run tzselect script, the default is to use > -# bash but it can be configured by setting KSHELL Makefile variable > -EXTRA_OEMAKE += "KSHELL=/bin/sh" > - > CFLAGS += "-fgnu89-inline -std=gnu99 -DIS_IN\(x\)='0'" > > do_install() { > -- > 2.43.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#242957): > https://lists.openembedded.org/g/openembedded-core/message/242957 > Mute This Topic: https://lists.openembedded.org/mt/120629342/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On 6 Aug 2026, at 18:27, Khem Raj <raj.khem@gmail.com> wrote: > > The fixes were needed for build only pieces. It does build fair bit of glibc infra before building localedef. But its good to review it from time to time. If there are no build issues we should largely be OK with this patch I ended up looking at buildroot’s way to build localedef and it’s a bit neater, I wonder if we should share patches… Ross
diff --git a/meta/recipes-core/glibc/cross-localedef-native_2.44.bb b/meta/recipes-core/glibc/cross-localedef-native_2.44.bb index cf48b9c83bf..47018ff23b4 100644 --- a/meta/recipes-core/glibc/cross-localedef-native_2.44.bb +++ b/meta/recipes-core/glibc/cross-localedef-native_2.44.bb @@ -25,13 +25,8 @@ SRC_URI = "${GLIBC_GIT_URI};branch=${SRCBRANCH};name=glibc \ file://0001-localedef-Add-hardlink-resolver-from-util-linux.patch \ file://0002-localedef-fix-ups-hardlink-to-make-it-compile.patch \ \ - file://0009-eglibc-Cross-building-and-testing-instructions.patch \ - file://0010-eglibc-Help-bootstrap-cross-toolchain.patch \ - file://0011-eglibc-Resolve-__fpscr_values-on-SH4.patch \ file://0012-eglibc-Forward-port-cross-locale-generation-support.patch \ file://0013-localedef-add-to-archive-uses-a-hard-coded-locale-pa.patch \ - file://0016-Replace-echo-with-printf-builtin-in-nscd-init-script.patch \ - file://0018-timezone-Make-shell-interpreter-overridable-in-tzsel.patch \ " # Makes for a rather long rev (22 characters), but... # @@ -39,10 +34,6 @@ SRCREV_FORMAT = "glibc_localedef" EXTRA_OECONF = "--with-glibc=${S}" -# We do not need bash to run tzselect script, the default is to use -# bash but it can be configured by setting KSHELL Makefile variable -EXTRA_OEMAKE += "KSHELL=/bin/sh" - CFLAGS += "-fgnu89-inline -std=gnu99 -DIS_IN\(x\)='0'" do_install() {
The cross-localedef-native recipe builds on top of glibc and drops in an autoconf tree to build just localedef. For some reason we're applying a partial subset of glibc patches that do not impact the localedef build at all, for example adding documentation or fixing nscd. Remove patches and other assignments that don't impact the build of localedef. Signed-off-by: Ross Burton <ross.burton@arm.com> --- meta/recipes-core/glibc/cross-localedef-native_2.44.bb | 9 --------- 1 file changed, 9 deletions(-)