| Message ID | 20260722121119.888611-1-emailaddress.ashish@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [scarthgap] package.bbclass: fix execution order bug in emit_pkgdata | expand |
Hi Yoann , This is an bug fix patch which fixes the emit_pkgdata order The same have been merged in master at https://git.openembedded.org/openembedded-core-contrib/commit/?h=ross/wip/nasm&id=aa85baff9ebdd3f932811c3b43d1918c38373cb9 Request to take this patch in scarthgap Thanks , Ashish
On Wed Jul 22, 2026 at 2:15 PM CEST, AshishKumar Mishra via lists.openembedded.org wrote: > Hi Yoann , > > This is an bug fix patch which fixes the emit_pkgdata order > The same have been merged in master at https://git.openembedded.org/openembedded-core-contrib/commit/?h=ross/wip/nasm&id=aa85baff9ebdd3f932811c3b43d1918c38373cb9 > > Request to take this patch in scarthgap Hello, This also need backporting to wrynose, right? If that's the case, please send a cherry-pick request (if trivial) or a backported patch. Thanks!
Hi Yoann , I tested on Scarthgap today and hence shared for it Will create an patch for Wrynose and share after testing it once. In meantime, can you please take this in consideration for Scarthgap? Or as an process i should send Wrynose. So accordingly from next patch onwards, will follow the same. Thanks , Ashish On Wed, Jul 22, 2026, 5:50 PM Yoann Congal via lists.openembedded.org <yoann.congal=smile.fr@lists.openembedded.org> wrote: > On Wed Jul 22, 2026 at 2:15 PM CEST, AshishKumar Mishra via > lists.openembedded.org wrote: > > Hi Yoann , > > > > This is an bug fix patch which fixes the emit_pkgdata order > > The same have been merged in master at > https://git.openembedded.org/openembedded-core-contrib/commit/?h=ross/wip/nasm&id=aa85baff9ebdd3f932811c3b43d1918c38373cb9 > > > > Request to take this patch in scarthgap > > Hello, > > This also need backporting to wrynose, right? > If that's the case, please send a cherry-pick request (if trivial) or a > backported patch. > > Thanks! > -- > Yoann Congal > Smile ECS > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#241665): > https://lists.openembedded.org/g/openembedded-core/message/241665 > Mute This Topic: https://lists.openembedded.org/mt/120392420/1334323 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > emailaddress.ashish@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
Le mer. 22 juil. 2026 à 14:25, Ashish Mishra <emailaddress.ashish@gmail.com> a écrit : > Hi Yoann , > > I tested on Scarthgap today and hence shared for it > > Will create an patch for Wrynose and share after testing it once. > > In meantime, can you please take this in consideration for Scarthgap? > Or as an process i should send Wrynose. > > So accordingly from next patch onwards, will follow the same. > As a policy, I can't accept a patch for scarthgap if it does not have a wrynose equivalent. So yes, you should send the wrynose patch. Then, I'll consider this one for scarthgap. Regards, > > Thanks , > Ashish > > > On Wed, Jul 22, 2026, 5:50 PM Yoann Congal via lists.openembedded.org > <yoann.congal=smile.fr@lists.openembedded.org> wrote: > >> On Wed Jul 22, 2026 at 2:15 PM CEST, AshishKumar Mishra via >> lists.openembedded.org wrote: >> > Hi Yoann , >> > >> > This is an bug fix patch which fixes the emit_pkgdata order >> > The same have been merged in master at >> https://git.openembedded.org/openembedded-core-contrib/commit/?h=ross/wip/nasm&id=aa85baff9ebdd3f932811c3b43d1918c38373cb9 >> > >> > Request to take this patch in scarthgap >> >> Hello, >> >> This also need backporting to wrynose, right? >> If that's the case, please send a cherry-pick request (if trivial) or a >> backported patch. >> >> Thanks! >> -- >> Yoann Congal >> Smile ECS >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#241665): >> https://lists.openembedded.org/g/openembedded-core/message/241665 >> Mute This Topic: https://lists.openembedded.org/mt/120392420/1334323 >> Group Owner: openembedded-core+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ >> emailaddress.ashish@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> >>
Ok , will work on Wrynose. Thanks for sharing the details , will take care of this process going ahead On Wed, Jul 22, 2026, 6:02 PM Yoann Congal <yoann.congal@smile.fr> wrote: > Le mer. 22 juil. 2026 à 14:25, Ashish Mishra < > emailaddress.ashish@gmail.com> a écrit : > >> Hi Yoann , >> >> I tested on Scarthgap today and hence shared for it >> >> Will create an patch for Wrynose and share after testing it once. >> >> In meantime, can you please take this in consideration for Scarthgap? >> Or as an process i should send Wrynose. >> >> So accordingly from next patch onwards, will follow the same. >> > > As a policy, I can't accept a patch for scarthgap if it does not have a > wrynose equivalent. > So yes, you should send the wrynose patch. Then, I'll consider this one > for scarthgap. > > Regards, > > >> >> Thanks , >> Ashish >> >> >> On Wed, Jul 22, 2026, 5:50 PM Yoann Congal via lists.openembedded.org >> <yoann.congal=smile.fr@lists.openembedded.org> wrote: >> >>> On Wed Jul 22, 2026 at 2:15 PM CEST, AshishKumar Mishra via >>> lists.openembedded.org wrote: >>> > Hi Yoann , >>> > >>> > This is an bug fix patch which fixes the emit_pkgdata order >>> > The same have been merged in master at >>> https://git.openembedded.org/openembedded-core-contrib/commit/?h=ross/wip/nasm&id=aa85baff9ebdd3f932811c3b43d1918c38373cb9 >>> > >>> > Request to take this patch in scarthgap >>> >>> Hello, >>> >>> This also need backporting to wrynose, right? >>> If that's the case, please send a cherry-pick request (if trivial) or a >>> backported patch. >>> >>> Thanks! >>> -- >>> Yoann Congal >>> Smile ECS >>> >>> >>> -=-=-=-=-=-=-=-=-=-=-=- >>> Links: You receive all messages sent to this group. >>> View/Reply Online (#241665): >>> https://lists.openembedded.org/g/openembedded-core/message/241665 >>> Mute This Topic: https://lists.openembedded.org/mt/120392420/1334323 >>> Group Owner: openembedded-core+owner@lists.openembedded.org >>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ >>> emailaddress.ashish@gmail.com] >>> -=-=-=-=-=-=-=-=-=-=-=- >>> >>> > > -- > Yoann Congal > Smile ECS >
diff --git a/meta/classes-global/package.bbclass b/meta/classes-global/package.bbclass index aa1eb5e901..ffe3ed93ef 100644 --- a/meta/classes-global/package.bbclass +++ b/meta/classes-global/package.bbclass @@ -468,8 +468,7 @@ PACKAGEFUNCS += " \ package_do_shlibs \ package_do_pkgconfig \ read_shlibdeps \ - package_depchains \ - emit_pkgdata" + package_depchains" python do_package () { # Change the following version to cause sstate to invalidate the package @@ -561,9 +560,13 @@ python do_package () { for file in files: pkgfiles[pkg].append(walkroot + os.sep + file) + + # We want emit_pkgdata to run last, after everything for f in (d.getVar('PACKAGEFUNCS') or '').split(): bb.build.exec_func(f, d) + bb.build.exec_func("emit_pkgdata", d) + oe.qa.exit_if_errors(d) }
emit_pkgdata was previously part of the PACKAGEFUNCS list. Because other layers and recipes often append custom cleanup or processing functions to PACKAGEFUNCS , those ended up running after emit_pkgdata To fix this, pull emit_pkgdata out of PACKAGEFUNCS and call it explicitly at the very end of do_package() ensuring it always runs last. (From OE-Core rev aa85baff9ebdd3f932811c3b43d1918c38373cb9) Signed-off-by: AshishKumar Mishra <emailaddress.ashish@gmail.com> --- meta/classes-global/package.bbclass | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)