| Message ID | 20260609222331.1293007-5-JPEWhacker@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Implement SPDX for deploy tasks | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/4-5-Add-SPDX-deploy-tasks.patch FAIL: test shortlog format: Commit shortlog (first line of commit message) should follow the format "<target>: <summary>" (test_mbox.TestMbox.test_shortlog_format) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
Hi, On Tue, Jun 09, 2026 at 04:15:55PM -0600, Joshua Watt via lists.openembedded.org wrote: > Adds SPDX deploy tasks to many recipes to record their output when > consumed in an SBoM > > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> > --- > meta/classes-recipe/barebox.bbclass | 3 ++- > meta/classes-recipe/devicetree.bbclass | 3 ++- > meta/classes-recipe/kernel-fit-image.bbclass | 3 ++- > meta/classes-recipe/kernel.bbclass | 3 ++- > meta/recipes-bsp/grub/grub-efi_2.14.bb | 3 ++- > meta/recipes-bsp/opensbi/opensbi_1.8.1.bb | 3 ++- > meta/recipes-bsp/u-boot/u-boot.inc | 3 ++- > meta/recipes-core/systemd/systemd-boot_259.5.bb | 4 ++-- > 8 files changed, 16 insertions(+), 9 deletions(-) > > diff --git a/meta/classes-recipe/barebox.bbclass b/meta/classes-recipe/barebox.bbclass > index 73615999aa..0be611cf65 100644 > --- a/meta/classes-recipe/barebox.bbclass > +++ b/meta/classes-recipe/barebox.bbclass > @@ -157,6 +157,7 @@ barebox_do_deploy () { > done > fi > } > -addtask deploy after do_compile > +addtask deploy after do_compile do_create_spdx > +SPDX_DEPLOY_TASKS += "do_deploy" > > EXPORT_FUNCTIONS do_configure do_compile do_install do_deploy > diff --git a/meta/classes-recipe/devicetree.bbclass b/meta/classes-recipe/devicetree.bbclass > index ce9d008aac..a313507251 100644 > --- a/meta/classes-recipe/devicetree.bbclass > +++ b/meta/classes-recipe/devicetree.bbclass > @@ -163,7 +163,8 @@ devicetree_do_deploy() { > install -Dm 0644 "${B}/$dtb_file" "${DEPLOYDIR}/devicetree/$dtb_file" > done > } > -addtask deploy before do_build after do_install > +addtask deploy before do_build after do_install do_create_spdx > +SPDX_DEPLOY_TASKS += "do_deploy" Could deploy.bbclass do this by default? There are plenty of similar changes needed in BSP etc layers which already use deploy.bbclass. Cheers, -Mikko > EXPORT_FUNCTIONS do_compile do_install do_deploy > > diff --git a/meta/classes-recipe/kernel-fit-image.bbclass b/meta/classes-recipe/kernel-fit-image.bbclass > index ae8f3c6688..becbc280ce 100644 > --- a/meta/classes-recipe/kernel-fit-image.bbclass > +++ b/meta/classes-recipe/kernel-fit-image.bbclass > @@ -240,4 +240,5 @@ do_deploy() { > fi > fi > } > -addtask deploy after do_compile before do_build > +addtask deploy after do_compile do_create_spdx before do_build > +SPDX_DEPLOY_TASKS += "do_deploy" > diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass > index 50cef17f69..5dc606048b 100644 > --- a/meta/classes-recipe/kernel.bbclass > +++ b/meta/classes-recipe/kernel.bbclass > @@ -841,7 +841,8 @@ kernel_do_deploy() { > # ensure we get the right values for both > do_deploy[prefuncs] += "read_subpackage_metadata" > > -addtask deploy after do_install do_populate_sysroot do_packagedata > +addtask deploy after do_install do_populate_sysroot do_packagedata do_create_spdx > +SPDX_DEPLOY_TASKS += "do_deploy" > > EXPORT_FUNCTIONS do_deploy > > diff --git a/meta/recipes-bsp/grub/grub-efi_2.14.bb b/meta/recipes-bsp/grub/grub-efi_2.14.bb > index 6354b43989..db187ac373 100644 > --- a/meta/recipes-bsp/grub/grub-efi_2.14.bb > +++ b/meta/recipes-bsp/grub/grub-efi_2.14.bb > @@ -96,7 +96,8 @@ do_deploy() { > install -m 644 ${B}/${GRUB_IMAGE_PREFIX}${GRUB_IMAGE} ${DEPLOYDIR} > } > > -addtask deploy after do_install before do_build > +addtask deploy after do_install do_create_spdx before do_build > +SPDX_DEPLOY_TASKS += "do_deploy" > > FILES:${PN} = "${libdir}/grub/${GRUB_TARGET}-efi \ > ${datadir}/grub \ > diff --git a/meta/recipes-bsp/opensbi/opensbi_1.8.1.bb b/meta/recipes-bsp/opensbi/opensbi_1.8.1.bb > index 0a9652c283..377a06fb78 100644 > --- a/meta/recipes-bsp/opensbi/opensbi_1.8.1.bb > +++ b/meta/recipes-bsp/opensbi/opensbi_1.8.1.bb > @@ -44,7 +44,8 @@ do_deploy () { > install -m 755 ${D}/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_dynamic.* ${DEPLOYDIR}/ > } > > -addtask deploy before do_build after do_install > +addtask deploy before do_build after do_install do_create_spdx > +SPDX_DEPLOY_TASKS += "do_deploy" > > FILES:${PN} += "/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_jump.*" > FILES:${PN} += "/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_payload.*" > diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc > index a75948dfc3..1c3c9858df 100644 > --- a/meta/recipes-bsp/u-boot/u-boot.inc > +++ b/meta/recipes-bsp/u-boot/u-boot.inc > @@ -470,4 +470,5 @@ uboot_deploy_spl () { > ln -sf ${SPL_IMAGE} ${DEPLOYDIR}/${SPL_SYMLINK} > } > > -addtask deploy before do_build after do_compile > +addtask deploy before do_build after do_compile do_create_spdx > +SPDX_DEPLOY_TASKS += "do_deploy" > diff --git a/meta/recipes-core/systemd/systemd-boot_259.5.bb b/meta/recipes-core/systemd/systemd-boot_259.5.bb > index c6c443f929..e2c579db97 100644 > --- a/meta/recipes-core/systemd/systemd-boot_259.5.bb > +++ b/meta/recipes-core/systemd/systemd-boot_259.5.bb > @@ -71,5 +71,5 @@ do_deploy () { > install ${B}/src/boot/addon*.efi.stub ${DEPLOYDIR} > } > > -addtask deploy before do_build after do_compile > - > +addtask deploy before do_build after do_compile do_create_spdx > +SPDX_DEPLOY_TASKS += "do_deploy" > -- > 2.54.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#238307): https://lists.openembedded.org/g/openembedded-core/message/238307 > Mute This Topic: https://lists.openembedded.org/mt/119731707/7159507 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mikko.rapeli@linaro.org] > -=-=-=-=-=-=-=-=-=-=-=- >
On Tue, 2026-06-09 at 16:15 -0600, Joshua Watt via lists.openembedded.org wrote: > Adds SPDX deploy tasks to many recipes to record their output when > consumed in an SBoM > > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> > --- > meta/classes-recipe/barebox.bbclass | 3 ++- > meta/classes-recipe/devicetree.bbclass | 3 ++- > meta/classes-recipe/kernel-fit-image.bbclass | 3 ++- > meta/classes-recipe/kernel.bbclass | 3 ++- > meta/recipes-bsp/grub/grub-efi_2.14.bb | 3 ++- > meta/recipes-bsp/opensbi/opensbi_1.8.1.bb | 3 ++- > meta/recipes-bsp/u-boot/u-boot.inc | 3 ++- > meta/recipes-core/systemd/systemd-boot_259.5.bb | 4 ++-- > 8 files changed, 16 insertions(+), 9 deletions(-) > > diff --git a/meta/classes-recipe/barebox.bbclass b/meta/classes-recipe/barebox.bbclass > index 73615999aa..0be611cf65 100644 > --- a/meta/classes-recipe/barebox.bbclass > +++ b/meta/classes-recipe/barebox.bbclass > @@ -157,6 +157,7 @@ barebox_do_deploy () { > done > fi > } > -addtask deploy after do_compile > +addtask deploy after do_compile do_create_spdx > +SPDX_DEPLOY_TASKS += "do_deploy" > > EXPORT_FUNCTIONS do_configure do_compile do_install do_deploy > diff --git a/meta/classes-recipe/devicetree.bbclass b/meta/classes-recipe/devicetree.bbclass > index ce9d008aac..a313507251 100644 > --- a/meta/classes-recipe/devicetree.bbclass > +++ b/meta/classes-recipe/devicetree.bbclass > @@ -163,7 +163,8 @@ devicetree_do_deploy() { > install -Dm 0644 "${B}/$dtb_file" "${DEPLOYDIR}/devicetree/$dtb_file" > done > } > -addtask deploy before do_build after do_install > +addtask deploy before do_build after do_install do_create_spdx > +SPDX_DEPLOY_TASKS += "do_deploy" > > EXPORT_FUNCTIONS do_compile do_install do_deploy > Adding this "after do_create_spdx" makes spdx mandatory and impossible to disable which I'm not sure is what you intended? Cheers, Richard
diff --git a/meta/classes-recipe/barebox.bbclass b/meta/classes-recipe/barebox.bbclass index 73615999aa..0be611cf65 100644 --- a/meta/classes-recipe/barebox.bbclass +++ b/meta/classes-recipe/barebox.bbclass @@ -157,6 +157,7 @@ barebox_do_deploy () { done fi } -addtask deploy after do_compile +addtask deploy after do_compile do_create_spdx +SPDX_DEPLOY_TASKS += "do_deploy" EXPORT_FUNCTIONS do_configure do_compile do_install do_deploy diff --git a/meta/classes-recipe/devicetree.bbclass b/meta/classes-recipe/devicetree.bbclass index ce9d008aac..a313507251 100644 --- a/meta/classes-recipe/devicetree.bbclass +++ b/meta/classes-recipe/devicetree.bbclass @@ -163,7 +163,8 @@ devicetree_do_deploy() { install -Dm 0644 "${B}/$dtb_file" "${DEPLOYDIR}/devicetree/$dtb_file" done } -addtask deploy before do_build after do_install +addtask deploy before do_build after do_install do_create_spdx +SPDX_DEPLOY_TASKS += "do_deploy" EXPORT_FUNCTIONS do_compile do_install do_deploy diff --git a/meta/classes-recipe/kernel-fit-image.bbclass b/meta/classes-recipe/kernel-fit-image.bbclass index ae8f3c6688..becbc280ce 100644 --- a/meta/classes-recipe/kernel-fit-image.bbclass +++ b/meta/classes-recipe/kernel-fit-image.bbclass @@ -240,4 +240,5 @@ do_deploy() { fi fi } -addtask deploy after do_compile before do_build +addtask deploy after do_compile do_create_spdx before do_build +SPDX_DEPLOY_TASKS += "do_deploy" diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass index 50cef17f69..5dc606048b 100644 --- a/meta/classes-recipe/kernel.bbclass +++ b/meta/classes-recipe/kernel.bbclass @@ -841,7 +841,8 @@ kernel_do_deploy() { # ensure we get the right values for both do_deploy[prefuncs] += "read_subpackage_metadata" -addtask deploy after do_install do_populate_sysroot do_packagedata +addtask deploy after do_install do_populate_sysroot do_packagedata do_create_spdx +SPDX_DEPLOY_TASKS += "do_deploy" EXPORT_FUNCTIONS do_deploy diff --git a/meta/recipes-bsp/grub/grub-efi_2.14.bb b/meta/recipes-bsp/grub/grub-efi_2.14.bb index 6354b43989..db187ac373 100644 --- a/meta/recipes-bsp/grub/grub-efi_2.14.bb +++ b/meta/recipes-bsp/grub/grub-efi_2.14.bb @@ -96,7 +96,8 @@ do_deploy() { install -m 644 ${B}/${GRUB_IMAGE_PREFIX}${GRUB_IMAGE} ${DEPLOYDIR} } -addtask deploy after do_install before do_build +addtask deploy after do_install do_create_spdx before do_build +SPDX_DEPLOY_TASKS += "do_deploy" FILES:${PN} = "${libdir}/grub/${GRUB_TARGET}-efi \ ${datadir}/grub \ diff --git a/meta/recipes-bsp/opensbi/opensbi_1.8.1.bb b/meta/recipes-bsp/opensbi/opensbi_1.8.1.bb index 0a9652c283..377a06fb78 100644 --- a/meta/recipes-bsp/opensbi/opensbi_1.8.1.bb +++ b/meta/recipes-bsp/opensbi/opensbi_1.8.1.bb @@ -44,7 +44,8 @@ do_deploy () { install -m 755 ${D}/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_dynamic.* ${DEPLOYDIR}/ } -addtask deploy before do_build after do_install +addtask deploy before do_build after do_install do_create_spdx +SPDX_DEPLOY_TASKS += "do_deploy" FILES:${PN} += "/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_jump.*" FILES:${PN} += "/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_payload.*" diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc index a75948dfc3..1c3c9858df 100644 --- a/meta/recipes-bsp/u-boot/u-boot.inc +++ b/meta/recipes-bsp/u-boot/u-boot.inc @@ -470,4 +470,5 @@ uboot_deploy_spl () { ln -sf ${SPL_IMAGE} ${DEPLOYDIR}/${SPL_SYMLINK} } -addtask deploy before do_build after do_compile +addtask deploy before do_build after do_compile do_create_spdx +SPDX_DEPLOY_TASKS += "do_deploy" diff --git a/meta/recipes-core/systemd/systemd-boot_259.5.bb b/meta/recipes-core/systemd/systemd-boot_259.5.bb index c6c443f929..e2c579db97 100644 --- a/meta/recipes-core/systemd/systemd-boot_259.5.bb +++ b/meta/recipes-core/systemd/systemd-boot_259.5.bb @@ -71,5 +71,5 @@ do_deploy () { install ${B}/src/boot/addon*.efi.stub ${DEPLOYDIR} } -addtask deploy before do_build after do_compile - +addtask deploy before do_build after do_compile do_create_spdx +SPDX_DEPLOY_TASKS += "do_deploy"
Adds SPDX deploy tasks to many recipes to record their output when consumed in an SBoM Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> --- meta/classes-recipe/barebox.bbclass | 3 ++- meta/classes-recipe/devicetree.bbclass | 3 ++- meta/classes-recipe/kernel-fit-image.bbclass | 3 ++- meta/classes-recipe/kernel.bbclass | 3 ++- meta/recipes-bsp/grub/grub-efi_2.14.bb | 3 ++- meta/recipes-bsp/opensbi/opensbi_1.8.1.bb | 3 ++- meta/recipes-bsp/u-boot/u-boot.inc | 3 ++- meta/recipes-core/systemd/systemd-boot_259.5.bb | 4 ++-- 8 files changed, 16 insertions(+), 9 deletions(-)