diff mbox series

[4/6] package_manager: remove [True, False] list eval

Message ID 20260601-topic-packagemanager-cleanup-v1-4-926e4d5b724d@linaro.org
State Under Review
Headers show
Series Small package manager cleanup series | expand

Commit Message

Rouven Czerwinski via B4 Relay June 1, 2026, 7:13 a.m. UTC 
From: Rouven Czerwinski <rouven.czerwinski@linaro.org>

Remove a [True, False] list evaluation that itself relied on evaluating
a boolean condition. Instead pass the boolean condition directly.

The previous version works because int(True)=1 and int(False)=0.
So:
 => pkg_type = Manifest.PKG_TYPE_ATTEMPT_ONLY
 => [False, True][pkg_type == Manifest.PKG_TYPE_ATTEMPT_ONLY]
 => [False, True][True]
 => [False, True][1]
 => True

No functional changes.

Signed-off-by: Rouven Czerwinski <rouven.czerwinski@linaro.org>
---
 meta/lib/oe/package_manager/deb/rootfs.py | 2 +-
 meta/lib/oe/package_manager/deb/sdk.py    | 2 +-
 meta/lib/oe/package_manager/ipk/rootfs.py | 2 +-
 meta/lib/oe/package_manager/ipk/sdk.py    | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/meta/lib/oe/package_manager/deb/rootfs.py b/meta/lib/oe/package_manager/deb/rootfs.py
index 21d6cc5e5d..d2b077cc37 100644
--- a/meta/lib/oe/package_manager/deb/rootfs.py
+++ b/meta/lib/oe/package_manager/deb/rootfs.py
@@ -165,7 +165,7 @@  class PkgRootfs(DpkgOpkgRootfs):
         for pkg_type in Manifest.INSTALL_ORDER:
             if pkg_type in pkgs_to_install:
                 self.pm.install(pkgs_to_install[pkg_type],
-                                [False, True][pkg_type == Manifest.PKG_TYPE_ATTEMPT_ONLY])
+                                pkg_type == Manifest.PKG_TYPE_ATTEMPT_ONLY)
                 self.pm.fix_broken_dependencies()
 
         if self.progress_reporter:
diff --git a/meta/lib/oe/package_manager/deb/sdk.py b/meta/lib/oe/package_manager/deb/sdk.py
index 690b10d2ba..519b5c9f90 100644
--- a/meta/lib/oe/package_manager/deb/sdk.py
+++ b/meta/lib/oe/package_manager/deb/sdk.py
@@ -57,7 +57,7 @@  class PkgSdk(Sdk):
         for pkg_type in Manifest.INSTALL_ORDER:
             if pkg_type in pkgs_to_install:
                 pm.install(pkgs_to_install[pkg_type],
-                           [False, True][pkg_type == Manifest.PKG_TYPE_ATTEMPT_ONLY])
+                           pkg_type == Manifest.PKG_TYPE_ATTEMPT_ONLY)
 
     def _populate(self):
         execute_pre_post_process(self.d, self.d.getVar("POPULATE_SDK_PRE_TARGET_COMMAND"))
diff --git a/meta/lib/oe/package_manager/ipk/rootfs.py b/meta/lib/oe/package_manager/ipk/rootfs.py
index bc822bac87..a760000d3f 100644
--- a/meta/lib/oe/package_manager/ipk/rootfs.py
+++ b/meta/lib/oe/package_manager/ipk/rootfs.py
@@ -307,7 +307,7 @@  class PkgRootfs(DpkgOpkgRootfs):
                     self._multilib_test_install(pkgs_to_install[pkg_type])
 
                 self.pm.install(pkgs_to_install[pkg_type],
-                                [False, True][pkg_type == Manifest.PKG_TYPE_ATTEMPT_ONLY])
+                                pkg_type == Manifest.PKG_TYPE_ATTEMPT_ONLY)
 
         if self.progress_reporter:
             self.progress_reporter.next_stage()
diff --git a/meta/lib/oe/package_manager/ipk/sdk.py b/meta/lib/oe/package_manager/ipk/sdk.py
index 8dc01661ef..e75e9bd991 100644
--- a/meta/lib/oe/package_manager/ipk/sdk.py
+++ b/meta/lib/oe/package_manager/ipk/sdk.py
@@ -53,7 +53,7 @@  class PkgSdk(Sdk):
         for pkg_type in Manifest.INSTALL_ORDER:
             if pkg_type in pkgs_to_install:
                 pm.install(pkgs_to_install[pkg_type],
-                           [False, True][pkg_type == Manifest.PKG_TYPE_ATTEMPT_ONLY])
+                           pkg_type == Manifest.PKG_TYPE_ATTEMPT_ONLY)
 
     def _populate(self):
         execute_pre_post_process(self.d, self.d.getVar("POPULATE_SDK_PRE_TARGET_COMMAND"))