diff mbox series

libsdl2: Fix compilation error with DirectFB

Message ID 20260525134255.99033-1-toertel@gmail.com
State New
Headers show
Series libsdl2: Fix compilation error with DirectFB | expand

Commit Message

Mark Jonas May 25, 2026, 1:42 p.m. UTC 
From: Mark Jonas <toertel@gmail.com>

Compiling libsdl2 with DirectFB as renderer results in a compilation
error. Patch libsdl2 so DirectFB_CreateRenderer() uses the current
SDL_RenderDriver API.

Signed-off-by: Mark Jonas <toertel@gmail.com>
---
 ...ix-CreateRenderer-callback-signature.patch | 58 +++++++++++++++++++
 .../libsdl2/libsdl2_2.32.10.bb                |  5 +-
 2 files changed, 62 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-graphics/libsdl2/libsdl2/0001-directfb-Fix-CreateRenderer-callback-signature.patch
diff mbox series

Patch

diff --git a/meta/recipes-graphics/libsdl2/libsdl2/0001-directfb-Fix-CreateRenderer-callback-signature.patch b/meta/recipes-graphics/libsdl2/libsdl2/0001-directfb-Fix-CreateRenderer-callback-signature.patch
new file mode 100644
index 0000000000..232b7e76d9
--- /dev/null
+++ b/meta/recipes-graphics/libsdl2/libsdl2/0001-directfb-Fix-CreateRenderer-callback-signature.patch
@@ -0,0 +1,58 @@ 
+From 1df9ae4338c43ad9dce4b27a77f807aa8d2b073b Mon Sep 17 00:00:00 2001
+From: Mark Jonas <toertel@gmail.com>
+Date: Sun, 10 May 2026 20:16:17 +0200
+Subject: [PATCH] directfb: Fix CreateRenderer callback signature
+
+Update DirectFB_CreateRenderer() to use the current SDL_RenderDriver
+API.
+
+Signed-off-by: Mark Jonas <toertel@gmail.com>
+
+Upstream-Status: Backport [https://github.com/libsdl-org/SDL/commit/bb65446578187f0dd1460d5ddf02636e8a7a3b8a]
+---
+ src/video/directfb/SDL_DirectFB_render.c | 11 ++++-------
+ 1 file changed, 4 insertions(+), 7 deletions(-)
+
+diff --git a/src/video/directfb/SDL_DirectFB_render.c b/src/video/directfb/SDL_DirectFB_render.c
+index 3f353cce9..684f907ea 100644
+--- a/src/video/directfb/SDL_DirectFB_render.c
++++ b/src/video/directfb/SDL_DirectFB_render.c
+@@ -1130,19 +1130,17 @@ static int DirectFB_RenderWritePixels(SDL_Renderer * renderer, const SDL_Rect *
+ #endif
+
+
+-SDL_Renderer *DirectFB_CreateRenderer(SDL_Window * window, Uint32 flags)
++static int DirectFB_CreateRenderer(SDL_Renderer *renderer, SDL_Window * window, Uint32 flags)
+ {
+     IDirectFBSurface *winsurf = get_dfb_surface(window);
+     /*SDL_VideoDisplay *display = SDL_GetDisplayForWindow(window);*/
+-    SDL_Renderer *renderer = NULL;
+     DirectFB_RenderData *data = NULL;
+     DFBSurfaceCapabilities scaps;
+
+     if (!winsurf) {
+-        return NULL;
++        return -1;
+     }
+
+-    SDL_DFB_ALLOC_CLEAR(renderer, sizeof(*renderer));
+     SDL_DFB_ALLOC_CLEAR(data, sizeof(*data));
+
+     renderer->WindowEvent = DirectFB_WindowEvent;
+@@ -1207,12 +1205,11 @@ SDL_Renderer *DirectFB_CreateRenderer(SDL_Window * window, Uint32 flags)
+     }
+ #endif
+
+-    return renderer;
++    return 0;
+
+   error:
+-    SDL_DFB_FREE(renderer);
+     SDL_DFB_FREE(data);
+-    return NULL;
++    return -1;
+ }
+
+
+--
+2.43.0
diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb
index 2b583448ef..880bf56167 100644
--- a/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb
+++ b/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb
@@ -21,7 +21,10 @@  LIC_FILES_CHKSUM:append = " ${@bb.utils.contains('PACKAGECONFIG', 'arm-neon', 'f
 
 PROVIDES = "virtual/libsdl2"
 
-SRC_URI = "https://www.libsdl.org/release/SDL2-${PV}.tar.gz"
+SRC_URI = "\
+    https://www.libsdl.org/release/SDL2-${PV}.tar.gz \
+    file://0001-directfb-Fix-CreateRenderer-callback-signature.patch \
+"
 
 S = "${UNPACKDIR}/SDL2-${PV}"