diff mbox series

gstreamer1.0-plugins-bad: disable vulkan when x11/wayland not enabled

Message ID 20260507051048.3943372-1-changqing.li@windriver.com
State Changes Requested
Headers show
Series gstreamer1.0-plugins-bad: disable vulkan when x11/wayland not enabled | expand

Commit Message

Changqing Li May 7, 2026, 5:10 a.m. UTC
When vulkan is enabled in DISTRO_FEATURES without x11 or wayland,
do_configure will failed with error:
gst-libs/gst/vulkan/meson.build:311:4: ERROR: Problem encountered: No Windowing system found. vulkansink will not work

disable vulkan from PACKAGECONFIG when x11 and wayland is not enabled

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb                | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jose Quaresma May 7, 2026, 8:40 a.m. UTC | #1
Changqing Li via lists.openembedded.org <changqing.li=
windriver.com@lists.openembedded.org> escreveu (quinta, 7/05/2026 à(s)
06:11):

> When vulkan is enabled in DISTRO_FEATURES without x11 or wayland,
> do_configure will failed with error:
> gst-libs/gst/vulkan/meson.build:311:4: ERROR: Problem encountered: No
> Windowing system found. vulkansink will not work
>
> disable vulkan from PACKAGECONFIG when x11 and wayland is not enabled
>
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  .../gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb                | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.28.2.bb b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.28.2.bb
> index cdf3a20dff..51f51761f9 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb
> @@ -32,6 +32,8 @@ PACKAGECONFIG ??= " \
>      ${@bb.utils.contains('TUNE_FEATURES', 'mx32', '', 'rsvg', d)} \
>  "
>
> +PACKAGECONFIG:remove = "${@'vulkan' if
> (bb.utils.filter('DISTRO_FEATURES', 'x11 wayland', d) == '') else ''}"
> +
>

Using the 'remove' override on the core should be avoided because it's
impossible to revert the changes on other layers.
In my opinion, it would be better to use an auxiliary variable to define
when vulkan is enabled, and this could be modified
if necessary in other layers.

PACKAGECONFIG_VULKAN ?= "${@bb.utils.contains('DISTRO_FEATURES', 'x11
wayland', 'vulkan', '', d)"
PACKAGECONFIG ??= " \
    ${PACKAGECONFIG_VULKAN}
"

Jose

 PACKAGECONFIG[analytics]       =
> "-Danalyticsoverlay=enabled,-Danalyticsoverlay=disabled
>  PACKAGECONFIG[aom]             = "-Daom=enabled,-Daom=disabled,aom"
>  PACKAGECONFIG[assrender]       =
> "-Dassrender=enabled,-Dassrender=disabled,libass"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#236555):
> https://lists.openembedded.org/g/openembedded-core/message/236555
> Mute This Topic: https://lists.openembedded.org/mt/119192696/5052612
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Changqing Li May 8, 2026, 1:56 a.m. UTC | #2
On 5/7/26 16:40, Jose Quaresma wrote:
> **
> *CAUTION: This email comes from a non Wind River email account!*
> Do not click links or open attachments unless you recognize the sender 
> and know the content is safe.
>
>
> Changqing Li via lists.openembedded.org 
> <https://urldefense.com/v3/__http://lists.openembedded.org__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywidzs6L4$> 
> <changqing.li 
> <https://urldefense.com/v3/__http://changqing.li__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywjPgScZ8$>=windriver.com@lists.openembedded.org> 
> escreveu (quinta, 7/05/2026 à(s) 06:11):
>
>     When vulkan is enabled in DISTRO_FEATURES without x11 or wayland,
>     do_configure will failed with error:
>     gst-libs/gst/vulkan/meson.build
>     <https://urldefense.com/v3/__http://meson.build__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywqg724Gd$>:311:4:
>     ERROR: Problem encountered: No Windowing system found. vulkansink
>     will not work
>
>     disable vulkan from PACKAGECONFIG when x11 and wayland is not enabled
>
>     Signed-off-by: Changqing Li <changqing.li@windriver.com>
>     ---
>      .../gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb
>     <https://urldefense.com/v3/__http://gstreamer1.0-plugins-bad_1.28.2.bb__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywrb_TT-G$>
>                   | 2 ++
>      1 file changed, 2 insertions(+)
>
>     diff --git
>     a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb
>     <https://urldefense.com/v3/__http://gstreamer1.0-plugins-bad_1.28.2.bb__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywrb_TT-G$>
>     b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb
>     <https://urldefense.com/v3/__http://gstreamer1.0-plugins-bad_1.28.2.bb__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywrb_TT-G$>
>     index cdf3a20dff..51f51761f9 100644
>     ---
>     a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb
>     <https://urldefense.com/v3/__http://gstreamer1.0-plugins-bad_1.28.2.bb__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywrb_TT-G$>
>     +++
>     b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb
>     <https://urldefense.com/v3/__http://gstreamer1.0-plugins-bad_1.28.2.bb__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywrb_TT-G$>
>     @@ -32,6 +32,8 @@ PACKAGECONFIG ??= " \
>          ${@bb.utils.contains('TUNE_FEATURES', 'mx32', '', 'rsvg', d)} \
>      "
>
>     +PACKAGECONFIG:remove = "${@'vulkan' if
>     (bb.utils.filter('DISTRO_FEATURES', 'x11 wayland', d) == '') else ''}"
>     +
>
>
> Using the 'remove' override on the core should be avoided because it's 
> impossible to revert the changes on other layers.
> In my opinion, it would be better to use an auxiliary variable to 
> define when vulkan is enabled, and this could be modified
> if necessary in other layers.
>
> PACKAGECONFIG_VULKAN ?= "${@bb.utils.contains('DISTRO_FEATURES', 'x11 
> wayland', 'vulkan', '', d)"
> PACKAGECONFIG ??= " \
>     ${PACKAGECONFIG_VULKAN}
> "
>
make sense,  V2 is sent.

//Changqing

> Jose
>
>      PACKAGECONFIG[analytics]       =
>     "-Danalyticsoverlay=enabled,-Danalyticsoverlay=disabled
>      PACKAGECONFIG[aom]             = "-Daom=enabled,-Daom=disabled,aom"
>      PACKAGECONFIG[assrender]       =
>     "-Dassrender=enabled,-Dassrender=disabled,libass"
>     -- 
>     2.34.1
>
>
>     -=-=-=-=-=-=-=-=-=-=-=-
>     Links: You receive all messages sent to this group.
>     View/Reply Online (#236555):
>     https://lists.openembedded.org/g/openembedded-core/message/236555
>     <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-core/message/236555__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywjKCbECS$>
>     Mute This Topic:
>     https://lists.openembedded.org/mt/119192696/5052612
>     <https://urldefense.com/v3/__https://lists.openembedded.org/mt/119192696/5052612__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywrSm1KWM$>
>     Group Owner: openembedded-core+owner@lists.openembedded.org
>     <mailto:openembedded-core%2Bowner@lists.openembedded.org>
>     Unsubscribe:
>     https://lists.openembedded.org/g/openembedded-core/unsub
>     <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-core/unsub__;!!AjveYdw8EvQ!dPR5LmVIme5FlfwBJVSZ_k5sL159UKn_EJ1pWkvQuIOeVm3DyoMnbyzaA2dNv0fRnQ7VfufnRvC5_W3JR5-ywn3VeNul$>
>     [quaresma.jose@gmail.com]
>     -=-=-=-=-=-=-=-=-=-=-=-
>
>
>
> -- 
> Best regards,
>
> José Quaresma
diff mbox series

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb
index cdf3a20dff..51f51761f9 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb
@@ -32,6 +32,8 @@  PACKAGECONFIG ??= " \
     ${@bb.utils.contains('TUNE_FEATURES', 'mx32', '', 'rsvg', d)} \
 "
 
+PACKAGECONFIG:remove = "${@'vulkan' if (bb.utils.filter('DISTRO_FEATURES', 'x11 wayland', d) == '') else ''}"
+
 PACKAGECONFIG[analytics]       = "-Danalyticsoverlay=enabled,-Danalyticsoverlay=disabled,"
 PACKAGECONFIG[aom]             = "-Daom=enabled,-Daom=disabled,aom"
 PACKAGECONFIG[assrender]       = "-Dassrender=enabled,-Dassrender=disabled,libass"