diff mbox series

u-boot-tools: drop the hardlink workaround in do_compile

Message ID 20260506115219.2371873-1-joaomarcos.costa@bootlin.com
State Accepted, archived
Commit c9df140bf5b3dfe2c69bc550e7d998aa5e4e56c0
Headers show
Series u-boot-tools: drop the hardlink workaround in do_compile | expand

Commit Message

João Marcos Costa May 6, 2026, 11:52 a.m. UTC
This workaround initially considered a host running git < v2.14, which
does not look realistic if we consider the fairly recent distros in
SANITY_TESTED_DISTROS.

Even in older build machines/distros, one can use buildtools to provide git:

$ ./x86_64-buildtools-extended-nativesdk-standalone-5.0.sh
(...)
$ which git
(...)/buildtools/sysroots/x86_64-pokysdk-linux/usr/bin/git
$ git --version
git version 2.44.0

It is harmless, but still a bit outdated, so remove it.

Signed-off-by: João Marcos Costa <joaomarcos.costa@bootlin.com>
---
 meta/recipes-bsp/u-boot/u-boot-tools.inc | 15 ---------------
 1 file changed, 15 deletions(-)
diff mbox series

Patch

diff --git a/meta/recipes-bsp/u-boot/u-boot-tools.inc b/meta/recipes-bsp/u-boot/u-boot-tools.inc
index 4e4f7fa092..738d843591 100644
--- a/meta/recipes-bsp/u-boot/u-boot-tools.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-tools.inc
@@ -27,21 +27,6 @@  SED_CONFIG_EFI:aarch64 = ''
 SED_CONFIG_EFI:loongarch64 = ''
 
 do_compile () {
-	# Yes, this is crazy. If you build on a system with git < 2.14 from scratch, the tree will
-	# be marked as "dirty" and the version will include "-dirty", leading to a reproducibility problem.
-	# The issue is the inode count for Licnses/README changing due to do_populate_lic hardlinking a
-	# copy of the file. We avoid this by ensuring the index is updated with a "git diff" before the
-	# u-boot machinery tries to determine the version.
-	#
-	# build$ ../git/scripts/setlocalversion ../git
-	# ""
-	# build$ ln ../git/
-	# build$ ln ../git/README ../foo
-	# build$ ../git/scripts/setlocalversion ../git
-	# ""-dirty
-	# (i.e. creating a hardlink dirties the index)
-	cd ${S}; git diff; cd ${B}
-
 	oe_runmake -C ${S} tools-only_defconfig O=${B}
 
 	# Disable CONFIG_CMD_LICENSE, license.h is not used by tools and