| Message ID | 20260505081625.849368-4-Deepesh.Varatharajan@windriver.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Oe-selftest for Clang, LLVM, LLD | expand |
On Tue, 2026-05-05 at 01:16 -0700, Varatharajan, Deepesh via lists.openembedded.org wrote: > From: Deepesh Varatharajan <Deepesh.Varatharajan@windriver.com> > > While running testsuite set CLANG_ENABLE_TESTSUITE = "1" > > Signed-off-by: Deepesh Varatharajan <Deepesh.Varatharajan@windriver.com> > --- > meta-selftest/recipes-devtools/clang/clang_%.bbappend | 2 ++ > meta-selftest/recipes-devtools/clang/lld_%.bbappend | 2 ++ > meta-selftest/recipes-devtools/clang/llvm_%.bbappend | 2 ++ > 3 files changed, 6 insertions(+) > create mode 100644 meta-selftest/recipes-devtools/clang/clang_%.bbappend > create mode 100644 meta-selftest/recipes-devtools/clang/lld_%.bbappend > create mode 100644 meta-selftest/recipes-devtools/clang/llvm_%.bbappend > > diff --git a/meta-selftest/recipes-devtools/clang/clang_%.bbappend b/meta-selftest/recipes-devtools/clang/clang_%.bbappend > new file mode 100644 > index 0000000000..32c236b972 > --- /dev/null > +++ b/meta-selftest/recipes-devtools/clang/clang_%.bbappend > @@ -0,0 +1,2 @@ > +# Enable CLANG testsuite > +CLANG_ENABLE_TESTSUITE = "1" > diff --git a/meta-selftest/recipes-devtools/clang/lld_%.bbappend b/meta-selftest/recipes-devtools/clang/lld_%.bbappend > new file mode 100644 > index 0000000000..32c236b972 > --- /dev/null > +++ b/meta-selftest/recipes-devtools/clang/lld_%.bbappend > @@ -0,0 +1,2 @@ > +# Enable CLANG testsuite > +CLANG_ENABLE_TESTSUITE = "1" > diff --git a/meta-selftest/recipes-devtools/clang/llvm_%.bbappend b/meta-selftest/recipes-devtools/clang/llvm_%.bbappend > new file mode 100644 > index 0000000000..32c236b972 > --- /dev/null > +++ b/meta-selftest/recipes-devtools/clang/llvm_%.bbappend > @@ -0,0 +1,2 @@ > +# Enable CLANG testsuite > +CLANG_ENABLE_TESTSUITE = "1" Having bbappends inside meta-selftest isn't something we've done before and feels a bit odd. I think it will cause yocto-check=layer to fail too. Why wouldn't we just set this variable inside the tests that need it? Cheers, Richard
On 05-05-2026 15:01, Richard Purdie wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On Tue, 2026-05-05 at 01:16 -0700, Varatharajan, Deepesh via lists.openembedded.org wrote: >> From: Deepesh Varatharajan<Deepesh.Varatharajan@windriver.com> >> >> While running testsuite set CLANG_ENABLE_TESTSUITE = "1" >> >> Signed-off-by: Deepesh Varatharajan<Deepesh.Varatharajan@windriver.com> >> --- >> meta-selftest/recipes-devtools/clang/clang_%.bbappend | 2 ++ >> meta-selftest/recipes-devtools/clang/lld_%.bbappend | 2 ++ >> meta-selftest/recipes-devtools/clang/llvm_%.bbappend | 2 ++ >> 3 files changed, 6 insertions(+) >> create mode 100644 meta-selftest/recipes-devtools/clang/clang_%.bbappend >> create mode 100644 meta-selftest/recipes-devtools/clang/lld_%.bbappend >> create mode 100644 meta-selftest/recipes-devtools/clang/llvm_%.bbappend >> >> diff --git a/meta-selftest/recipes-devtools/clang/clang_%.bbappend b/meta-selftest/recipes-devtools/clang/clang_%.bbappend >> new file mode 100644 >> index 0000000000..32c236b972 >> --- /dev/null >> +++ b/meta-selftest/recipes-devtools/clang/clang_%.bbappend >> @@ -0,0 +1,2 @@ >> +# Enable CLANG testsuite >> +CLANG_ENABLE_TESTSUITE = "1" >> diff --git a/meta-selftest/recipes-devtools/clang/lld_%.bbappend b/meta-selftest/recipes-devtools/clang/lld_%.bbappend >> new file mode 100644 >> index 0000000000..32c236b972 >> --- /dev/null >> +++ b/meta-selftest/recipes-devtools/clang/lld_%.bbappend >> @@ -0,0 +1,2 @@ >> +# Enable CLANG testsuite >> +CLANG_ENABLE_TESTSUITE = "1" >> diff --git a/meta-selftest/recipes-devtools/clang/llvm_%.bbappend b/meta-selftest/recipes-devtools/clang/llvm_%.bbappend >> new file mode 100644 >> index 0000000000..32c236b972 >> --- /dev/null >> +++ b/meta-selftest/recipes-devtools/clang/llvm_%.bbappend >> @@ -0,0 +1,2 @@ >> +# Enable CLANG testsuite >> +CLANG_ENABLE_TESTSUITE = "1" > Having bbappends inside meta-selftest isn't something we've done before > and feels a bit odd. I think it will cause yocto-check=layer to fail > too. > > Why wouldn't we just set this variable inside the tests that need it? As you mentioned, yocto-check-layer is failing due to a signature difference with this change. The reason for placing this in meta-selftest is that we’ve observed intermittent issues when reusing sstate, where the required flags are not always enabled, leading to testsuite failures. To make the behavior more consistent and avoid these sstate-related inconsistencies, we opted to set the variable in meta-selftest, since it is included by default when running the testsuite. That said, I understand the concern with this approach given the layer check failure. Is there a better way you’d recommend handling this kind of sstate-related issue? Regards, Deepesh > > Cheers, > > Richard >
On Tue, 2026-05-05 at 15:36 +0530, Varatharajan, Deepesh via lists.openembedded.org wrote: > On 05-05-2026 15:01, Richard Purdie wrote: > > On Tue, 2026-05-05 at 01:16 -0700, Varatharajan, Deepesh via lists.openembedded.org wrote: > > > > > From: Deepesh Varatharajan <Deepesh.Varatharajan@windriver.com> > > > > > > While running testsuite set CLANG_ENABLE_TESTSUITE = "1" > > > > > > Signed-off-by: Deepesh Varatharajan <Deepesh.Varatharajan@windriver.com> > > > --- > > > meta-selftest/recipes-devtools/clang/clang_%.bbappend | 2 ++ > > > meta-selftest/recipes-devtools/clang/lld_%.bbappend | 2 ++ > > > meta-selftest/recipes-devtools/clang/llvm_%.bbappend | 2 ++ > > > 3 files changed, 6 insertions(+) > > > create mode 100644 meta-selftest/recipes-devtools/clang/clang_%.bbappend > > > create mode 100644 meta-selftest/recipes-devtools/clang/lld_%.bbappend > > > create mode 100644 meta-selftest/recipes-devtools/clang/llvm_%.bbappend > > > > > > diff --git a/meta-selftest/recipes-devtools/clang/clang_%.bbappend b/meta-selftest/recipes-devtools/clang/clang_%.bbappend > > > new file mode 100644 > > > index 0000000000..32c236b972 > > > --- /dev/null > > > +++ b/meta-selftest/recipes-devtools/clang/clang_%.bbappend > > > @@ -0,0 +1,2 @@ > > > +# Enable CLANG testsuite > > > +CLANG_ENABLE_TESTSUITE = "1" > > > diff --git a/meta-selftest/recipes-devtools/clang/lld_%.bbappend b/meta-selftest/recipes-devtools/clang/lld_%.bbappend > > > new file mode 100644 > > > index 0000000000..32c236b972 > > > --- /dev/null > > > +++ b/meta-selftest/recipes-devtools/clang/lld_%.bbappend > > > @@ -0,0 +1,2 @@ > > > +# Enable CLANG testsuite > > > +CLANG_ENABLE_TESTSUITE = "1" > > > diff --git a/meta-selftest/recipes-devtools/clang/llvm_%.bbappend b/meta-selftest/recipes-devtools/clang/llvm_%.bbappend > > > new file mode 100644 > > > index 0000000000..32c236b972 > > > --- /dev/null > > > +++ b/meta-selftest/recipes-devtools/clang/llvm_%.bbappend > > > @@ -0,0 +1,2 @@ > > > +# Enable CLANG testsuite > > > +CLANG_ENABLE_TESTSUITE = "1" > > > > > Having bbappends inside meta-selftest isn't something we've done before > > and feels a bit odd. I think it will cause yocto-check=layer to fail > > too. > > > > Why wouldn't we just set this variable inside the tests that need it? > > > As you mentioned, yocto-check-layer is failing due to a signature difference with this change. That means we can't merge this change. > The reason for placing this in meta-selftest is that we’ve observed > intermittent issues when reusing sstate, where the required flags are > not always enabled, leading to testsuite failures. We need to work those issues out then! > To make the behavior more consistent and avoid these sstate-related > inconsistencies, we opted to set the variable in meta-selftest, since > it is included by default when running the testsuite. > That said, I understand the concern with this approach given the > layer check failure. Is there a better way you’d recommend handling > this kind of sstate-related issue? We need to understand what this sstate issue is and fix that. There shouldn't be "sstate issues" causing any problem like this. Cheers, Richard
diff --git a/meta-selftest/recipes-devtools/clang/clang_%.bbappend b/meta-selftest/recipes-devtools/clang/clang_%.bbappend new file mode 100644 index 0000000000..32c236b972 --- /dev/null +++ b/meta-selftest/recipes-devtools/clang/clang_%.bbappend @@ -0,0 +1,2 @@ +# Enable CLANG testsuite +CLANG_ENABLE_TESTSUITE = "1" diff --git a/meta-selftest/recipes-devtools/clang/lld_%.bbappend b/meta-selftest/recipes-devtools/clang/lld_%.bbappend new file mode 100644 index 0000000000..32c236b972 --- /dev/null +++ b/meta-selftest/recipes-devtools/clang/lld_%.bbappend @@ -0,0 +1,2 @@ +# Enable CLANG testsuite +CLANG_ENABLE_TESTSUITE = "1" diff --git a/meta-selftest/recipes-devtools/clang/llvm_%.bbappend b/meta-selftest/recipes-devtools/clang/llvm_%.bbappend new file mode 100644 index 0000000000..32c236b972 --- /dev/null +++ b/meta-selftest/recipes-devtools/clang/llvm_%.bbappend @@ -0,0 +1,2 @@ +# Enable CLANG testsuite +CLANG_ENABLE_TESTSUITE = "1"