| Message ID | 20260429164821.3425757-1-ross.burton@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [01/10] bitbake add firmwaredir | expand |
Hi Ross, On 4/29/26 6:48 PM, Ross Burton via lists.openembedded.org wrote: SoB missing (I'm sure patchtest will soon complain :) ) and a sentence or two as motivation for this patch would be nice :) Also why not export like the other ones? Cheers, Quentin
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/01-10-bitbake-add-firmwaredir.patch FAIL: test Signed-off-by presence: Mbox is missing Signed-off-by. Add it manually or with "git commit --amend -s" (test_mbox.TestMbox.test_signed_off_by_presence) FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence) FAIL: test shortlog format: Commit shortlog (first line of commit message) should follow the format "<target>: <summary>" (test_mbox.TestMbox.test_shortlog_format) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
On Wed, 2026-04-29 at 18:54 +0200, Quentin Schulz via lists.openembedded.org wrote: > Hi Ross, > > On 4/29/26 6:48 PM, Ross Burton via lists.openembedded.org wrote: > > SoB missing (I'm sure patchtest will soon complain :) ) and a sentence > or two as motivation for this patch would be nice :) > > Also why not export like the other ones? The exports are only really there for autotools and some makefiles. They have nasty side effects for task rebuilds so no new exports unless we really have to. I'm actually trying to remove them, or limit their scope. Cheers, Richard
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index 24e095632e9..181221facd6 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -40,6 +40,7 @@ export systemd_unitdir = "${nonarch_base_libdir}/systemd" export systemd_system_unitdir = "${nonarch_base_libdir}/systemd/system" export nonarch_libdir = "${exec_prefix}/lib" export systemd_user_unitdir = "${nonarch_libdir}/systemd/user" +firmwaredir = "${nonarch_base_libdir}/firmware" # Architecture dependent paths export bindir = "${exec_prefix}/bin"