new file mode 100644
new file mode 100644
@@ -0,0 +1,121 @@
+#!/usr/bin/env python3
+#
+# Copyright OpenEmbedded Contributors
+#
+# SPDX-License-Identifier: GPL-2.0-only
+#
+
+import mmap
+import os
+import tempfile
+import unittest
+
+
+# Copied from oe/package.py to allow standalone execution without bitbake.
+def is_kernel_module(path):
+ with open(path) as f:
+ return mmap.mmap(f.fileno(), 0, prot=mmap.PROT_READ).find(b"vermagic=") >= 0
+
+def is_kernel_module_signed(path):
+ with open(path, "rb") as f:
+ f.seek(-28, 2)
+ module_tail = f.read()
+ return "Module signature appended" in "".join(chr(c) for c in bytearray(module_tail))
+
+
+class TestKernelModuleFilenameFilter(unittest.TestCase):
+ """
+ The pre-filter in process_split_and_strip_files() selects candidates to
+ pass to is_elf(). It must use f.endswith(".ko"), not ".ko" in f, to avoid
+ false-positives on compressed modules (.ko.xz, .ko.gz).
+ """
+
+ ko_files = [
+ "driver.ko",
+ "net/foo.ko",
+ ]
+
+ not_ko_files = [
+ "driver.ko.xz",
+ "driver.ko.gz",
+ "driver.ko2",
+ "myko.c",
+ "vmlinux",
+ ]
+
+ def test_endswith_matches_ko(self):
+ for f in self.ko_files:
+ with self.subTest(f=f):
+ self.assertTrue(f.endswith(".ko"))
+
+ def test_endswith_rejects_non_ko(self):
+ for f in self.not_ko_files:
+ with self.subTest(f=f):
+ self.assertFalse(f.endswith(".ko"))
+
+ def test_old_predicate_had_false_positives(self):
+ # Demonstrate that the previous check (".ko" in f) matched compressed
+ # modules — this is the regression the fix addresses.
+ false_positives = [f for f in self.not_ko_files if ".ko" in f]
+ self.assertEqual(false_positives, ["driver.ko.xz", "driver.ko.gz", "driver.ko2"])
+
+
+class TestIsKernelModule(unittest.TestCase):
+ """
+ is_kernel_module() detects kernel modules by searching for the
+ "vermagic=" string, which is always present in genuine .ko files.
+ """
+
+ def _make_tmp(self, content: bytes) -> str:
+ f = tempfile.NamedTemporaryFile(delete=False, suffix=".ko")
+ f.write(content)
+ f.close()
+ return f.name
+
+ def tearDown(self):
+ # Clean up any temp files created during the test.
+ for attr in ("_tmpfile",):
+ path = getattr(self, attr, None)
+ if path and os.path.exists(path):
+ os.unlink(path)
+
+ def test_detects_vermagic(self):
+ self._tmpfile = self._make_tmp(b"\x7fELF\x00" * 10 + b"vermagic=5.15.0" + b"\x00" * 10)
+ self.assertTrue(is_kernel_module(self._tmpfile))
+
+ def test_rejects_plain_elf(self):
+ self._tmpfile = self._make_tmp(b"\x7fELF\x00" * 50)
+ self.assertFalse(is_kernel_module(self._tmpfile))
+
+
+class TestIsKernelModuleSigned(unittest.TestCase):
+ """
+ is_kernel_module_signed() detects the "Module signature appended" tail
+ that the kernel's modsign infrastructure writes.
+ """
+
+ def _make_tmp(self, content: bytes) -> str:
+ f = tempfile.NamedTemporaryFile(delete=False, suffix=".ko")
+ f.write(content)
+ f.close()
+ return f.name
+
+ def tearDown(self):
+ for attr in ("_tmpfile",):
+ path = getattr(self, attr, None)
+ if path and os.path.exists(path):
+ os.unlink(path)
+
+ def test_detects_signed(self):
+ # Pad to >28 bytes so the seek(-28, 2) works; place the magic at the end.
+ tail = b"Module signature appended\n\x00\x00"
+ self._tmpfile = self._make_tmp(b"\x00" * 64 + tail)
+ self.assertTrue(is_kernel_module_signed(self._tmpfile))
+
+ def test_rejects_unsigned(self):
+ self._tmpfile = self._make_tmp(b"\x7fELF\x00" * 20)
+ self.assertFalse(is_kernel_module_signed(self._tmpfile))
+
+
+if __name__ == "__main__":
+ unittest.main()
Add unit tests for the filename pre-filter logic, is_kernel_module(), and the is_kernel_module_signed() detection. Signed-off-by: Sam Kent <sam.john.kent@gmail.com> --- meta/lib/oe/tests/__init__.py | 0 meta/lib/oe/tests/test_package.py | 121 ++++++++++++++++++++++++++++++ 2 files changed, 121 insertions(+) create mode 100644 meta/lib/oe/tests/__init__.py create mode 100644 meta/lib/oe/tests/test_package.py